Extension: Height label

Quote:

---

Originally Posted by karter705

Oh -- for sure, I wouldn't expect folks to maintain extension FGU given that it is in early access (or in general, honestly, its FOSS there is no obligation lol) -- I really only commented in the first place because it had worked and then stopped working, and it seemed you had future proofed it a bit for FGU in the most recent version since you had the check for the FGU client, so I thought you might want to know (and honestly I didn't think I would be able to fix it, or I would've just waited and posted the fix).

In any case, attached is my bodged together fix for FGU 8-20 with Image Tokens, for anyone that is interested (the code change is in the manager_height.lua -- you can unzip the .ext and its in the scripts folder, for those that want to change it themselves) Note: I didn't update the version in the extension metadata because that's how I roll (and I forgot until just now. I don't think it matters)


Thanks again for the great work (this is literally the only extension that I use for FGU :) My players have a bunch of giant owls so it is critical. )

---

Cool, thanks :D and yes, I surely appreciate the informations :)

Hehe, yeah, I am always too optimistic and thought it is now more future-proof, but I am always proven otherwise :D Though the last future-proofness was rather about the grid types :)

Hi :)

This extension will not work with the new version of FGU; sadly, I have absolutely no time now to update things. Hence, better do not use this extension with FGU at the moment :)

But that is based on some report, I didn't check the new changes yet :) So, it may or may not still work :D (as I general advise at the moment :D Sorry, that I have no time yet to fully support FGU :) )

I just did some A/B testing with no extensions and then with just this extension.
It does work (technically), but the color coded arrows for distance have different coloration.
That seems to be the only thing, however, after extended testing.

Quote:

---

Originally Posted by bmos

I just did some A/B testing with no extensions and then with just this extension.
It does work (technically), but overrides some of the new Unity features.
Token locking is functional, but behaves differently and looks different than it does without this extension loaded.

---

Ah oki :) Thanks for testing :)

Oki, I try to update when I get the time :) should be straightforward

Turns out the thing I was seeing is still present without extensions (the arrow color gradient is different for host and client).
I see no compatibility issue (but might be missing one).

The bug seems to be in that the token selection ring and targetting arrow will just have the faction colour then and not the one of the client :)

<- Disregard -> :D

Quote:

---

Originally Posted by Kelrugem

ONLY for FGU :)


Hi :)

Oki, now I took shortly the time to update, it was straightforward, I think :) Beware: I attach the new versions only to this post, because they will not work with the current version of FGC; beware, as usual, a new update of FGU might break it again :)

The following versions are now compatible with the new version of FGU :) Since FGU has now finally hotkeys for rotation, this extension will not overwrite the hotkeys anymore :) The hotkeys are now as usual for FGU, and the height hotkey is now ALT+Wheel :) (over the token on the map)

Please let me know whether it works as intended :)

Best,

Kelrugem

---

Not working on Client side.

Hight with Alt not working.

Selection of Player token on Client side not working.

Quote:

---

Originally Posted by kevininrussia

Not working on Client side.

Hight with Alt not working.

Selection of Player token on Client side not working.

---

I just tested, and I do not have any issues on player side :) Do you run any other extensions?

EDIT: Oh, wait, now I may see what you mean, I shortly take a look :)

Its working.

I had two tokens that were the same and was selecting the wrong one.

Ooops. User error

oki, the stuff with ownerships of tokens is in FGU now completely different seemingly; so, please do not use this extension in FGU now, it is only for FGC. I sadly do not have the time to understand the new ownership structure until I have more time :)

Quote:

---

Originally Posted by kevininrussia

Its working.

I had two tokens that were the same and was selecting the wrong one.

Ooops. User error

---

Nah, there is indeed a problem with the ownership :) I need to cater for all the new settings in FGU in that regard :) (or I hope FGU will have its own height widget :D )

Have you tried, you know, winning the lottery so you can focus on your hobbies 100%? :D

Quote:

---

Originally Posted by Nylanfs

Have you tried, you know, winning the lottery so you can focus on your hobbies 100%? :D

---

:D

Sadly, my research is too interesting for me, too :D

If you are filthy rich even research becomes a hobby... :D

Quote:

---

Originally Posted by Nylanfs

If you are filthy rich even research becomes a hobby... :D

---

hm, you are right...

*Casts haste, leaves flat to buy a lottery ticket!*

:D

Quote:

---

Originally Posted by Kelrugem

Nah, there is indeed a problem with the ownership :) I need to cater for all the new settings in FGU in that regard :) (or I hope FGU will have its own height widget :D )

---

I placed a token on a map (AS GM). WORKS!

I then joined with a player and once in, cleared ownership. Allowed player to take ownership. Player could NOT alter Height on the token on the map (GM could)

I Deleted the token on the map and then replaced it. NOW player could alter the height.

Seems the map remembers who had ownership of token when it was placed on the map. If the ownership changes for some reason, Map doesn't care!

Delete the token and then Replace it...

Ill let you know if I find any other problems

Quote:

---

Originally Posted by Willot

I placed a token on a map (AS GM). WORKS!

I then joined with a player and once in, cleared ownership. Allowed player to take ownership. Player could NOT alter Height on the token on the map (GM could)

I Deleted the token on the map and then replaced it. NOW player could alter the height.

Seems the map remembers who had ownership of token when it was placed on the map. If the ownership changes for some reason, Map doesn't care!

Delete the token and then Replace it...

Ill let you know if I find any other problems

---

Ah, interesting, this will help me in solving the problem later for FGU :) Thank you very much :) (a change of ownership while the token is already placed may be even a problem in FGC, need to test :) )

This is only partially working for me, but I am almost positive it is my environment.

What works:
no key + mouse wheel = does nothing (as expected)
ctrl + mouse wheel = change token orientation
alt + mouse wheel = change token size

What doesn't work:
shift + mouse wheel = it does nothing (and is really the whole point of this extension)

This is with *only* this extension loaded with the 5E ruleset. However, I very much suspect it is the way I am running that is causing my issues.

MacOS 10.15.7 (since Apple dropped 32-bit support, I can no longer run 32-bit Fantasy Grounds Classic directly, thus...)
Parallels Desktop 15
Windows 10
Fantasy Grounds Classic 3.3.11

I'm *assuming* Parallels is either redirecting or blocking the shift + mouse wheel input prior to getting to FG. Anybody seen this issue? Any pointers on testing? I've made some minor tweaks to my parallels config, but so far no luck.

When I have time and am not multitasking with other applications, I'll reboot directly into Windows to confirm this works. Either that or I'll have a remote player test this natively on Windows while I'm running as "normal".

Quote:

---

Originally Posted by Minethulhu

This is only partially working for me, but I am almost positive it is my environment.

What works:
no key + mouse wheel = does nothing (as expected)
ctrl + mouse wheel = change token orientation
alt + mouse wheel = change token size

What doesn't work:
shift + mouse wheel = it does nothing (and is really the whole point of this extension)

This is with *only* this extension loaded with the 5E ruleset. However, I very much suspect it is the way I am running that is causing my issues.

MacOS 10.15.7 (since Apple dropped 32-bit support, I can no longer run 32-bit Fantasy Grounds Classic directly, thus...)
Parallels Desktop 15
Windows 10
Fantasy Grounds Classic 3.3.11

I'm *assuming* Parallels is either redirecting or blocking the shift + mouse wheel input prior to getting to FG. Anybody seen this issue? Any pointers on testing? I've made some minor tweaks to my parallels config, but so far no luck.

When I have time and am not multitasking with other applications, I'll reboot directly into Windows to confirm this works. Either that or I'll have a remote player test this natively on Windows while I'm running as "normal".

---

Yes, some pages before someone else was reporting that it is not (only partially) working for Mac; I asked whether someone can help me to adjust the extension for Macs, but so far I could not adjust it, I am also not sure whether it is possible to adjust this in an extension :) But I hope that there is a solution :)

Quote:

---

Originally Posted by Kelrugem

Yes, some pages before someone else was reporting that it is not (only partially) working for Mac; I asked whether someone can help me to adjust the extension for Macs, but so far I could not adjust it, I am also not sure whether it is possible to adjust this in an extension :) But I hope that there is a solution :)

---

Interesting. I'm running through a windows virtual machine on a mac (rather than running windows natively). It appears whatever MacOS is doing, it is interfering with even a virtual operating system.

I did have one of my players on Windows see if they could change token heights on their end with my current setup. It also didn't work for them. We both noted normal mousewheel does nothing (as expected) and could use Ctrl - Mouse Wheel to change facing, so I assume we are doing this right. I still need to try booting natively to Windows.

There's another extension that does height and a bunch more things (I believe something like combat enhancer + token helper). That one also doesn't work (for setting token height), so I suspect the two are capturing mouse scroll wheel input in a similar way.

Quote:

---

Originally Posted by Minethulhu

Interesting. I'm running through a windows virtual machine on a mac (rather than running windows natively). It appears whatever MacOS is doing, it is interfering with even a virtual operating system.

I did have one of my players on Windows see if they could change token heights on their end with my current setup. It also didn't work for them. We both noted normal mousewheel does nothing (as expected) and could use Ctrl - Mouse Wheel to change facing, so I assume we are doing this right. I still need to try booting natively to Windows.

There's another extension that does height and a bunch more things (I believe something like combat enhancer + token helper). That one also doesn't work (for setting token height), so I suspect the two are capturing mouse scroll wheel input in a similar way.

---

hmmm, very strange. How do you add the tokens? Do you add them from the CT? That is important, otherwise the code cannot add a height label :) Pure naked tokens can have no overlays (as far as I know) :)

Quote:

---

Originally Posted by Kelrugem

hmmm, very strange. How do you add the tokens? Do you add them from the CT? That is important, otherwise the code cannot add a height label :) Pure naked tokens can have no overlays (as far as I know) :)

---

All tokens were from CT. I tried on a PC, a Draft Horse and a wagon (that had a spot on the CT). I believe my player only tried on his own PC.

I can try again if you wish, but I think I did things right.

Quote:

---

Originally Posted by Minethulhu

All tokens were from CT. I tried on a PC, a Draft Horse and a wagon (that had a spot on the CT). I believe my player only tried on his own PC.

I can try again if you wish, but I think I did things right.

---

Hm, I think that there might be indeed some bug, Blackfoot reported some similar bug also some pages ago, but I can sadly not reproduce it, hence, I suspect that it might be caused by something external, maybe a special programme used for defining hotkeys etc., I am not sure.

Can you maybe try one of the other extensions here from the first page? Of a different size. Not that one of these is accidentally wrong for whatever reason while I have the correct code in my own environment :)

Quote:

---

Originally Posted by Kelrugem

Hm, I think that there might be indeed some bug, Blackfoot reported some similar bug also some pages ago, but I can sadly not reproduce it, hence, I suspect that it might be caused by something external, maybe a special programme used for defining hotkeys etc., I am not sure.

Can you maybe try one of the other extensions here from the first page? Of a different size. Not that one of these is accidentally wrong for whatever reason while I have the correct code in my own environment :)

---

I already tried both normal and large versions of the extensions.

I did find something which I believe is the cause of the problem. On MacOS shift-mouse wheel allows you to scroll horizontally (on screens with that have a left-right scroll). Presumably the OS is intercepting the call. I'm not seeing any option in System Preferences for MacOS to disable this "feature". Any chance to change keys?

Without this extension mousewheel alone changes facing.
With this extension, both CTRL-mousewheel and ALT-mousewheel work to change orientation and change token size (forget which order).
I currently have command-mousewheel (command is like the windows key and should be on all macs) set to zoom in and out on my mac screen, but this can be disabled.

Are you using FG Classic or FG Unity?
In FG Unity, I know we just handled that special case on Mac (Shift + mouse wheel translating to horizontal scroll is intercepted back to standard wheel with modifier key).

Regards,
JPG

Quote:

---

Originally Posted by Moon Wizard

Are you using FG Classic or FG Unity?
In FG Unity, I know we just handled that special case on Mac (Shift + mouse wheel translating to horizontal scroll is intercepted back to standard wheel with modifier key).

Regards,
JPG

---

FG Classic. I do have a FGU license, but it's like herding cats to get my players to move...

Quote:

---

Originally Posted by Minethulhu

I already tried both normal and large versions of the extensions.

I did find something which I believe is the cause of the problem. On MacOS shift-mouse wheel allows you to scroll horizontally (on screens with that have a left-right scroll). Presumably the OS is intercepting the call. I'm not seeing any option in System Preferences for MacOS to disable this "feature". Any chance to change keys?

Without this extension mousewheel alone changes facing.
With this extension, both CTRL-mousewheel and ALT-mousewheel work to change orientation and change token size (forget which order).
I currently have command-mousewheel (command is like the windows key and should be on all macs) set to zoom in and out on my mac screen, but this can be disabled.

---

Sadly, I think I can only put things on shift, ctrl and alt :/ The only thing I can really suggest is to switch to unity because of its native Mac support; but I sadly had no time yet to update this extension to unity sadly :)

Quote:

---

Originally Posted by Kelrugem

Sadly, I think I can only put things on shift, ctrl and alt :/ The only thing I can really suggest is to switch to unity because of its native Mac support; but I sadly had no time yet to update this extension to unity sadly :)

---

Since I know these work with Fantasy Grounds while interacting with tokens from the CT (some with and some without your extension):

no modifier key + mouse wheel
CTRL + mouse wheel
ALT + mouse wheel

and only this doesn't appear to work:

SHIFT + mouse wheel

Would it be possible to have your modifier key mapping configurable in the settings menu of Fantasy Grounds? Since we only need 3 modifiers and we have 4 to choose from (assuming "no modifier" is viable) this might be an option to make this work. It should probably default to current configuration to not confuse current users, but assuming this works, it "might" (possibly big assumption) make this work on a mac.

No hurry or pressure if you have other life commitments. I recognize this might be a big ask for potentially a small (and maybe shrinking) portion of your users, so I can survive by fudging and making scribbles on the map as I have in the past...

Quote:

---

Originally Posted by Minethulhu

Since I know these work with Fantasy Grounds while interacting with tokens from the CT (some with and some without your extension):

no modifier key + mouse wheel
CTRL + mouse wheel
ALT + mouse wheel

and only this doesn't appear to work:

SHIFT + mouse wheel

Would it be possible to have your modifier key mapping configurable in the settings menu of Fantasy Grounds? Since we only need 3 modifiers and we have 4 to choose from (assuming "no modifier" is viable) this might be an option to make this work. It should probably default to current configuration to not confuse current users, but assuming this works, it "might" (possibly big assumption) make this work on a mac.

No hurry or pressure if you have other life commitments. I recognize this might be a big ask for potentially a small (and maybe shrinking) portion of your users, so I can survive by fudging and making scribbles on the map as I have in the past...

---

Hm, I try to think about something :) maybe also combinations of two hotkeys instead :) I have sadly not much time at the moment, but I try to think about it when I hopefully have time to update to 3.3.12 (which comes soon) :)

oki, I have finally found the problem in FGU: It is actually also a problem in FGC: It is token locking. Token locking blocks that the players can create their height widget. If someone wants, I can provide now the FGU compatible version but it does not yet work well with token locking :)

I want Kelrugem :D

Quote:

---

Originally Posted by Blackfoot

Hmm.. HEX seemed to work for me.. but.. I'm still running tests for the scaling issue.

OK.. running in Pathfinder with NO other extensions running.. I can't get PCs to scale.
Shift - Mod token Height
Ctrl - Spin the token
Alt - zip

and when I try to do anything in the combat tracker.. nothing happens.

---

Blackfoot, out of curiosity, in case you still follow the thread. Is your problem maybe also linked to lock tokens? I may have found the culprit then (though I do not know yet how to solve that) :) I never used locking tokens so far, that may then explain why I couldn't reproduce it

Quote:

---

Originally Posted by yako2020

I want Kelrugem :D

---

Oh, oops, sorry, I did not see your message because I was writing the other answer to Blackfoot at the same time :D

Yes, I will upload the new version compatible with FGU and 3.3.12 in the next days :)

It looks like that the mentioned bug, where clients cannot create the height widget, is just an edge case, not related to Lock Tokens :) So, not as bad as I thought :) I will write again when the new version is up :)

ok, thanks Kelrugem :D

New version for 3.3.12 :) It now also works with FGU :)

Just some disclaimer: In some very rare occasions it may be that the client cannot produce a height widget, then e.g. create the height widget first as GM, and then the client should have the ownership to do it :) (the only situation I have found was that when the tokens are already on a map when the session starts and the GM did not yet open that map; but after the GM opened the map it should work)

The height label does by the way not yet respect the grid data of the FGU sidebar (where you can now define the range suffix and the increment); I will do that in some future update because that would be probably a nice feature I think :)

Quote:

---

Originally Posted by Kelrugem

New version for 3.3.12 :) It now also works with FGU :)

Just some disclaimer: In some very rare occasions it may be that the client cannot produce a height widget, then e.g. create the height widget first as GM, and then the client should have the ownership to do it :) (the only situation I have found was that when the tokens are already on a map when the session starts and the GM did not yet open that map; but after the GM opened the map it should work)

---

Oh, by the way, since FGU and FGC now have also a hotkey for facing, I mimiced that, so, Shift+Wheel: Facing; CTRL+Wheel: Scaling; ALT+Wheel: Height :) Then the extension just adds something on ALT and does not change typical behaviour

Does the latest version allow to zoom via mouse-wheel when the mouse-pointer is over a token (Unity default)?