Thanks guys - Ive added the base version to the Forge. Will do 5E version soonish...
Thanks guys - Ive added the base version to the Forge. Will do 5E version soonish...
Hi! love the extension. looks like the PF1e version might have broke the character sheet formatting recently. not a big deal tho since it still works!
Attachment 53573
Ive pushed a new update to Forge. Let me know if this works better.
Ya that looks better! thanks!Attachment 53580
Not sure this is how this should look...
Attachment 53871
The 5e extension needs to be updated from away from getactor
Yep, post #81 is the code change needed to get the dice rolling and not error. BUT, it also has some work to be done to get it to align with the character sheet when you are using other extensions, such as character sheet tweaks. I was able to hack damned's code enough to get it to work in my campaign. The new way of adding things to the char sheet definitely caused some breakage with some of the other ext that I was using, so my get it work fix is truly a hack job :)
Phew... definitely better than late-ish!Quote:
Originally Posted by damned
Thanks @damned for all your contributions!
I would love it if you shared your hacks to get it working. I am running a 5e Eberron campaign, and the players are now hooked on hero points ;)Quote:
Originally Posted by scoot138
Hullo.
I'm still having the visual issue with running this in Pf1 that was posted on the previous page of the thread. The header of the character sheet smushes the hero points, name, portrait and token together.
It buries the portrait, which makes it difficult to change it.
Attachment 54231
Thanks!
I have no issue with sharing what I have done to get it to work in 5E, @damned are you ok with me posting the ext I have my hacks applied here. I don't want to assume, as it is your core work.
Scoot
Go for it scoot138
Thanks damned!
Here you go Taralas
Thank you! For a moment, I am getting a few errors, but not certain if this is related to other extensions I have running:
However, it does track the dice, rolls the correct dice type, and is still working with a number of other extensions installed.Quote:
[9/7/2022 4:26:40 PM] [ERROR] Script execution error: [string "nametitle"]:7: attempt to index field 'herodice' (a nil value)
[9/7/2022 4:26:45 PM] s'nodeWin: '
[9/7/2022 4:26:45 PM] databasenode = { charsheet.id-00005 }
[9/7/2022 4:26:45 PM] s'rActor: '
[9/7/2022 4:26:45 PM] { s'sType' = s'charsheet', s'sCreatureNode' = s'charsheet.id-00005', s'sCTNode' = s'combattracker.list.id-00008', s'sName' = s'Reksit' }
[9/7/2022 4:26:45 PM] s'sHeroDiceType: '
[9/7/2022 4:26:45 PM] s'd6'
[9/7/2022 4:26:45 PM] s'sHeroName: '
[9/7/2022 4:26:45 PM] s'Hero Point'
Hero points looks fine one my end for PF1e. You sure it's not another extension that messed it up and you've updated?
Well, just created a new campaign, with only that extension loaded. Used the character wizard to create a Human Fighter, and named him TestTom. Still generates an error. But this time it seems to be tied to the Hero Name:
It also seems to be generating an odd graphic glitch. The name is duplicated in a second box, for some reason:Quote:
[9/7/2022 4:55:29 PM] Tabletop scene starting.
[9/7/2022 4:55:29 PM] NETWORK STATUS: [Server] [Connected]
[Server Type - CLOUD - PUBLIC]
[9/7/2022 4:55:34 PM] MEASURE: RULESETS LOAD - 4.9615029 - 5E
[9/7/2022 4:55:34 PM] MEASURE: EXTENSIONS LOAD - 0 - 0
[9/7/2022 4:55:42 PM] MEASURE: MODULE LIST BUILD - 7.2765003 - 334
[9/7/2022 4:55:43 PM] MEASURE: REFRESH IMAGE ASSETS - 1.1134983
[9/7/2022 4:55:43 PM] MEASURE: REFRESH PORTRAIT ASSETS - 0.009001
[9/7/2022 4:55:43 PM] MEASURE: REFRESH TOKEN ASSETS - 0.6735006
[9/7/2022 4:55:43 PM] MEASURE: ASSET LIST BUILD - 1.7959999
[9/7/2022 4:55:45 PM] MEASURE: LOAD - PART 1 - 15.5290032
[9/7/2022 4:55:45 PM] MEASURE: MODULE LOAD - 0.2519986 - 5E Automatic Effects Player's Handbook
[9/7/2022 4:55:46 PM] MEASURE: MODULE LOAD - 0.7914994 - D&D Player's Handbook
[9/7/2022 4:55:47 PM] RULESET: Dungeons and Dragons (5E) ruleset (2022-09-06) for Fantasy Grounds
Copyright 2022 Smiteworks USA, LLC
[9/7/2022 4:55:47 PM] RULESET: Core RPG ruleset (2022-09-06) for Fantasy Grounds
Copyright 2022 Smiteworks USA, LLC
[9/7/2022 4:55:47 PM] MEASURE: LOAD - PART 2 - 2.1559995
[9/7/2022 4:56:42 PM] Destroying match
[9/7/2022 4:56:42 PM] Tabletop scene exiting.
[9/7/2022 4:56:42 PM] Launcher scene starting.
[9/7/2022 4:56:55 PM] Starting cloud server mode. [Taralas]
[9/7/2022 4:57:03 PM] Game server started. [104.248.118.207:62448]
[9/7/2022 4:57:03 PM] Launcher scene exiting.
[9/7/2022 4:57:03 PM] Match successfully created on lobby.
[9/7/2022 4:57:03 PM] Tabletop scene starting.
[9/7/2022 4:57:03 PM] NETWORK STATUS: [Server] [Connected]
[Server Type - CLOUD - PUBLIC]
[9/7/2022 4:57:08 PM] MEASURE: RULESETS LOAD - 4.9209996 - 5E
[9/7/2022 4:57:08 PM] MEASURE: EXTENSIONS LOAD - 0.0015004 - 1
[9/7/2022 4:57:15 PM] MEASURE: MODULE LIST BUILD - 7.0060004 - 334
[9/7/2022 4:57:16 PM] MEASURE: REFRESH IMAGE ASSETS - 1.0800011
[9/7/2022 4:57:16 PM] MEASURE: REFRESH PORTRAIT ASSETS - 0.0090001
[9/7/2022 4:57:17 PM] MEASURE: REFRESH TOKEN ASSETS - 0.6940028
[9/7/2022 4:57:17 PM] MEASURE: ASSET LIST BUILD - 1.783004
[9/7/2022 4:57:18 PM] MEASURE: LOAD - PART 1 - 15.115502
[9/7/2022 4:57:19 PM] MEASURE: MODULE LOAD - 0.2570002 - 5E Automatic Effects Player's Handbook
[9/7/2022 4:57:20 PM] MEASURE: MODULE LOAD - 0.7985012 - D&D Player's Handbook
[9/7/2022 4:57:21 PM] RULESET: Dungeons and Dragons (5E) ruleset (2022-09-06) for Fantasy Grounds
Copyright 2022 Smiteworks USA, LLC
[9/7/2022 4:57:21 PM] RULESET: Core RPG ruleset (2022-09-06) for Fantasy Grounds
Copyright 2022 Smiteworks USA, LLC
[9/7/2022 4:57:21 PM] EXTENSION: Hero Points for 5e Extension v0.1\rCreated by DIE Hard Gaming\r\nMore great resources at \r\(LINK)
[9/7/2022 4:57:21 PM] MEASURE: LOAD - PART 2 - 2.2448768
[9/7/2022 4:57:39 PM] s'nodeWin: '
[9/7/2022 4:57:39 PM] databasenode = { charsheet.id-00003 }
[9/7/2022 4:57:39 PM] s'rActor: '
[9/7/2022 4:57:39 PM] { s'sType' = s'charsheet', s'sCreatureNode' = s'charsheet.id-00003', s'sCTNode' = s'combattracker.list.id-00001', s'sName' = s'TestTom' }
[9/7/2022 4:57:39 PM] s'sHeroDiceType: '
[9/7/2022 4:57:39 PM] s'd6'
[9/7/2022 4:57:39 PM] [ERROR] Script execution error: [string "hero"]:16: attempt to index a nil value
Attachment 54247
If I go back to the original campaign, it seems to work with following error displayed once on opening a character sheet.
Quote:
[ERROR] Script execution error: [string "nametitle"]:7: attempt to index field 'herodice' (a nil value)
ah sorry, just realized it was @ScribblingRambler that said it was broken for PF1e so I should've replied to them haha
Taralas,
Thats where I had to hack the placement of the overlay on the character sheet. IIRC post #81 listed the change to get them to work. My additional hacks were to make them fit my campaign char sheets
Here is the version with only the code change listed in post #81
Got it. So, it looks like I just need to correct the attachment point for the new frame. Otherwise, the functionality seems to work without a hitch. Thank you!Quote:
Originally Posted by scoot138
I have tried a blank campaign, with only the one extension, and still get the same thing.
Unfortunately, I am not proficient with extension editing, and the 5e hack that Scoot was kind enough to make will not run in Pathfinder1.
What is the actual issue you are having? Can you post a screenshot?Quote:
Originally Posted by ScribblingRambler
Sure thing. It looks like a conflict with MNM Character Sheet Tweaks v7 (from the Forge) and the HeroPoints5e addon. He does seem to have some logic that adjusts the sheet to accommodate the Hero Point fields:
However, there seems to be an issue when the addon attempts to modify the nametitle object.Quote:
<script>
function onInit()
tExtensions = Extension.getExtensions();
for _,vExt in ipairs(tExtensions) do
if vExt=="HeroPoints5e" then
setAnchor("right", "contentanchor", "right", "", "-140");
window.herodice.setVisible(true);
window.hero.setVisible(true);
window.heropointtitle.setVisible(true);
end
end
end
</script>
Working through it now.
Ok, so I have been able to address all of the graphic glitches, and get the functionality working with MNM Character Sheet Tweaks installed. I am passing what I have found back to Mad Nomad to incorporate into his addon, with the correct offsets for the anchor values.
I still cannot get rid of the error related to the herodice script on sheet opening. Will poke at it later in the weekend.
Sure.
It is overwriting the header so the portrait window is inaccessible.
Here is the screen shot from my post on the previous page.
https://www.fantasygrounds.com/forum...1&d=1662495080
This extension is NOT the Hero Points 5E extension that MNM is looking for.
Please post a screenshot of your charsheet without HeroPoints loaded.
Sorry for the cross-talk.Quote:
Originally Posted by damned
Here is the same character without Hero Points.
Attachment 54311
edit: And increasing the size of the charsheet does not help.
Reporting two issues with Hero Point on Pathfinder 1 (Core RPG):
1. There was a FG update some time ago that moved the portrait to the top left of the character sheet, the Hero Point extension displays the character name over the portrait. (See image; this is using the official Pathfinder theme, but it's the same without the theme.)
Attachment 54804
2. With the update this week, double clicking on the hero point to use it reports an error (see attached logs) and doesn't decrement hero points.
Ok, now that I have a few spare moments: I understand that the version that you have posted on the Forge is for CoreRPG, but does not work on 5E due to character sheet changes.
I have attached a copy that I was able to (poorly) hack together with MadNomad, that does work, but it seems to be generating an error on opening an NPC sheet, related to an element of the page:
I am happy to work through this, but I believe that this is just attempting to look up a page element that no longer exists. Would you have any interest in seeing if this last error can be wiped out, and possibly adding it to the Forge for 5E games?Code:[ERROR] Script exection error:[string "CTL:charsheet_overview:nametitle"]:7: attempt to index field 'herocide' (a nil value)
-Taralas
Hiya, the Forge version doesn’t show up as available for CoC 7e. I want to use it for Mythos Points for running Solo Investigator rather than using Modifiers for it.
Hi Guys. I will spend some time on getting these up to date next week.
Would it be possible to get this extension to work with Shadow of the Demon Lord? I am a softy :)
Or maybe just so it increases the number of fortune points...
I am not sure if this is a known issue, but this doesn't show up for Castles & Crusades anymore. It is probably just because the the C&C rule set has been renamed?
This still seems to be an issue unfortunately.Quote:
Originally Posted by lachancery
I can take a look at it and see if I can figure out what the problems are..
Sorry guys... nearly there...
OK.. the fix for the #2 issue is relatively simple.
Replace
withCode:ActorManager.getActor("pc", window.getDatabaseNode());
The first issue is a bit more complicated.Code:ActorManager.resolveActor(window.getDatabaseNode());
More on that later...
As for the First issue.. turns out it is actually pretty simple too.
Remove the "overviewframe" and "name" replacements completely.
Change this line to read:
and this frame to read:Code:<windowclass name="charsheet_overview" merge="join">
Code:<frame_char name="heroframe" insertbefore="overviewframe">
<anchored to="rightanchor" width="130" height="45">
<top />
<right anchor="left" relation="relative" />
</anchored>
</frame_char>
Hi,Quote:
Originally Posted by damned
will there be a version without error soon? On Forge or only here? Can you provide a link to forge please? I canīt find hero there. That extension is awesome!
Thanks
Micael
Thanks, but I have a 5ed version which have an error message- 5ed is the only D&D version where Hero points are used- so why is the Forge version not compatible with the only version where Hero points are used or do I understand something wrong?
Thanks for the link anyway or is this the version from this thread?
Thanks
Micael
Ok kiddies, ive finally updated the 5E version. I will get to the others soon. This will need updating again in a week or three when the next FG build drops.