Pushed 5.98 to TEST Channel with his changes as well. Let me know and if all seems clean I'll push to Live.Quote:
Originally Posted by nephranka
(I dont use the mentioned extensions or much 5e so me testing would be net bad results)
Printable View
Pushed 5.98 to TEST Channel with his changes as well. Let me know and if all seems clean I'll push to Live.Quote:
Originally Posted by nephranka
(I dont use the mentioned extensions or much 5e so me testing would be net bad results)
Thanks Celestian, I can't wait to check it out once it hits live. I don't mess with that test server much haha. I do know I need the update for BCEG to do some features I wanted with AE.
Looks to be working. Thanks!Quote:
Originally Posted by celestian
Thanks, I've pushed 5.98 to LIVE channel.Quote:
Originally Posted by nephranka
Quote:
Originally Posted by nephranka
Thanks again you all for this.Quote:
Originally Posted by celestian
Working great!
Just starting using this amazing extension, I love it!
I'm attempting to introduce a little bit of weapon speed differentiation to Initiative and I've tried applying a -3 modifier to a greataxe several times and I cannot get it to work on neither PC nor NPC, but I have several other modifiers that work flawlessly.
Is there something finnicky in particular about Initiative or could it have a bug given it's a roll that isn't modified often in 5e? Link of the effect on the weapon.Attachment 57258
Double post as I was trying to add a better screenshot.
**Edit**
I realize that INIT -3 does exactly what I'm trying to do and that's what I did while still using AE, but I just wanted to reiterate that I was trying to use the built-in initiative option and it doesn't seem to work.
I've no idea what INIT_AE should do, far as I know thats not a FGU effect tag and definitely not part of my extension.Quote:
Originally Posted by BushViper
That's what the extension produces when you select Initiative from the available options. I didn't manually enter that.Quote:
Originally Posted by celestian
Maybe it's a conflict? I didn't consider it since there was no error message and that'd be a really odd way for a conflict to manifest.
I've confirmed it's not a conflict. The result is the same with only Advanced Effects extension loaded.
That is definitely a bug and surprised it's taken this long to show up. Previously there was a conflict with using the language name "init" so I used "init_ae" to get around it. Problem is changing that language piece also broke this. For now, use the manual mode and use INIT: XXQuote:
Originally Posted by BushViper
Is there a secret to getting to install as an update in FGC? It updates for FGU, but not for FGC.
Never mind. I pulled it from GitHub and patched the startup issues in manager_effect_adnd.lua on lines ~40-80. FGC boot was throwing nil dereference errors at boot.
Code defensively and always check for existence before indexing into objects (even if you think they should be non-nil).
Specifically, you need nil checks on:
CombatRecordManager
CharFeatManager
CharClassManager
CharFeatManager
CharRaceManager
CharManager
Hope that helps.
And...never mind, albeit with the caveat that pulling the update from Forge to FGC still does not work.
Hmmm...also looks like problems with DB.getChildList on line 559 -- same issue -- nil value.
Are these FGC-specific issues?
The Forge has nothing to do with FGC. FGC extras must be manually installed.
@damned is correct. I no longer write/support extensions for FGC.Quote:
Originally Posted by damned
OK -- thanks. It would be helpful to change the text in the first post in this thread that says that it is compatible with FGC and FGU to prevent confusion. Maybe also include text that explicitly says that the latest version does not work in FGC without errors.
Currently, the first line in the post is:
"Latest version currently compatible with FGC and FGU."
Also, if there is a final version that was fully compatible with FGC, it would be great to archive it somewhere and include a pointer to it. I saw that it was indicated as compatible and tried to find it.
Have a look at the code to see if there are any points where the FGU coding could be more defensive. There are a lot of places where there is indexing without object verification.
I have updated the Advanced effects extension, I have also disabled - updated FGU and Re enabled and updated FGU again to make sure I have the most updated copy. I can Add effects to the PC abilities tab BUT these effects are not added automatically when adding the PC to the CT.
Can you show us some screenshots showing what effects you are trying to add.Quote:
Originally Posted by McCherry
One thing I found is that you need to make sure that you toggle the item in your inventory as being equipped and if it was equipped prior to adding the coding, toggle it to unequipped and then re-equip it. I know that's tripped me up initially...
I Can add effects to items, the item is equipped but no effect moves to the CT automatically. I CAN equip an item while the character IS in the CT and that DOES work. Any effect in the abilities tab does not transfer to the CT. See attachment.Quote:
Originally Posted by Zacchaeus
The effects created in the abilities tab of a PC will only apply to the CT when the character is placed on the CT. So if the character is already on the CT then the effects won't be applied. For the effect you want you would be better creating it on the Actions tab of the PC; and you won't need then to remove and replace PCs to get such effects to apply.
Good Day McCherry :)
When you are adding an effect to the player the player then needs to be removed and added back to the CT for the effect to kick in. It looks like you are trying to add an effect to a character that is already on the CT. :)
I am aware of this, this is not the case. I have removed and readded the character, no effects are automated to the CT.Quote:
Originally Posted by Bonkon
This is working for me. I wonder if some other extension that you are using is interfering?
Assistant GM FGU.EXT was the culpritQuote:
Originally Posted by Zacchaeus
Pure voodoo code fix to see if it prevents the conflict as I don't have this extension - if it does not then they will just have to conflict. Basically, at a guess, they are doing the same thing I was...Quote:
Originally Posted by McCherry
CombatRecordManager.setRecordTypePostAddCallback(" charsheet", onPostAdd);
So the best I could do was find if someone already defined this with
savePostAddCallback = CombatRecordManager.getRecordTypePostAddCallback(" charsheet");
and call it first. Of course any extension that does not do this sort of thing for RecordType callbacks will stomp me in turn if load order is not in my favor. Some things just conflict. We will see if this helped.
Silent Ruin Has fixed the issue!Quote:
Originally Posted by SilentRuin
As of tonight, I'm getting an error code every time FGU tries to apply damage or healing to a PC or NPC, and the damage is not applied. Whether it's done by dragging the damage/ healing onto the token, onto the CT listing, onto the PC portrait, or simply having the source of the damage target the target, it doesn't go. This was fixed by reloading without Advanced Effects (found through trial and error by turning off 2 or 3 extensions at a time then reloading, then narrowing it down to one). I can't tell you which other extension Adv Eff may be conflicting with to cause this, but here's theAttachment 57954Attachment 57955 list of what was loaded with it (2 images)
and here is the error message
Attachment 57956
I'm not seeing any errors with this extension. So I would surmise that either one of the (too) many extensions you have loaded is the issue or there is a conflict. You can't really expect Celestian to plow through all of those extensions to find out what might be the issue; if indeed, the issue is a conflict between this extension and some other one. I'm afraid that's up to you.
I'd first check that all of the extensions you have are up to date. Remember that some of those are not on the forge so you'll have to go back to the DMsGuild or wherever you got the extensions and check. Your list also shows some extensions that are no longer needed like token height and I'm not sure you need Better Combat effects and Better Combat Effects Gold. You may want to consider whether you actually need all of those extension as well.
To Zacchaeus' point, you wouldn't need Better Combat Effects if you are running Better Combat Effects Gold. Also, I would add, for any of the DMs Guild extensions, make sure that you've deleted out the old version. Sometimes version names are changed and don't get replaced when adding the newer version. I know I've had that happen with some of Rob's extensions.
token height isn't needed? Is that done natively now?
I don't know which extension might be conflicting with Advanced Effects, but running them all except AE fixed the problem. But yeah, over 3 years I've accumulated quite a few and some, I'm sure, duplicate others. Each of them had a reason to get it at the time I got it.
Here is my recommendation:
- check for each ext the forum thread if it is needed at all. The URLs are usually linked where you got them (Forge, DMsGuild, ..)
- check also if there is an update sometimes, ext have moved from DMsGuild to Forge
- check in the extensions folder for duplicate names if you are sure you got the latest version
- now for debugging:
- copy your campaign folder
- start FGU with half the ext disabled (keep the conflicting one enabled)
- if everything looks okay, verify that with the other half enabled (plus the conflicting ext), the error occurs
- now work with the half which generates the error: disable half of them, verify, disable the other half, etc until you are down to the one which conflicts and the one causing it
Now you are ready to report the error
Looks like there is a UI element that has been deprecated: "windowtitlebar_char template - DEPRECATED - 2023-04-04 - Contact ruleset/extension/forge author"
That errors shows up when you click to edit the effect on an item.
Had the same thing pop up for me a moment ago.Quote:
Originally Posted by nephranka
Also, the bug with Init_AE is still happening.
The console logs shouldn't "popup" unless you open the console and look?
DEPRECATED doesnt mean its broken, just the next major update or so it will go away (CoreRPG). I'll address it when the next major updates come through. This "should" just be a log no one will see unless they look at the logs.
It is a chat output message. You see this in the bottom left of my screenshot. Which again is not a big deal. I was passing it along as information.
Oh, yuck. yeah that is not nice. I dunno why they put it out in chat and not console log. I'll see what I can do but it'll be a week or so (in day job travelQuote:
Originally Posted by nephranka
for 2 weeks).
I pushed 5.100 today to Forge that should clear up that ugly error message.Quote:
Originally Posted by celestian
I used to use this extension and it was one of my favs and a must imho, but I can't make it work now. When I add an effect to an item and try to edit it, the window is blank:
Attachment 58408
Am I the only one getting this issue?