5E Advanced Effects (items, npcs, characters)

Quote:

---

Originally Posted by MeAndUnique

Thanks for reporting. Turns out the ruleset changes on TEST affected everything I had added for this. I have what I think to be a solution ready for celestian to review, so hopefully it all looks good and will be ready for testing before long.

---

Quote:

---

Originally Posted by celestian

This rev (5.8) is now pushed to Test.

---

Using version 5.8 almost everything seems to be working as intended!
Testing with only this extension enabled, Feats, Class Features and Racial Traits are correctly being added to the character's advanced effects and their active effects in the combat tracker. However, this only occurs if the character is indeed added into the combat tracker.
If the character is absent from the combat tracker and a Feat, Class Feature or Racial Trait is added to the character sheet the effect will not be added to their advanced effects even if you later add them to the combat tracker.

I've also tested this extension with several other extensions enabled and did not notice any conflicting issues thus far.

Thanks for the quick update and hope this helps again!

What's going to happen with the new version of Advanced Effects?

Quote:

---

Originally Posted by FGUDM

Using version 5.8 almost everything seems to be working as intended!
Testing with only this extension enabled, Feats, Class Features and Racial Traits are correctly being added to the character's advanced effects and their active effects in the combat tracker. However, this only occurs if the character is indeed added into the combat tracker.
If the character is absent from the combat tracker and a Feat, Class Feature or Racial Trait is added to the character sheet the effect will not be added to their advanced effects even if you later add them to the combat tracker.

I've also tested this extension with several other extensions enabled and did not notice any conflicting issues thus far.

Thanks for the quick update and hope this helps again!

---

Sorry about that. Another update is ready for celestian to review. Hopefully the last time else any patience for my antics be completely exhausted :p

Quote:

---

Originally Posted by MeAndUnique

Sorry about that. Another update is ready for celestian to review. Hopefully the last time else any patience for my antics be completely exhausted :p

---

Pushed 5.9 to Test channel.

Quote:

---

Originally Posted by MeAndUnique

Sorry about that. Another update is ready for celestian to review. Hopefully the last time else any patience for my antics be completely exhausted :p

---

No worries! Your hard work is very much appreciated! And thanks again for the quick update!

Quote:

---

Originally Posted by celestian

Pushed 5.9 to Test channel.

---

From what I've noticed in 5.9 so far, everything seems to be working as intended now, really looking forward to using this in the LIVE build of the game! :)

Quote:

---

Originally Posted by FGUDM

No worries! Your hard work is very much appreciated! And thanks again for the quick update!

From what I've noticed in 5.9 so far, everything seems to be working as intended now, really looking forward to using this in the LIVE build of the game! :)

---

Glad to hear that ! Once the Beta is released I'll push this out to Live immediately.

I just had an Error pop up when trying to add an NPC to the combat tracker. After going into my test campaign and checking each extension individually I determined that it was the Automatic Effects extension. My test campaign for troubleshooting is 5e in the TEST channel and the extension version for this extension is 5.9. The error is this. Script execution error: [string "script/manager_effect_adnd.lua"]:352: attempt to call field 'addNPC' (a nil value).

Oh yeah, the changes to TEST earlier this week would likely cause problems. Probably fairly easy to migrate to the new CombatRecordManager-based functionality, which is a pretty slick improvement imo.

I'm trying to build a Survivor like ability into a weapon attack. It should read like this...

IF:Bloodied;REGEN:5

With the Action Only checked on. Am I doing something wrong or maybe these syntax options are not supported by this feature?

Quote:

---

Originally Posted by septantrionalis

I'm trying to build a Survivor like ability into a weapon attack. It should read like this...

IF:Bloodied;REGEN:5

With the Action Only checked on. Am I doing something wrong or maybe these syntax options are not supported by this feature?

---

There is no action only here. You should uncheck that.

I'm not seeing it work, with or without the action only option applied. I do want the regen to trigger on the attack or damage.

Quote:

---

Originally Posted by septantrionalis

I'm not seeing it work, with or without the action only option applied. I do want the regen to trigger on the attack or damage.

---

REGEN is only evaluated at the start of the actors turn. It's not 5EAE that doesn't support it, it is just REGEN doesn't work like how you are trying to use it.

Ok. Thanks you. Do you know if AC also works the same? Start of turn only? What about HEAL?

Quote:

---

Originally Posted by septantrionalis

I'm not seeing it work, with or without the action only option applied. I do want the regen to trigger on the attack or damage.

---

Quote:

---

Originally Posted by septantrionalis

Ok. Thanks you. Do you know if AC also works the same? Start of turn only? What about HEAL?

---

Well, there is no action in the post you made, thus you can't use action only, no matter what your coding is or isn't, it's still not an action.

Can you explain exactly what you are trying to do? Maybe I can help.

Quote:

---

Originally Posted by MrDDT

Well, there is no action in the post you made, thus you can't use action only, no matter what your coding is or isn't, it's still not an action.

Can you explain exactly what you are trying to do? Maybe I can help.

---

I'm trying to create a unique weapon ability that, when the PC uses this weapon and they are bloodied (half HP or less), the PC is healed for x. If they don't use this weapon, they should not benefit from the healing.

Quote:

---

Originally Posted by septantrionalis

I'm trying to create a unique weapon ability that, when the PC uses this weapon and they are bloodied (half HP or less), the PC is healed for x. If they don't use this weapon, they should not benefit from the healing.

---

What do you mean by "use this weapon"?

Like hit something with it? Do damage? Equipped? Attuned?

Also how long does the "used" part last? 1 round? a week?

Quote:

---

Originally Posted by MrDDT

What do you mean by "use this weapon"?

Like hit something with it? Do damage? Equipped? Attuned?

Also how long does the "used" part last? 1 round? a week?

---

A single attack (or damage) made with the weapon would trigger a heal, if the wielder is bloodied.

Quote:

---

Originally Posted by septantrionalis

A single attack (or damage) made with the weapon would trigger a heal, if the wielder is bloodied.

---

I'm not aware of anything that will accomplish exactly the "on attack" trigger. The Action Only option from this extension is designed to cause effects that normally apply to every weapon action (attack and damage modifiers being the primary use case from the ruleset) and make them instead apply only when this specific weapon is used. The problem is that the REGEN effect has nothing to do with actions that Watsons make, as mentioned it applies simply at the start of the character's turn.

You might be able to use Better Combat Effects to make it work when the weapon deals damage though. I think SDMGADDS and DMGA are the two to look at, off the top of my head.

Quote:

---

Originally Posted by septantrionalis

A single attack (or damage) made with the weapon would trigger a heal, if the wielder is bloodied.

---

I'm going to assume a few things, like it's not temp HP, you only wanted it once a turn, etc.

This code will require

Advanced Effects and Better Combat Effects Gold.


This below goes on the weapon itself.
SDMGADDS: LoveTap; DUSE; ATURN
(Make sure to click action only)


This below goes in the effects list in the top right.
LoveTap;IF:Bloodied; REGENE: 5


DUSE will cause it to disable each attack, ATURN turns it back on at the start of any turn (note this is not start of round, so this can make it happen 2 times in a round, but only once a turn)

This also will heal at the end users turn. There are other ways to automate it but seemed like this one fit the best. You can use REGENA: 5 if you want it to insta heal, however, that can have other issues I've seen.

Let me know how it works out for you.

Todays FG update impacted this extension. Adding an NPC to the combat tracker throws an error.

The error is:

[7/12/2022 7:31:33 PM] [ERROR] Script execution error: [string "scripts/manager_effect_adnd.lua"]:341: attempt to call field 'addNPC' (a nil value)

Update should be live now.

I am in the middle of several projects of my own and travelling for work so I'm not actively monitoring things currently.

Quote:

---

Originally Posted by MrDDT

I'm going to assume a few things, like it's not temp HP, you only wanted it once a turn, etc.

This code will require

Advanced Effects and Better Combat Effects Gold.


This below goes on the weapon itself.
SDMGADDS: LoveTap; DUSE; ATURN
(Make sure to click action only)


This below goes in the effects list in the top right.
LoveTap;IF:Bloodied; REGENE: 5


DUSE will cause it to disable each attack, ATURN turns it back on at the start of any turn (note this is not start of round, so this can make it happen 2 times in a round, but only once a turn)

This also will heal at the end users turn. There are other ways to automate it but seemed like this one fit the best. You can use REGENA: 5 if you want it to insta heal, however, that can have other issues I've seen.

Let me know how it works out for you.

---

Thank you, MrDDT. This looks great. I've bee moving and haven't been able to test it out yet. I'll post again, once I've been able to do so.

Hi Celestian,

the 5E advanced effects extension seems to be incompatible to the official Level Up for 5E extension after the latest update. Opening any feat record entries of the LU Player´s Guide or the D&D Player´s Guide create following errors:

[7/17/2022 9:18:48 PM] [WARNING] window: Unable to locate control (text) specified in insertbefore attribute for control (advanced_effects_contents) in windowclass (reference_feat)
[7/17/2022 9:18:48 PM] [ERROR] Script execution error: [string "reference_feat"]:6: attempt to index global 'text' (a nil value).

When the 5E Advanced Effects extension is disabled all Feat record entries open as expected, both from the Level Up Player´s Guide and the D&D Player´s Guide as well. The same happens when the Level Up 5E extension is disabled and the 5E Advanced Effects extension is loaded.

I also informed Leozelig who is the author of the Level Up 5E Extension and he will take a look on this issue.

Maybe it´s possible to make this extension compatible to Level Up 5E.

Thanks in advance :)

I'm encountering a pretty awful bug given the new updates that have happened and I've isolated it down to a conflict between 5E - Advanced Effects and Better Combat Effects Gold.
Attachment 53634

I think it has to do with the ActionDamage.applyDamage header change in 5E Ruleset.

Quote:

---

Originally Posted by jfg1984

I'm encountering a pretty awful bug given the new updates that have happened and I've isolated it down to a conflict between 5E - Advanced Effects and Better Combat Effects Gold.
Attachment 53634

I think it has to do with the ActionDamage.applyDamage header change in 5E Ruleset.

---

As I dont use applyDamage in AE I expect it's in your other mod... you should remove it and test...

When I ran only better combat effects gold it worked as intended.
When I ran better combat effects gold with advanced effects the bug was generated so it seems to be down to some interaction between the two extensions rather than an error existing solely in better combat effects gold.

That’s bceg. Working on it tonight. Sorry for the issue, got surprised by this update

Quote:

---

Originally Posted by rhagelstrom

That’s bceg. Working on it tonight. Sorry for the issue, got surprised by this update

---

No worries, thank you for the quick turn around. I'd hate to part with either BCEG or Advanced Effects, they're both so good!

It seems there's a conflict between this extension and Close Encounter (my own creation). Is the code for this available anywhere so I can design a fix? My code is available on github (https://github.com/Gtaray/CloseEncounters).

The conflict is around the actions buttons on the actions tab on the PC sheet. Likely something is overwriting my own changes to power_action and power_action_mini, or it's overwriting the PowerManager.getPCPowerAction and PowerManager.performAction functions that my extension modifies.

I'm happy to help get this sorted.

Quote:

---

Originally Posted by Saagael

Is the code for this available anywhere so I can design a fix?

---

https://github.com/CelestianGC/AdvancedEffects

Quote:

---

Originally Posted by bmos

https://github.com/CelestianGC/AdvancedEffects

---

Thats the repo there for code on live. I do try and keep it current (it is right now) but it's not always ;)
\

Any updates? :) I love this addon so much it's not even funny :)

Quote:

---

Originally Posted by Carpathian

Any updates? :) I love this addon so much it's not even funny :)

---

No, if you're having a issue please post specific errors and version you are running. If it's a interaction with another extension I'd point you at that authors thread.

Quote:

---

Originally Posted by MrDDT

I'm going to assume a few things, like it's not temp HP, you only wanted it once a turn, etc.

This code will require

Advanced Effects and Better Combat Effects Gold.


This below goes on the weapon itself.
SDMGADDS: LoveTap; DUSE; ATURN
(Make sure to click action only)


This below goes in the effects list in the top right.
LoveTap;IF:Bloodied; REGENE: 5


DUSE will cause it to disable each attack, ATURN turns it back on at the start of any turn (note this is not start of round, so this can make it happen 2 times in a round, but only once a turn)

This also will heal at the end users turn. There are other ways to automate it but seemed like this one fit the best. You can use REGENA: 5 if you want it to insta heal, however, that can have other issues I've seen.

Let me know how it works out for you.

---

Ok. I've moved, completed a business trip, and now I'm back at it. I was happy to spend the $5 for BCEG extension as I've already experienced the many benefits of BCE. This worked perfectly. Thank you.

I have a few relating questions to learning about the previous effect combo in this thread.

1. When referring to the "Action Only" check box, what constitutes an action? I assumed, when an effect was applied to a weapon and the Action Only box was checked the triggering "action" would be either the attack roll or the damage roll for that weapon.

2. "SDMGADDS" = SOURCE of the attack will add an effect to the SOURCE (itself) when damage is done. Is there any syntax that allows for the same except triggering on an attack? Something like: SOURCE of the attack will add an effect to the SOURCE (itself) when an attack is made.

3. I learned previously in this thread that REGEN only applies at the start of turn.
a. Are AC and HEAL are treated the same?
b. Can anyone direct me to where this is documented? I do not see it in the Fantasy Grounds wiki for 5e effects.

Quote:

---

Originally Posted by septantrionalis

I have a few relating questions to learning about the previous effect combo in this thread.

1. When referring to the "Action Only" check box, what constitutes an action? I assumed, when an effect was applied to a weapon and the Action Only box was checked the triggering "action" would be either the attack roll or the damage roll for that weapon.

2. "SDMGADDS" = SOURCE of the attack will add an effect to the SOURCE (itself) when damage is done. Is there any syntax that allows for the same except triggering on an attack? Something like: SOURCE of the attack will add an effect to the SOURCE (itself) when an attack is made.

3. I learned previously in this thread that REGEN only applies at the start of turn.
a. Are AC and HEAL are treated the same?
b. Can anyone direct me to where this is documented? I do not see it in the Fantasy Grounds wiki for 5e effects.

---

BCEG documentation https://www.fantasygrounds.com/forum...6&d=1659564720

Probably best to further this discussion over there

Doh! I forgot where I was. Thank you. The Action Only question is still appropriate for this thread.

When referring to the "Action Only" check box, what constitutes an action? I assumed, when an effect was applied to a weapon and the Action Only box was checked the triggering "action" would be either the attack roll or the damage roll for that weapon.

Quote:

---

Originally Posted by septantrionalis

Doh! I forgot where I was. Thank you. The Action Only question is still appropriate for this thread.

When referring to the "Action Only" check box, what constitutes an action? I assumed, when an effect was applied to a weapon and the Action Only box was checked the triggering "action" would be either the attack roll or the damage roll for that weapon.

---

Only those two things. Attack and Damage rolls.

Quote:

---

Originally Posted by septantrionalis

Doh! I forgot where I was. Thank you. The Action Only question is still appropriate for this thread.

When referring to the "Action Only" check box, what constitutes an action? I assumed, when an effect was applied to a weapon and the Action Only box was checked the triggering "action" would be either the attack roll or the damage roll for that weapon.

---

Action only means the effect is only applied when using an attack/damage action/rolls.