Printable View
I noticed that when a weapon has a fixed damage this ext throws an error:
[8/20/2025 6:26:51 AM] [ERROR] Script execution error: [string "DamageRerollFeats:..nager_action_damage.lua"]:398: attempt to index field '?' (a nil value)
I am not sure this is expected or not?
5e, only this ext loaded. Weapon configuration attached.
Sorry l, will be able tontake care of this after the 5th of September. Not sure if I can get to it soonerQuote:
Originally Posted by nephranka
No worries.Quote:
Originally Posted by lprchaun
Sorry this took so long. Easy fix, but I was away from my computer for over a week. (Serious Withdrawals).
fix is uploaded to forge
Looks to be working. Thanks!Quote:
Originally Posted by lprchaun
This is still delisted in the Forge so can't access it.
When will this be released to the "Production" Channel?
Sorry...not sure how that got delisted.Quote:
Originally Posted by SmackDaddy
There seems to be a conflict between this extension, and one I'm developing.
Does it call ActionsManager.registerPostRollHandler?
Quote:
Originally Posted by jkeller
yes I do call it to update some numbers, but it then runs the actual onDamageRoll handlers so I think it should be okay to do more things afterwards
I addressed it for the moment.
The base code only allows one handler, and there's no way for extensions to get any existing handler. So any handler that runs last will be the only one that runs.
My extension overrides the code that registers handlers, and I set it to run early. So, if another extension tries to register, I can capture it and the dispatch to it.
The devs said they will change the code to add a way for extensions to get any registered handler, so we can "chain" ourselves. Not sure when that will happen.
The savage attacker is only rerolling one of the two weapon dice now. Not sure what changed?
Using Greatsword. it only offers to reroll the first of the two d6's rolled.
I fixed it my adding a bit of code to the CountD, also added a check to make sure it ignored other dice that might get added by CT effects, so it only rerolls the weapon dice.
local CountD = 0;
local nOrigClauses = tonumber(rRoll.nOrigClauses) or 1;
local nClauseCount = 0;
local sEffectsExpr = string.match(rRoll.sDesc, "%[EFFECTS (.-)%]") or "";
local aEffectsDice = DiceManager.convertStringToDice(sEffectsExpr) or {};
local nEffectsDice = #aEffectsDice;
for sDmgType, sDmgExpr in string.gmatch(rRoll.sDesc, "%[TYPE:%s*(.-)%s*%(([^)]*)%)%]") do
nClauseCount = nClauseCount + 1;
if nClauseCount > nOrigClauses then break; end
local lowerType = sDmgType:lower();
if string.match(lowerType, "slashing") or string.match(lowerType, "piercing") or string.match(lowerType, "bludgeoning") then
local sDiceExpr = string.match(sDmgExpr, "(.-)=%d*") or sDmgExpr; -- Strip =total if present
local aTempDice = DiceManager.convertStringToDice(sDiceExpr) or {};
CountD = CountD + math.max(0, #aTempDice - nEffectsDice); -- Subtract effects dice
end
end
Quote:
Originally Posted by bwatford
the extension should be making sure it is just the weapon dice already.
and I know it was rolling all damage die before.
I know there were alot of changes in the last update, but I have been unable to test my extensions. I am in the process of selling my house and moving so my free time has been non-existent. I know a couple of problems popped up with great weapon master as well so I will be looking into fixing this extension As soon as I can.
Sorry to everybody being affected.
I programmed these for 5E feats.Quote:
Originally Posted by MrDDT
What other damage reroll options are you talking about?
Hello
I just bought and installed the extension and it works as inteded (5e, 2024).
If I may, i want to add a suggestion. It would be nice to have an option to select, if the feat is automatically used or if the promt should appear. It could be nice for if a player does not want to confirme eatch round the only attack it can make.
Have a nice day
Greetings
Frectorius
Updating. I am still in the process of moving so I am between two houses (not to mention fixing issues with house that is being sold, etc.) so I have not had time to address the issues that recently popped up.
I want everybody to know I have not forgotten will be getting to these items as soon as I can!
Looks like on TEST:
When any damage is rolled:
[3/18/2026 7:10:56 AM] [ERROR] Handler error: [string "DamageRerollFeats:..nager_action_damage.lua"]:57: attempt to call global 'onDamageRoll' (a nil value)
Passing it along
Just checking back in since TEST will be live soon.
Hi,
With this active, every attempt at rolling damage comes up with this error (same as reported above):
[ERROR] Handler error: [string "DamageRerollFeats:..nager_action_damage.lua"]:57: attempt to call global 'onDamageRoll' (a nil value)Attachment 67465
Still broken on release. Do you have a repo? I could have a PR up pretty quick to fix.
finally got through my move so I will be addressing issues now.
Sorry again to everybody.
@lprchaun,
I have this mostly reworked; so stand by. I'll provide a copy to you when I'm done.
Regards,
JPG
Sorry again...I didn't realize that FGU totally reworked how the wrappers work. or at least that seems to be the problem.Quote:
Originally Posted by Moon Wizard
ok...the way damage is handled was totally changed.Quote:
Originally Posted by Moon Wizard
Just pushed an update for this extension. Please run a new Check for Updates to get the latest changes; which addresses the errors with the latest Core changes.
I've provided the latest code to @lprchaun for longer-term support.
Regards,
JPG
THank you for your help! I will be continuing support as needed.Quote:
Originally Posted by Moon Wizard
The hard part was fixed, missing a little bit in how the damage is handled (everything is displayed correctly in the chat window, but the damage that is applied to the target is alwasy from the original roll. it never updates based on the savage attacker or piercer reroll)
I am currently working on that.
My DM and my battle master fighter thank you!Quote:
Originally Posted by lprchaun
Need any help? I've got some bandwidth.Quote:
Originally Posted by lprchaun
This extension got pulled from Forge. Does that mean it's done for?
I see the @lprchaun delisted the extension recently; but will have to see if he meant to, or if it was accidental.
EDIT: I heard back from @lprchaun. The updates I helped with didn't quite fix it all the way; and they are still working on it.
Regards,
JPG
Got the extension working again.
Again, very sorry to everybody in how long this took. Life got in the way at the wrong time
I would like to thank everyone that helped and to thank everybody for their patience.
The extension is being re-listed now..