[Theme] SirMottes Magnificent Darkness

Quote:

---

Originally Posted by SilentRuin

Hearth theme breaks global effect button at the top left of the combat tracker.

---

Try it now... there was some invisible element overlapping the button making it unclickable. Fix is in v2.9.50

Quote:

---

Originally Posted by JustinFreitas

Try it now... there was some invisible element overlapping the button making it unclickable. Fix is in v2.9.50

---

Worked.

I found an issue today in my 5e (legacy) campaign and the Life Ledger addon and your Magnificent theme.

When you set the option in Life Ledger to show 'Current HP' instead of 'Wounds', the column in the combat tracker does not change to 'CUR' for current hit points, it is stuck on 'Wnd'. It seems to be a cosmetic issue as it still seems to function properly.

I was able to duplicate the issue with just with the Life Ledger addon and the Hearth theme enabled. See the attached screenshots.


Attachment 67801

Attachment 67802

Attachment 67803

I'll see what I can do. The extra columns from life ledger aren't coming in either (learned that when trying to fix the header) but that might have to wait as it's way more complex. We'll see how it goes.

Any chance the map window for layers can show the selected layer? Right now the selection color must be the same color as the background color - you can't tell what layer is active.

Maybe. This theme is work for me for no money so if it's something easy that I can do and not be annoyed, sure... if not, then no. I'll let ya know.

I had Claude dig in on it and here's the response (TL;DR - it thinks it's an engine side thing that isn't overridable via the theme):

Thanks for the report — I dug into this and it's unfortunately an engine-level limitation rather than something the Hearth theme can fix. The map Layers window (including the highlight on the active/selected layer) is drawn internally by the Fantasy Grounds Unity client, not by the ruleset or theme. FG doesn't currently expose a theming hook for that selection color, so no theme — Hearth or any of the built-in ones — can recolor it. On dark themes the engine's selection tint ends up very close to the background, which is exactly what you're seeing.

The right path to get this fixed is on the SmiteWorks side. I would suggest posting it on the official FG forums or bug tracker as a request to make the Image Layers selection highlight theme overridable, or higher contrast on dark themes. They have already made several engine side dark theme adjustments to the Image Window, so this is in line with fixes they do. Happy to help you write that report if you would like, and I will keep an eye out for an API hook in future FGU builds. If one appears, I can add it to Hearth right away.

Quote:

---

Originally Posted by Toadkiller

I found an issue today in my 5e (legacy) campaign and the Life Ledger addon and your Magnificent theme.

When you set the option in Life Ledger to show 'Current HP' instead of 'Wounds', the column in the combat tracker does not change to 'CUR' for current hit points, it is stuck on 'Wnd'. It seems to be a cosmetic issue as it still seems to function properly.

I was able to duplicate the issue with just with the Life Ledger addon and the Hearth theme enabled. See the attached screenshots.


Attachment 67801

Attachment 67802

Attachment 67803

---

I posted a fix for this in Test. If it seems good after a bit, I'll promote it to Live.

Quote:

---

I posted a fix for this in Test. If it seems good after a bit, I'll promote it to Live.

---

Thanks for looking into this. I saw that the Hearth addon was updated today, so I took a shot that you have pushed it to Live, but it still shows WND when Life Ledger is set to show 'Current HP'.
Attachment 67812

Let me know if I have jumped the gun and it has not been pushed out yet.

I haven't pushed it but now that I know you are available to test, I'll do it now.

Ok, I just switched it from Test to Live. Good luck, have fun.

Awesome, thanks! Just updated and it seems to be working great!

@JustinFreitas,

You can specify a <color> tag under the imagedatacontrol definition. Did you already try that?

I've also sent the note to Carl.

Regards,
JPG

Quote:

---

Originally Posted by Moon Wizard

You can specify a <color> tag under the imagedatacontrol definition.

---

Thanks, I'll give that a shot.

Ok, it's kinda weird the way it works and blends with that top toolbar but I found a color that doesn't look too bad and you can still see the selected layer a little bit. It's .53 in Test

Quote:

---

Originally Posted by JustinFreitas

I had Claude dig in on it and here's the response (TL;DR - it thinks it's an engine side thing that isn't overridable via the theme):

Thanks for the report — I dug into this and it's unfortunately an engine-level limitation rather than something the Hearth theme can fix. The map Layers window (including the highlight on the active/selected layer) is drawn internally by the Fantasy Grounds Unity client, not by the ruleset or theme. FG doesn't currently expose a theming hook for that selection color, so no theme — Hearth or any of the built-in ones — can recolor it. On dark themes the engine's selection tint ends up very close to the background, which is exactly what you're seeing.

The right path to get this fixed is on the SmiteWorks side. I would suggest posting it on the official FG forums or bug tracker as a request to make the Image Layers selection highlight theme overridable, or higher contrast on dark themes. They have already made several engine side dark theme adjustments to the Image Window, so this is in line with fixes they do. Happy to help you write that report if you would like, and I will keep an eye out for an API hook in future FGU builds. If one appears, I can add it to Hearth right away.

---

Attachment 67813

Submitted a change to make the layer background and hover colors match the specified foreground color with an alpha applied. It should be available when the next client update is released.

This fix is available in the Test channel now; and will be available in Live on the next release.

Regards,
JPG

Cool... looks good. I restored the original dark panel color in .54 on Test. I made the .53 active on Live as the color tweak there does show the highlighted layer better. When Test goes to Live, I'll do .54 to Live.