Very minor but I'll mention it in case it's an easy fix while you're in there:
With only Combat Groups and Hearth loaded, the combat groups drop down / visible / group fields extend slighting into the header of the CT graphically.
Attachment 61536
Printable View
Very minor but I'll mention it in case it's an easy fix while you're in there:
With only Combat Groups and Hearth loaded, the combat groups drop down / visible / group fields extend slighting into the header of the CT graphically.
Attachment 61536
Story entry padding looks perfect with today's update v2.9.32. Thank you!Quote:
Originally Posted by rocketvaultgames
You're welcome. Trying to knock things out a little bit at a time. More soon.
Hi rocketvaultgames. I was able to get the red/green identified and visibility icons working. I'll put those out in tomorrow's release (.34, 8/17/24) as they didn't make the push I did earlier today for the CT entry vert height adjustment (.33, 8/16/24)Quote:
Originally Posted by rocketvaultgames
Fantastic! I'll check back again tomorrow.Quote:
Originally Posted by JustinFreitas
Thanks again!!
Huge thanks for all of these updates. Everything is functional and aside from a very minor things it's perfect.
Small issues that might be worth looking at:
1 - With Combat Groups, the buttons at the top and the token overlap the header slightly
2 - There is no padding at the top of the footer, and would probably look better if there was a couple of pixels of buffer.
Attachment 61638Attachment 61638
Ok, thanks. I appreciate the reminders and screenshots. I'll see what I can do about these things.
I just noticed that you did the Green/Red for IDs in the record headers as well. This is an AMAZING improvement!
Based on this being possible, I'd suggest coloring the symbols for sharing as well:
3 People - Public - Green
1 Person - Shared - Blue
Not Shared - Either Red or keep as white... I'm honestly not sure what's better.
One more thought...
This seems slightly confusing at a glance to have this be red. I'm thinking white or yellow/cream here might be better. The toggle of red/green in the header is great for current status.
Attachment 61661
Check out v2.9.36 (8/20/24) on the Forge and lemme know what you think.Quote:
Originally Posted by rocketvaultgames
Amazing. Thanks!!Quote:
Originally Posted by JustinFreitas
As far as I can tell everything is at least "good enough" or better at this point. The new default dark theme is a huge improvement over the old default, but Magnificent Darkness still steals the show!
Any idea why some PC portraits in the CT have the yellow/gold gradient square around them and others don't?
Nolo and Nimway have them. Strorth and Brooks don't.... I don't see anyone with them in the Characters database. The source files don't have them. It seems to be only with Hearth running...
Attachment 61758
It's a frame that the PC portraits sit atop that shows the gradient border.
Looks like your character list portrait sizing got outta sync with the sizing to show the frame gradient. I'll look into it.
I can't replicate that behavior... all PCs have the gold frame for me in the Character Selection window and the Combat Tracker. Could you try with only the Theme loaded and see if it's all gold frames? Would you like to see the gold frames go away? I think we could accomplish that pretty easily. I do like the gold frames but they are a bit of a headache because they are non-standard and sometimes stuff comes along that breaks them and readjustment is needed. Lemme know, thanks.Quote:
Originally Posted by rocketvaultgames
I seem to be getting these errors on start up. I think it's causing the sidebar icons and font to be black on black background.
[10/7/2024 6:34:25 PM] [ERROR] Script execution error: [string "FGU-Theme-Hearth:..pts/manager_desktop2.lua"]:12: attempt to call field 'setSidebarDockCategoryIconColor' (a nil value)
[10/7/2024 6:34:25 PM] [ERROR] Script execution error: [string "FGU-Theme-Hearth:..cripts/manager_theme.lua"]:5: attempt to call field 'setSidebarDockCategoryIconColor' (a nil value)
[10/7/2024 6:34:26 PM] [WARNING] Frame chatbox contains out-of-range values in BottomLeft.
[10/7/2024 6:34:26 PM] [WARNING] Frame chatbox contains out-of-range values in Bottom.
[10/7/2024 6:34:26 PM] [WARNING] Frame chatbox contains out-of-range values in BottomRight.
I'm using Xcore as a system.
And for some reason the version of the extension is at 2.9.21 despite having been just updated from forge?
I just loaded Xcore with Hearth theme, no problem. 2.9.21 is your problem. Clear out the old stuff.
Quote:
Originally Posted by JustinFreitas
My bad, I found the problem. There were 2 hearth files. One from forge and I guess one I DL'd manually a long time back, I guess.
I must have missed this reply some time ago...Quote:
Originally Posted by JustinFreitas
I just checked with only the Theme loaded. It is the same. None of the characters have the frame in Character Selection nor on the PC sheet. In the Combat Tracker and when placed on a map, some are missing the gold frame. I tried removing and re-adding to the CT to no avail. It doesn't seem to be related to file type(png/jpg/webp)/size/dimensions.
I do like the gold frames as well. They look good and distinguish at a glance between PCs and friendly NPCs with a square token.
I'd have to look again to see if I notice anything. Are you running against just the one .ext file? No other folder or theme ext conflicting?
I double checked. Yes. Only the theme loaded v2.9.41 (and no other themes loaded):Quote:
Originally Posted by JustinFreitas
Attachment 62551
The plot thickens...Quote:
Originally Posted by rocketvaultgames
Just messing around with dragging portrait to token - flat field and then to the CT I was able to get the frame to show on the map, but still not on the CT where I dropped it:
Attachment 62552
Yeah, I was just able to recreate your problem. You can 'fix' it by deleting the Token - Flat image from the Portrait and Tokens window (using the trash can when hovered). Then, select that PCs portrait again using the top 'Portrait' icon in the Portrait and Tokens window so that Token - Flat gets reset with the new portrait image. Then, delete and redrag/add the PC to the CT from the Characters window and it should have the frame. I didn't make a code fix for this... and might not going forward since it can be coerced into displaying the frame like that. Good luck!
Got 'em fixed. Thanks for your input!Quote:
Originally Posted by JustinFreitas
I'm not sure if the color of this text is available for you to change, but I'm hoping so as it's a brand new feature.
It's visible, but quite dark on dark:
Attachment 62652
...and the obligatory just checking to see if this can be changed as it's very difficult to read:
Attachment 62653
The good parts still far outweigh the few issues with this theme. Thanks for all you do!
I submitted a fix for dark mode UIs. It will be available in the next hot fix.Quote:
Originally Posted by rocketvaultgames
This is now Live. Please run a new Check for Updates.
Regards,
JPG
AMAZING! Thank you.Quote:
Originally Posted by Moon Wizard
Thank you rocketvaultgames for reporting the issue and another round of thanks for pindercarl and Moon Wizard for the fixes!
Hello again pindercarl and Moon Wizard. Can you give a similar treatment to the 'View Type' dropdown as shown in this screenshot? Thanks!
View Type dropdown needs dark theme treatment
Attachment 62806
Pathfinder 2E
If the PC is a prepared caster it's quite hard to see the small bubble/dots that you mark to show it when the Actions tab is in Preparation mode.
Is it possible to make the dots another color or more visible?
Getting some interesting vertical blue lines and well as a tiny horizontal blue line on the left with the new FG update (v4.6.6) at UI Scale 165% (3840x2160)...
Attachment 63515
At 150% the vertical lines disappear but the small horizontal on the left is present.
125% makes more lines...
100% and 160% seem to be OK.
Interesting, thanks. I'll see what I can do.
I'll take a look. This is likely caused by an update to frame rendering in v4.6.6.Quote:
Originally Posted by rocketvaultgames
FYI: I was getting these blue lines with no theme loaded. But they are now gone. I suspect pindercarl fixed it. Thank you pindercarl, if that's the case.
Blue lines are gone with Hearth at 165% today.
Thank you.
There was a rounding error with some themes at different UI scales. The rounding error has been addressed, and all of the themes should be working properly now. Let me know if you see any other errors. Thanks.
The lines are still there at 161, 162, 163, 164% (at 3840x2160). 165% is fixed.Quote:
Originally Posted by pindercarl
Thanks for the follow-up. I missed an additional rounding error. This should be fixed in the next Release update in the Live channel.Quote:
Originally Posted by rocketvaultgames
Any chance you can fix the graphical anomaly with: "windowmenubar_charsheethelper"
Attachment 63544
It would be nice if the buttons were fully inside the header.