Printable View
I mean, I guess you could do that but why clutter up the Powers when Fantasy Grounds provides the capability natively? Simply click the magnifying glass on the WEAPONS heading on the actions tab and add the number of extra critical die you should use, you just set it and forget it and it works for all weapons regardless of the dice type.Quote:
Originally Posted by Poe the Homunculus
Also, if manual steps are going to be required, better to delete an effect once per item than remember to activate an ability every time a crit is rolled in addition to setting up a new ability for every damage type and dice used by the characters weapons. Plus multiple damage instances is detrimental for automating things like concentration and can cause rounding differences in case of resistance.
Hello celestian.
The issue I am seeing is rather esoteric and is probably based on my very specific circumstances/setup, so, that said, should you wish to ignore this issue, no biggie.
I run a 5E solo campaign at times in which I have at my disposal 5 PC's.
To repeat the behavior:
(1) I started the DM/GM instance on my PC.
(2) I then started a second instance of FG on the same computer, my "Player" instance.
(3) I connected the Player instance to the DM instance using "Join Campaign" over a LAN connection to "localhost".
(4) In the Player instance I brought in all five of my characters to the campaign.
(5) In the DM instance, when I dragged each of the five PCs into the Combat Tracker, the portrait displayed in the chat window was the same for each of the characters. In this case the PC in the left-most position on the desktop.
Attached is a screenshot that indicates that the only extension that I have loaded is the Advanced Effects extension and that, as far as I know it is the latest version (from FG Forge). Note that for each of the PCs the portrait in the Chat is that of "Tamsin"; not the actual portrait of the PC (as seen in the upper left).
Again, this is pretty esoteric, and doesn't seem to affect play. When one of the PC's attacks an NPC, the proper portrait is displayed in the chat. The only time the wrong portrait is displayed is when the PCs are initially dragged into the Combat Tracker.
[EDIT] forgot the screenshot, so here it is.
Attachment 50052
Thanks celestian, I really appreciate your work.
Hello again celestian,
Unfortunately I have found another peculiarity. I had reported the oddity to the 5E bug reports thread and was told by Moon Wizard that the issue is probably caused by an extension. Low and behold, after a little more investigation, I have confirmed he is correct and that your fine extension is the culprit.
The bug report can be found here, posts 761 and 762.
Attached is a screen shot indicating that your extension is the only one loaded.
(When it is not loaded the problem is not observed).
Portions of the sub windows in the screen shot are:
(1) the chat - indicates Advanced Effects is the only extension loaded
(2) a brand new, empty character sheet
(3) the AC/Init/Speed sub dialog - with errors circled.
Attachment 50074
Must be something they recently started using. I needed it for the cycler menus I use. I'll tweak it so mine doesn't override 5e.Quote:
Originally Posted by Minty23185Fresh
As to your other question, I've been aware of that issue but not looked into fixing it. It's a one time issue that frankly I can't see causing anyone much consternation. I am also not entirely sure it's something I can correct. I suspect it's related to how CoreRPG handles owners and not being in initiative.
Is there a way (using this extension or otherwise) to have a Wand of the War mage +1 work as an equipped effect? I've been going into each attack spell and individually adding the +1 manually. I am not concerned with ignoring 1/2 cover, I can factor that in myself on a case by case basis.
I dont think there is but you can go into the spells meta data and give the +1 there and not have to do each individual spell. I just recently acquired a +2 Rod of the PactKeeper and found that was what worked.
Let me know if this helps or if need more info
I'm not familiar with 5e or the ruleset "that much" so you'll have to explain a bit more. I don't think that you can have a item with powers attached to it in the 5e ruleset? If you only need to add +1 to all attacks if they have it equipped then it should add it to all attacks if it's not flagged "action only".Quote:
Originally Posted by eporrini
https://i.imgur.com/FIxdbuJ.jpeg
The above doesn't work as it will apply to everything.Quote:
Originally Posted by eporrini
You need to edit each spell/group according assuming they have it out and equipped.
Or you can have them apply the effect when it's equipped and it will effect all attacks. You can make it effect ONLY ranged attacks thus limiting your chances of forgetting, however, your spells like shocking grasp would miss out on the effect. I've found it best to apply it to all spells manually in the spell itself (or the overall grouping). Then if you don't have it equipped for the rare casts, give yourself a modifier -1 when using that like that. Most of the time players are going to use the wand out.
Unfortunately most recent update seems to have borked everything.
"Handler error: [string "scripts/manager_affect_adnd.la"]510:attempt to call field 'getActorFromCT' (a nil value)" when attempting to auto-apply an effect by equipping an item.
After some investigation for my extensions failing with this error I found that the getActorFromCT function has been depricated and replaced with resolveActor.
Ive replaced it for all my errors with success, even got 5e Enhancer components working
The getActorFromCT affected the versions Im using of "5E Enhancer - Wounds:, 5E Enhancer - Faction Underlays" as well as the one above "AdvancedEffects"
Example of what I changed in the 5E Enhancer Wounds
Example of what I changed in AdvancedEffectsQuote:
--local actor = ActorManager.getActorFromCT(ctEntry);
local actor = ActorManager.resolveActor(ctEntry);
If the Devs of the extentions can review and verify the change then they can update for everyone to download.Quote:
--local msg = ChatManager.createBaseMessage(ActorManager.getActo rFromCT(nodeChar),sUser);
local msg = ChatManager.createBaseMessage(ActorManager.resolve Actor(nodeChar),sUser);
Belay my previous update, it's still borked, no update today. Having a calcItemArmorClass problem now.
OK, fixed the code you suggested (in manager_effect_adnd.lua.)
Removed a "whitespace error" at the start of extension.xml (or it might have been the advanced_effects.xml.)
Replaced depreciated ActorManager2 with ActorManager5e in the char_weapon_adnd.lua.
Then commented out references to calcItemArmorClass in the char_invlist_adnd.lua.
And it seems to be working for now.
thanks for the first step, and the impetus to try fixing the code myself!
The advanced effects I have attached to NPCs no longer seem to be making it to the Combat Tracker. Image attached.
What error is it giving in the log? I managed to hack together a (mostly) working version over the last couple hours.
Quote:
Originally Posted by Hjorimir
Working fine for me, did you drag the NPC to the CT after you added the effect?Quote:
Originally Posted by Hjorimir
@picaroon, there's no actual error given, but the effects are not placed on the CT.
@MrDDT, yes, the picture that I attached shows the monsters before they were added to the CT and the effects are not listed.
Well based on where you placed the Advanced Effect, it will not update until you move the NPC or PC to the CT.Quote:
Originally Posted by Hjorimir
If you put it on an item, you can unequip/reequip it.
That's what I'm saying...
1) Add the advanced effect on the NPC, example; ADVINIT to the skeleton with broadsword
2) Then add that monster to the Combat Tracker
3) The effect is not listed under the monster on the Combat Tracker
Here's a gif of it not working.
@picarron, I was mistaken. There is a console error and I know (now) that it is coming from this extension (loaded a new campaign with only the extension active). I've attached an image.
My testing:
1) Take a monster that has an advanced effect (in this case, I gave it ADVINIT) and then added it to the CT. I get the error (attached) and the effect doesn't appear.
2) Remove the effect from the monster, it is added to the CT without the error. Naturally, the effect doesn't appear (as expected in this case).
s'ActorManager.getActor - DEPRECATED - 2021-01-01 - Use resolveActor' (this message x3)
s'ActorManger.getType - DEPRECATED - 2021-01-01 - Use getRecordType/isPC'
[ERROR] Script execution error: [string "scripts/manager effect adnd.lua"];525: attempt to call field 'getActorFromCt' (a nil value)
You are using version 4.9, you should be using 5.0.Quote:
Originally Posted by Hjorimir
I've pushed for updates multiple times and I'm getting it from the Forge. How can I force the update?
Well it should work that way, I'm not sure why it's not.
Because this file is stored in the VAULT, it's a little harder to track, however, he was nice enough to put it on GITHUB, so you can download it there on the first page, goto the FORGE and disable the download and hide it. Then run your updater again, which should remove it from your VAULT, then you can put the GITHUB one in your EXT folders with all the other DATA exts and it should work fine, only you wont get updates for this EXT as you've turn them off (and were not getting them anyways for some reason) and have to manually download them from the GITHUB as he updates it.
Well, that did the trick. Frustrating that the Forge can't seem to update the files appropriately. I added to your rep, MrDDT. Thank you very much for the support!
No problem glad it worked out. I scratch my head over the EXTs I use a lot of them so if a basic long standing on like this isn't working it can really mess up all my others. So it's all good. Got it knocked out.Quote:
Originally Posted by Hjorimir
I just skimmed the text, but it sounds like that you use the extension now by putting it in your extensions folder?Quote:
Originally Posted by Hjorimir
That may be then also your culprit from before. Did you have a version of this extension also in your extensions folder? Beware that extensions of your extensions folder always overwrite the vault. Hence, if you had an older version there while the forge downloads to the vault, then the older version of the extensions folder always overwrote the forge version :) To solve this one simply has to get rid of the non-vault one.
(Similarly, unpacked extensions overwrite zipped extensions etc., which is why one suggests not to keep unpacked rulesets and extensions in the main folders)
If I'm being honest here, I don't even know what 'the Vault' is. I've always operated under the assumption that you put extensions in the extension folder (this is from before the Forge was even a thing). Over the years, I've purchased extensions from DM's Guild/Drive-Thru RPG and that's where the instructions said to put them. I was assuming that the subscription to extensions from the Forge would operate likewise and that it would handle overwriting the extensions there for you automatically.
Besides the extensions folder you also have a vault folder :) Crafter can choose to use the vault instead, then their work is encrypted. Hence, if Celestian chose to do this, then the forge version will be put to the vault folder :) If you already had the extension in the extensions folder, then the forge version got overwritten.Quote:
Originally Posted by Hjorimir
If you want you can try it out: Delete/Remove all the versions of this extension in the extensions folder, subscribe to the forge item, and test again :)
You need to get the latest version of AdvancedEffects. Base on the posts following I presume you have updated now and it's working. I've been on travel and unable to respond.Quote:
Originally Posted by picaroon
In our game tonight, we are using v4.9 and get the "Handler error: [string "scripts/manager_affect_adnd.la"]510:attempt to call field 'getActorFromCT' (a nil value)" when adding an NPC to the CTQuote:
Originally Posted by celestian
The newest version is 5.0Quote:
Originally Posted by mattekure
ok. 5.0 wasnt listed in the first post, didnt know an update had been pushed.Quote:
Originally Posted by MrDDT
Yeah, Core update went live when I was traveling and all I could do was make sure the forge was updated. If you're running forge it should be fine.Quote:
Originally Posted by mattekure
Hi - I am running the extension out of the Forge, and I am getting the "Handler error: [string "scripts/manager_effect_adnd.la"]525:attempt to call field 'getActorFromCT' (a nil value)" error. None of the effects I have equipped on the weapons seem to work on PCs?
I am also totally lost on how to be coding this. I want to add an effect, even the sample "IFT: ALIGN (evil); AC: 2;" but cannot figure out what any of the codeing means or is? Help, please?
Then you must have a local copy of the extension from previous version. Remove that and any extracted folder of the same name. I am certain of this as that function is no longer present in the latest version.Quote:
Originally Posted by Poe the Homunculus
I looked in the extension folder and found an extension from 7/11/2021 called "AdvancedEffects.ext". Deleted. What is the current .ext file named? I don't see any other .ext with AdvancedEffects.
Thank you very much!
Advanced Effects ext is stored in the vault if you get it from the forge.Quote:
Originally Posted by Poe the Homunculus
However, if you put an ext named the same in your data folder (where all the extensions goes normally), it will override the anything going to the vault.
So deleting the one in your data folder, and then updating FGU, it should trigger you to get the most current updated ext, however, you wont see it in your data folder because it goes to the vault.
So, delete any .ext files I have that I currently have from Forge so they can be updated in the vault? This will Auto update them?
Well if you worried, you can move them out to another folder so you have them just in case. I also wouldn't delete anything that is not this without backing it up first.Quote:
Originally Posted by Poe the Homunculus
But yes that will trigger it.