Printable View
I've updated the front page to better reflect the changes in leadership and have a more neutral tone. @Justin you might want to update the forge entry accordingly.
Regarding the visuals issues from downsizing, I'm unsure if this will ever be noticed by anyone but me, so don't break a leg over it.
Done, thanks.Quote:
Originally Posted by SirMotte
Ok, thanks... I'll see what I can do about replacing them back to their original state.Quote:
Originally Posted by SirMotte
Is there a way to change the color of the text for spells? My players aren't a fan of the red text. We all have old eyes and wear glasses. :(
Can't read text in map editor for paint/line size entry fields.
Yeah, that one is gonna be a while... I can't find where those are accessible and also why some look correct and some don't. Sorry for the bad news.Quote:
Originally Posted by SilentRuin
Simple trial and error allows you to find it - I saw it was yellow and that you used FFF0CA for that - searching your .ext for all references to that showed a handful of files - replacing all in each file trial and error showed me which was the guilty file and then replacing several at a time in that file let me find the culprit. Naturally (yeah I'm pretty jaded with FGU so take my side commentary with a grain of salt) FGU put the wrong foreground color in those fields I referenced. They used the panel foreground color instead of the field foreground color. They got away with this as both background colors showed black text up. But in your world the panel background color and the field background color are dark and light respectively. I'd suggest telling them to fix it but that will likely result in them putting it in some "someday, when we have time" list which may never get done. So for now I'd suggest choosing a color that works in both light and dark backgrounds. Grey looked nauseous to me on the panel even though it worked - so I suggest bronze.Quote:
Originally Posted by JustinFreitas
corerpg_compilation.xml
Code:<template name="imagedata_record_step">
<imagedatacontrol>
<invisible />
<color>cd7f32</color> <!-- Replaceable Color: Primary Foreground -->
<backcolor>232323</backcolor> <!-- Replaceable Color: Primary Background -->
</imagedatacontrol>
</template>
Quote:
Originally Posted by SilentRuin
NICE!! That was making me angry and I tried a few times to fix it but always ended up frustrated and with no fix. I figured there was a bug in FGU because fields right next to each other had a different font color. Anyway, I appreciate that find and the community loves you for it, I'm sure. I'll get your change in this weekend. Thanks!
Feel free to find a different color solution now that you know the issues. I did not try changing the foreground/background for field colors and panel colors to find some better combo. I stopped at "good enough" on my second try on panel foreground color.Quote:
Originally Posted by JustinFreitas
I see you went with the light grey - ah well - good enough ;)
lol... yeah, I went with the nauseating grey... I got less sick looking at that than the bronze. We'll see what the peanut gallery says over time. I noticed changing that foreground color also changes the image menu bar above the foreground color frame too. Would just be nice if they fixed that display bug in the fields to always be black font on white field... then we could put it back to the yellow/cream color and life would be good. Maybe someday!Quote:
Originally Posted by SilentRuin
You could "try" to report it and request they fix it. Trivial fix for them - I'm just jaded over asking for any timely fixes - still waiting on a asset webm initialization fix going on 6 months. Why I suggested you just try to make your own work around.
Yeah... no thanks. I'll choose to maintain my sanity for now.Quote:
Originally Posted by SilentRuin
It might not be "perfect", but this is soooo much better! Thank you both for identifying it and fixing it.
Quote:
Originally Posted by SilentRuin
Or--just hear me out here--go ahead and report it so that there's at least a CHANCE that it will get fixed. Otherwise, don't and keep around one more thing to complain about if you like that sort of thing. ;)Quote:
Originally Posted by JustinFreitas
These two things could likely be handled by different people and, thus, prioritized differently.
Honestly, I would just do it for you because this would impact anyone trying to do their own theme but I'm not sure where to point them. File/line numbers would be ideal.
Likely in engine code so only the screen shot I gave earlier would apply. They would have to figure out the where and what was done wrong. We can only see it - not effect it - or JustinFreitas would have simply been able to fix it instead of "fooling it" with a kludge.Quote:
Originally Posted by wndrngdru
Thanks @SilentRuin. Problem reported. Hopefully it'll be one of those "I'm already in here, I'll just fix this too" kind of things.Quote:
Originally Posted by SilentRuin
A lot of the new functionality in the TEST build will require dark theme rework. Just a heads up that change is coming and it will be hard to say when I'll be able to get all of the new features accounted for in the theme. The project is on Github for anyone interested in contributing code to assist with the new feature translations to this theme. https://github.com/SirMotte/FGU-Theme-Hearth
Loving the theme, however, I run Savage Worlds Adventure Edition games with some degree of frequency, and I have noticed some readability issues. Specifically, there are some text fields that use a black font on the dark background. I've done my best to pinpoint them with red dots, however redundant that might be.
Character Skills tab (the Advances field on this sheet is also affected)
Character Inventory tab
Character Notes tab
NPC Skills tab
Vehicle sheet (title only)
Abilities sheet
Edge sheet
Hindrance sheet
Skill sheet
Notes (open note title only)
Nice job on the issue write up. Let me see what I can do for ya. I'm trying to get the beta changes done first then I'll get around to these. Thanks!
Happy to contribute! :)Quote:
Originally Posted by JustinFreitas
I'd just concentrate on getting the "drop dead can't run with it" issues and leave the rest for whenever you can get around to them. Right now in TEST I cannot share a map so have turned it off. For some reason they have an extra click added to share maps and its not showing up with hearth loaded (plus the map seems out of synch with its base frame - though that can wait.Quote:
Originally Posted by JustinFreitas
Thanks, SilentRuin. Yeah, this weekend I was able to get a bunch of the issues knocked out. Should be mostly ok for the release but there are a few things that I need to take care of that are giving me a little bit harder of a time. I'll keep fiddling with it and see what works.
Big shocker... they busted you again in TEST.
[ERROR] Script execution error: [string "Theme_SirMotte_Hearth:..ewindow_toolbar.lua"]:42: attempt to index global 'image_view_token' (a nil value)
lol… they set the DC too high and I’m rolling at disadvantage. TEST channel is wild!
Whenever possible, you should not be overriding individual control locations with themes, only adjusting frames/fonts/icons, etc. Anything else will always be affected whenever underlying windows change.
Also, the toolbar was completely overwritten, and uses standardized frames/icons with the Test version.
Please let me know if you have any questions.
Regards,
JPG
Thanks Moon Wizard. Is is possible to have a multistate toggle typed toolbar button? Then I could make the pressed and unpressed button frame transparent. I’ll look in the docs tonight.
Technically, you could do that with a field button type, and define more than 2 icon states.
See ToolbarManager.registerButton("locked", ...) in CoreRPG; and add another state to the registration.
Regards,
JPG
Just FYI - TEST works fine with this theme now (at least in 5E).
Yeah, I got that issue you last mentioned fixed earlier in the week. Thanks for all of your input and help around the beta!Quote:
Originally Posted by SilentRuin
Hi Muagen, I went to see about making the changes when I realized that ruleset is a paid ruleset and I don't have it. I know there is a 30 return policy on FG store stuff, so maybe I can get it, make the fixes, and return it or something like that. Alternately, you can turn on debug mode and give me the window classes of all of the fields that need fixing. That does sound more painful than the first idea though. Hmmmm...Quote:
Originally Posted by Muagen
Can't hurt to ask the authors to gift it to you or give you a temp copy - they can only say "no" which is fine. This theme is the only one I use (and the only one I know of that actively supports extensions) so they may be willing to give you a helping hand if you ask.Quote:
Originally Posted by JustinFreitas
Hey Darkness lovers... with the new 4.5.0 release, I just published the fixed up version to the Forge. Lemme know if you run into any issues. There were alot of changes and I did what I had to do to get things working and looking good enough. I hope it works for you. Post up if you encounter issues. Thanks!
v2.9.23 - Torchbearer, 3/6/24
Looks like Combat Tabletop List (new feature) is broken in the theme... so don't use that for now. lol
There are still a few fields that show up dark in the image data pane but those are FGU bugs so we'll have to get those reported and hopefully fixed soon.
I haven't seen anything reported either before or during the beta testing; and I normally don't check individual extension threads. I'm trying to look at every thread for a short time to help catch changes, or make suggestions.
You'll probably want to post details in the Workshop forum with what you feel is a FGU bug.
Regards,
JPG
Yeah, thanks. He got many of the field text fixed to use the foreground color. Looks like three remain. I'll get it reported tomorrow.Quote:
Originally Posted by Moon Wizard
With only the theme loaded:
Inactive tabs on PC and NPC sheets in D&D 5e seem to have a darker font that previously. Still readable, but pretty hard to see.
It also seems like the quality of the text is worse. More pixelated?? 4k HDR / UI Scale 160
Attachment 60021
This doesn't affect functionality but I'm noticing when opening a PC record, both Main and Actions tabs are highlighted. Clicking Actions de-highlights the Main and everything behaves properly after that.
I'm surprised I haven't seen this posted yet, but it appears window resizing for images isn't functioning properly, all other types of windows work fine however with images specifically you can resize either horizontally or vertically but not both at the same time, the resizing arrows for horizontal and vertical are very finicky on images as well.
I'll add it to the list, thanks. In the meantime, you can hold down the control key and drag within the window to resize (normal FG functionality) if you don't wanna fidget with the finicky resizing arrows.Quote:
Originally Posted by Barricade1443