-
Hey chooms, it's me again!
I'm getting error messages when opening certain NPC records. It's happening on the Pyro from the base RED ruleset; every "Gonk" type NPC from the CEMK (Edgerunner, Maelstrom, REO Meatwagon, Valentino); Nitro, Stingball, Rocky Erikson and Rocky's Hustle from EMK: Karaoke Night; and the Arasaka Soldier and AV Turret from the EMK: The Jacket.
The error only pops up the first time I open those records. I can reproduce this each time I boot up FG. Doesn't seem to actually prevent using the NPCs, though.
There may be other NPC records affected but I don't really wanna click my way through every NPC to find out. :)
[ERROR] Script execution error: [string "C:npc_mook:bodyCurrent"]:59: attempt to index field 'subwindow' (a nil value)
[ERROR] Script execution error: [string "C:npc_mook:bodyFrame"]:10: attempt to index field 'subwindow' (a nil value)
[ERROR] Script execution error: [string "C:npc_mook:bodyCurrent"]:59: attempt to index field 'subwindow' (a nil value)
e:
I am also getting an error message when opening certain character sheets (he is the only player who is using the Advanced view mode for Cyberware, maybe that's why?).
[ERROR] Script execution error: [string "C:charsheet_cyberware:refreshTables"]:17: attempt to index field 'subwindow' (a nil value)
-
I actually had some similar issues with character sheets last week, and Rough Patch actually had the NPC issue. I pushed some fixes that should hopefully fix it and be live Tuesday.
The window timings appear to have been reworked with the last major update, so I just needed to expand some of the nil checks.
-
One of my players found another sneaky lil error message yesterday on the newest patch. This one popped up when he tried to lower the SP of his armourjack manually. It works anyway, but I figured I'd mention it. :)
[ERROR] Script execution error: [string] "CoreRPG:common/scripts/number.lua"]:43: attempt to call global 'getValue' (a nil value)
-
That's a strange one; since that is a built-in function. Are you able to recreate every time? If so, can you provide the steps?
Thanks,
JPG
-
I was able to reproduce the issue
- by opening a charsheet,
- adding an armor from the items (I selected heavy armorjack)
- selecting the input box
- holding ctrl, and scrolling to increment the number.
I do remember having an issue with typing in numbers previously but we fixed that forever ago. Looking over the code, I don't see any listeners of note on it (there's an onInit listener that I could see potentially affecting things, but I find it unlikely), and all references to the field appear to use DB nodes.
Other number nodes (like the cash node) do appear to work. In fact, if I modify the number node inside of the item using the same method, it doesn't have a problem. (Although the node in the item is a different node...it basically sets a default value that doesn't change when the armor ablates)
-
Are you at any point destroying/creating the number control, or the subwindow containing the number control? Perhaps based on changing values in the code causing a listener to perform a change like that?
Regards,
JPG
-
actually, I found a space we appear to be doing that. I'll see if I can find a fix.
-
I pushed some changes as a hotfix that should fix the issue (at least it did in my testing). The armor section was a piece I developed early on, before I understood how nodes related to windows. This fix converts it to just filter on the inventorylist with a few specific rules on what should be displayed when.
It's always a treat looking back on my questionable decisions :p In any event, it should be a bit more future-proofed now.
-
1 Attachment(s)
SmiteWorks Core Dark Theme gives white on white text in some parts of the Books. For instance, Cyberpunk Red player book, section on "Other Corps of Note" has this;
Attachment 65200
-
Are you using the basic black and red theme?
EDIT: Sorry, you said Core Dark.
