point taken sorry. created new campain with only this extension. Combat modifier extension v1.6
error in the log window is.
Attachment 51519
Printable View
point taken sorry. created new campain with only this extension. Combat modifier extension v1.6
error in the log window is.
Attachment 51519
this is the screen i launched the attack from... i note there is an error in the chat window missing atk....
Attachment 51520
That helps a lot. I’ll take a look.Quote:
Originally Posted by wakhere
@wakhere, I've reproduced the error you posted and have a fix for it. I should be able to get it up on the Forge by this afternoon.
The message "Weapon atk not found" is just informational. When an NPC makes a ranged attack, there isn't any range increment data with it, so it looks up the weapon name in a table. "atk" isn't in the table, so it can't calculate range modifier and puts out that message (this isn't a problem with PCs since the weapon range is on the PC sheet).
Update is live on the Forge.
Fixed: NPC with no feats making a ranged attack caused error.
I have added several weapons and fixed some typos in the "data_common_custom.lua"
I fixed bolas, shortbow and repeating crossbow in the original code (typos and wrong range on shortbow)
And I have added every firearm from here: (I have max 1 range increment for early firearms and 5 for modern just to remind people that it is outside touch attack. Maximum range increments is 5 for early and 10 for modern.)
https://www.d20pfsrd.com/equipment/weapons/firearms/
And I have added almost all the weapons that where missing from this list (I did not add some weapons which I did not exactly know
https://www.d20pfsrd.com/equipment/weapons/
And I did try to test out the change, but when I overwrite the extension and load up a existing campaign the extension file overwrites itself with the original rules it looks like (because of forge of cache?). I did not test this, but I did follow your format. So if I have not made a "," error this should work I think.
Here is everything inside "weaponranges" function: (copy paste should hopefully work)
Code:["blowgun"] = {20, 10},
["bola"] = {10, 5},
["club"] = {10, 5},
["composite longbow"] = {110, 10},
["composite shortbow"] = {70, 10},
["dagger"] = {10, 5},
["dart"] = {20, 5},
["halfling sling staff"] = {80, 10},
["hand crossbow"] = {30, 10},
["heavy crossbow"] = {120, 10},
["javelin"] = {30, 5},
["light crossbow"] = {80, 10},
["light hammer"] = {20, 5},
["longbow"] = {100, 10},
["net"] = {10, 1},
["repeating heavy crossbow"] = {120, 10},
["repeating light crossbow"] = {80, 10},
["shortbow"] = {60, 10},
["shortspear"] = {20, 5},
["shuriken"] = {10, 5},
["sling"] = {50, 10},
["spear"] = {20, 5},
["starknife"] = {20, 5},
["throwinig axe"] = {10, 5},
["trident"] = {10, 5},
["brass knife"] = {10, 5},
["kunai"] = {10, 5},
["wooden stake"] = {10, 5},
["spring blade"] = {10, 5},
["stingchuck"] = {10, 5},
["dueling dagger"] = {10, 5},
["switchblade knife"] = {10, 5},
["syringe spear"] = {20, 5},
["ammentum"] = {50, 5},
["chakram"] = {30, 5},
["jolting dart"] = {20, 5},
["hunga munga"] = {15, 5},
["hurlbat"] = {10, 5},
["pilum"] = {20, 5},
["throwing arrow cord"] = {60, 10},
["aklys"] = {20, 5},
["flying talon"] = {10, 5},
["stonebow"] = {50, 10},
["deer horn knife"] = {20, 5},
["dwarven maulaxe"] = {10, 5},
["knobkerrie"] = {20, 5},
["dwarven ram hammer"] = {10, 5},
["chain-hammer"] = {20, 5},
["harpoon"] = {10, 5},
["totem spear"] = {10, 5},
["dwarven sphinx hammer"] = {20, 5},
["brutal bola"] = {10, 5},
["boomerang"] = {30, 5},
["thorn bow"] = {40, 10},
["flask thrower"] = {20, 10},
["grappling hook"] = {10, 5},
["orc hornbow"] = {80, 10},
["stormshaft javalin"] = {30, 5},
["snag net"] = {10, 1},
["throwing shield"] = {20, 5},
["shrillshaft javalin"] = {30, 5},
["double sling"] = {50, 10},
["glove sling"] = {50, 10},
["wrist launcher"] = {20, 10},
["heavy wrist launcher"] = {30, 10},
--Firearms are in this section. I have max touch attack as the max range increment instead of the actual max range increment, which is 5 range increments for early firearms and 10 for modern.
--Early firearms
["breech-loader"] = {20, 1},
["buckler gun"] = {10, 1},
["pepperbox"] = {20, 1},
["pistol"] = {20, 1},
["coat pistol"] = {10, 1},
["dagger pistol"] = {10, 1},
["double-barreled pistol"] = {20, 1},
["dragon pistol"] = {20, 1},
["dragoon pistol"] = {30, 1},
["paddle-foot pistol"] = {20, 1},
["sword cane pistol"] = {10, 1},
["air repeater"] = {50, 1},
["blunderbuss"] = {10, 1},
["culverin"] = {30, 1},
["cylinder rifle"] = {40, 1},
["double hackbut"] = {50, 1},
["fire lance"] = {10, 1},
["musket"] = {40, 1},
["axe musket"] = {30, 1},
["double-barreled musket"] = {40, 1},
["dragoon musket"] = {60, 1},
["warhammer musket"] = {30, 1},
-- Modern firearms are in this section
["revolver"] = {20, 5},
["rifle"] = {80, 5},
["pepperbox rifle"] = {80, 5},
["shotgun"] = {20, 5},
["double-barreled shotgun"] = {20, 5}
In our last session, we had a lot of fights with ranged weapons and party members in-between the opponents, and I noticed that no flanking or point-blank modifiers were applied. I created a test campaign with only CMC enabled, and it looks like no modifiers were generated at all (but no errors appear either).
I have enabled all your debugging and took some screenshots (both: shooting into melee and flanking attack) and the testTokenEdgeSquares debug function finally gives some errors (manager_action_attack_custom.lua:493 : attempt to index local 'tgtToken' (a nil value)) - I guess a ruleset coding change disabled the CMC functionality.
Attachment 52698
Attachment 52699
Attachment 52700
Is the grid visible (eye icon)Quote:
Originally Posted by Arnagus
The dm can unlock the map, go to the grid tab. There it is an eye icon. That icon has to be on, that toggles the grid visibility.
Our group has at least had that problem before.
Interesting, will checkQuote:
Originally Posted by Svandal
Found the eye, and toggled it - still does not work for Flanking, but "rng30" (including "point-blank" and "shooting into melee") works again, MANY thanks!Quote:
Originally Posted by Arnagus
*** edited 2022-05-15 ***
Flanking works as well, but eye must be on before tokens are placed on the map!
Thanks again for the pointer.