FG v 5.1.0 Feature Question (5e Legacy)

[Wormy Joe]

Hi,

This evening I ran a 5e Legacy game with the new updates that added in all the new notification effects. We did a combat encounter and I saw that when there is a saving throw or an attack roll there is a banner at the top of the screen as well as an animation playing between the two tokens and the results of the attack/save. My assumption was that these were tied to the new "On Screen Notifications" option and began testing at what all it revealed. Despite the option for "Show Results to Players" being turned off, the result of attack rolls (being a hit or miss) and saving throws (being a failure or success) was still showing on both the banner overhead and over the tokens. The numerical roll was not revealed, but the actions result was. This did not occur in the chat log which was expected.

I tested this further by turning off my and asking a player to turn their "On Screen Notifications" setting to off, but this only removed the overhead banner and not the animation that plays on a map between tokens. This animation still reveals whether an attack hit or miss, or a save failed or succeeded. This occurs with hidden, non-hidden and player owned actors in the combat tracker. And works both ways (attacking/being attacked etc.).

These new animations feel nice to me and I appreciate the option for players to turn them off individually for those it does not. But at the moment it is revealing hidden information to players with no way to turn it off entirely. If these notifications about results could adhere to the "Show Results to Players" setting that would be great. That way I can use both the overhead banner as well as the token-to-token animations.

Otherwise I am unsure if this is intended or not. Or if there is a way to turn off all the new notifications that I am just missing, which could very well be the case. I would appreciate if this could be clarified.

Thank you

[ddavison]

Thanks for the report. I will pass it along.

[Moon Wizard]

Please run a new Check for Updates; and let us know if you see any other issues. I've updated the overlay FX code for attack/damage/save to respect the show results option.

Regards,
JPG

[Wormy Joe]

The changes seemed to work, and now adheres to the show results option. Thank you!

I did see one other potential problem and that is the animation of the attack (the swish that goes from the attacker to the attacked target) happens regardless of token visibility or if it is revealed on the combat tracker. This is less a concern other than an accidentally sonar on invisible targets even if the attack isn't traceable. And if the chat log is used rather than targeting or dragging, then the result can be dragged to the target without the animation playing. So there is a workaround even if a little awkward.

[Moon Wizard]

Okay, I've disabled all the animations, unless the result is shown to that user. Please run a new Check for Updates.

Regards,
JPG

[Wormy Joe]

Tested with multiple states of token vision and visibility and the animation does not play as described and expected.

But the animation itself is nice though, the main issue is that it still occurs even when the tokens involved are not visible either because it is not revealed in the combat tracker or it's visibility is set as "always invisible" and therefor potentially revealing hidden creatures and their locations. If the best fix is to disable the animation as a whole and tie it to results then I can understand. If wrapping it around line of sight and visibility is more trouble than its worth (or may cause unforeseen consequences at a later date) then I think this is a fine compromise. But I think the ideal scenario would be:

-One or both creatures are not revealed in the combat tracker and/or token visibility set to "always invisible" and creature attacks; no animation plays
-Both creatures are revealed in the combat tracker and/or token visibility set to "always visible" or "mask sensitive" and creature attacks; animation plays

But thank you for working on this and the quick replies.

[Moon Wizard]

I'm not sure if I'm following. The animation should be currently disabled if the target is not visible; or the results are not displayed to the user.
Is that not what you are seeing?

Regards,
JPG

[Wormy Joe]

Oh sorry, yes. When show results is "on" and a token is invisible or if the token is not revealed in the combat tracker then the animation is still playing. I suppose that is not the expected results.
When show results is "off" the animation does not play regardless of visibility.

Regarding my other piece I was more explaining how I think the existence of the animation of the attack is fine even if show results is "off". Just so long as there isn't a notice that shows up centered on the token or overhead on the notice banner that says if it was a hit or miss, which to me seems like the "result" part of the animation. Not the swish swing itself.

And ideally if show results is "off" but both tokens involved (attacker and target) are visible, then the animation could still occur. Just without the center square icon that says "Hit" or "Miss". Sorry if that was confusing.

The animation seems to follow this: 1. swish effect leaves attacker towards target in a line -> 2. result of attack appears in the center of the token as a small square (hit, miss, crit).
If that second part could be disabled when results aren't being shown but the first part remained then I think that's fine. But then the first part shouldn't show when there isn't visibility for one of both actors. If that makes sense?

[Moon Wizard]

Hmm, I'm not seeing that. See the attached video.
https://drive.google.com/file/d/1zhqwPJ1x0CSs7VdqbzbL0Ak-C5lg3ZdQ/view?usp=sharing

I tried allowing the animation between targets to remain; but it wasn't a simple on/off scenario that mirrored results, so something for later.

JPG

[Wormy Joe]

I see. That is strange. What you have shown is what the GM and Player see when results are set to "off" on my end, even though yours is set to "on". The GM sees the animation, but the Player does not.

When I turn show results "on" though to replicate your video, the animation still plays, directed towards a hidden enemy the player cannot see. Both the GM and Player can see this animation and the resulting hit or miss.

I tried pulling any updates to see if maybe I hadn't already, but nothing.

[Moon Wizard]

Are you running "any" extensions?

JPG

[Wormy Joe]

None

[Moon Wizard]

What does your chat window show when you first log in? Can you take a screen clip? (Windows key + Shift + S on Windows machine)

Regards,
JPG

[Wormy Joe]

Here you go. I do see a date of 2026-01-21. I have pulled in updates and have seen the main program update both times you requested earlier.

[Moon Wizard]

Hmm, not sure then. Can you set up your campaign to show the issue, zip up your campaign folder, send it to me, and let me know which two characters are the attacker/defender where you are seeing the issue?

Sorry for all the back and forth, and extra asks; just can't figure out why it would be different in your campaign.

Regards,
JPG

[Wormy Joe]

No worries about the back and forth. I appreciate you taking the time out of your schedule to address my concerns. I'm not sure it warrants a deeper dive into it though and for the most part I'll be having results set to off anyway so this was less for my own use and more offering a better way it could interact with other settings. Which from what you've described it is already supposed to be doing. And having the animations hidden now will prevent hidden actors from revealing themselves accidentally when results are off.

Maybe it may warrant a pin for later but for now there are probably other issues that should be addressed and this one is pretty minor.

Thank you for your help