Multiple issues with 4.8

[Sulimo]

Playing a session today, one of my players had updated so everyone else had to as well as 4.7.5 is not in the Prev channel.

Ruleset: RMC
Extensions: None

https://i.imgur.com/kgiwRFc.png



Arms Law & Spell Reference Manuals are blank
[**]Oddly Character Law and Creatures & Treasures are fine
Skill checks rolled from the character sheet are not adding the skill bonus, just the raw roll
[**]Oddly Skill checks rolled from the Quick bar (even newly created ones) work fine
Combat is not properly applying Parry status for Defense for players, works fine for NPCs
For some reason rolling Attacks from the CT for players (Double-click the attack dice) are not properly applying the Skill bonus for the attack
[**]Works fine with dropping the attack dice from the CT on the target though
[**]NPCs work fine with double-clicking the attack dice from the CT



Example from Arms Law:
https://i.imgur.com/BQCfNjJ.png

[Moon Wizard]

Just pushed a hot fix for the book display issue. Please run a new Check for Updates.

Will reach out to Dakadin on the other items.

Regards,
JPG

[Dakadin]

I will try to review them tomorrow after work since I didn't see the message until late. Sorry about that.

[Sulimo]

Based on my testing just now, I have the following results:


Resolved
This one is also resolved, possibly related to Player Thrown Dice not applying modifiers (https://www.fantasygrounds.com/forums/showthread.php?85588-Player-Thrown-Dice-not-applying-modifiers)
This is also resolved as well
Resolved



I believe issues 2-4 were related to the Modifiers issue mentioned above that is now resolved.

Thanks for looking.

[Moon Wizard]

Thanks for letting us know.

Regards,
JPG

[Sulimo]

No problem.

Although I do see (and did see yesterday) an issue still.

Target an NPC with a Player Session (GM Session works fine), grab the dice and roll them the result on both GM and Player side is 'No Target Selected' even though a target is selected (tried to roll in the tray as well, no difference).

I believe this may be related to the issue Trenloe mentions in this post:

Player Thrown Dice not applying modifiers Post # 6 (https://www.fantasygrounds.com/forums/showthread.php?85588-Player-Thrown-Dice-not-applying-modifiers&p=748919&viewfull=1#post748919)

[Moon Wizard]

I've resolved the issues that I saw with player targeting and modifier box application when rolling outside chat area. Please run a new Check for Updates, and let me know if still seeing any issues.

Regards,
JPG

[Sulimo]

That does seem to have resolved that issue.

[Sulimo]

Not sure if this is an unintended consequence of one of these updates, but player rolls now show white on the GM side of things, even if the player has a different dice color. These were working fine before, but not sure when exactly it changed.

Player rolled Grey (Attack Table: Arms Law), GM saw White.
Hard to tell the color here, but it does look Grey on the Player side.
https://i.imgur.com/KHtkm4T.png


https://i.imgur.com/MH62bI1.jpeg

[deer_buster]

the dice skins issue is the one I reported in discord.

[Sulimo]

@Moon Wizard, just to follow up on the Discord conversation, with 4.8.0 this was working Sunday during our session (Dice skins showed for everyone including GM, dice were rolling across the screen just fine). RMC hasn't been updated since then as far as I am aware, so that is why I was thinking it was an unintended consequence of the hotfixes that got pushed out.

Hopefully that makes sense.

I was unable to do a quick test myself since I cannot run three instances (1GM and 2 Player) on one computer, or at least I keep getting the License error when I try. So, I could not determine if players were seeing only shadow dice on their side (I am sure it was working Sunday though, and could link my Twitch Stream from that day if necessary).

[Dakadin]

I can replicate it in 5E by setting the following options:

Chat: Show GM rolls = Off
Desktop: Show dice tower = On

You can roll the dice sitting on the desktop from a player session and it will show them as white on the GM screen. I passed this on to MoonWizard.

[Sulimo]

Should have tried that myself.



For the second issue I was mentioning, I was trying to see if I could reproduce the other issue that Deer_Buster was seeing.

A player rolls, but the other players see shadow dice instead of the player dice.

However, since I cannot run two independent player sessions on the same computer, I was unable to test out the circumstances.

Here is a discord video showing it (https://discord.com/channels/274582899045695488/692116657858150410/1404975377352364164), oddly, the shadow dice only show up in the tray, so I was thinking that perhaps something was interfering with the 'full screen' rolling (or whatever you want to call it), at least player-to-player, player to GM works fine, and player-to-player was working fine on Sunday during our session, fully updated as of about 3PM PDT Sunday.

[Moon Wizard]

Just pushed a hot fix that I addresses the Show GM Rolls option affecting the player rolls. Can you run a new Check for Updates, and let me know if you still see the issue?

Thanks,
JPG

[Sulimo]

The Dice skins appear to be resolved.

I'm still checking other items to make sure there were no unintended issues that cropped up.

EDIT: No unintended issues that I see. All looks good.