PDA

View Full Version : LOS issue on Homebrew maps since version 4.6.X



Vaall
December 20th, 2024, 16:30
Hello everyone,

Like many of us, I had problems with version 4.6. on my battlemaps and especially with the LOS.
I waited for the various fixes but the error is still present with version 4.6.2.

(For your information, I create my campaigns that I export as a module afterwards to play them with several tables.)

So my issue is when creating my battlemaps, I create the doors and windows with the "Line" tool and not with the "rectangle" tool which is mainly used in official campaigns (maybe it is an error on my part but I find it more practical).

(Subsequently, I will only indicate doors but this is also the case for windows)

Until version 4.5.10, I never had any problems with my doors made with the "line" tool (see image "Battlemap made with 4.5.10").
Since version 4.6.X, the target to open/close a door is positioned in another place on the map (see image "Battlemap made with 4.5.10 used with 4.6.2").
This issues appears only done for doors made with the "Line" tool. Toggletable walls or doors made with the "rectangle" tool do not cause the target to move to open/close the door.

I tried to quickly recreate my map directly with version 4.6.2 and creating doors with the "Line" tool does not cause the target to move to open/close (see "Battlemap made with 4.6.2")

I tried to reload my module containing my battlemaps but that does not change anything either. It is really as soon as you open a map that was made in version <4.5.10 with a FGU version >4.6 whether the battlemap comes from a module or not

I apologize if a solution has already been provided on the forum that I have not seen. But what should I do to be able to use my battlelamps from my campaigns without having to redo either the entire map or without changing my "Line" doors to "rectangle".

I still have the db files from before version 4.6.X and I can share a small module saved in 4.5.10 with the map shown in the example.

Please help me save my campaigns.

Zacchaeus
December 20th, 2024, 17:24
I think you'll need to redraw your doors. There was something said on Discord about certain LoS elements not being drawn correctly (I assumed not by the user but by the client). This issue has been fixed but it does leave the kind of situation that you are seeing, and the only solution is to redraw the doors.

Single line doors are fine (at least they have been for the last few weeks when being able to do that was introduced; before that they needed to be closed polygons).

Vaall
December 20th, 2024, 17:35
No worries, I understand that it is difficult to make a fix for this exceptional case.

Do you think it is possible to tinker in the db file in the <occluders> part either to massively modify my doors in "Line" format to "Rectangle" or to recover my <occluders> from version 4.5.10 and paste them into a db version 4.6 or something like that?

LordEntrails
December 20th, 2024, 17:56
Make backups first. But you can certainly modify the occluders in the xml. You would need to see what a rectangular one looks like and update your line ones accordingly. Might be a bit challenging to get the offsets correct since you will want to give the rectangle some width.

i.e. something like
Line (45.0, 10.0; 55.0,25.0)
to
Rectangle (45.1,10.0; 44.9,10.0; 55.0,24.9; 55.0,25.1)

None of that is formatted correctly and I don't know if you would want to offset the x or y coordinate. Might have to do that based upon a determination of the line being horizontal or vertical. And it would then get more complex if it were at an angle.

Moon Wizard
December 20th, 2024, 19:20
Please provide the zipped up campaign (or module) before you make the changes. I've escalated to Carl to review, in case it's a bigger issue and having a specific example test case is very helpful in narrowing down the issue.

Regards,
JPG

jharp
December 20th, 2024, 19:26
Moon,

I really don't understand how LOS has continued to have issues for as long as it has. For my mods I have a test document that describes what I do and the expected results. Is that true for SW or are you too small a team to do regression testing to that degree. If thats the case can we please get smaller more contained updates.

Thanks,
Jason

Vaall
December 20th, 2024, 20:40
Yes of course I attached a module exported with version 4.5.10 (version that I kept in a corner of my PC) with the battlemap presented in my first post.

I looked in the xlm, unfortunately there is no "line" tag.

Thx for the helping.

jharp
December 20th, 2024, 23:17
I have this for my maps on the forge. The maps work under 4.5.0 but after updating to 4.6.2 they don't allow me to select any doors/traps.

https://forge.fantasygrounds.com/shop/items/888/view

Ignore the slowness / turn off the lighting if you want to test.

Jason

Moon Wizard
December 20th, 2024, 23:44
@jharp,

Thanks for that pointer. I believe I already have a fix from Carl queued up for after holidays for your maps; but I'll double check with Carl to be sure. Carl believed the @Vaall issue to be different though; which is why I asked for campaign.

Regards,
JPG

pindercarl
December 21st, 2024, 01:18
I have this for my maps on the forge. The maps work under 4.5.0 but after updating to 4.6.2 they don't allow me to select any doors/traps.

https://forge.fantasygrounds.com/shop/items/888/view

Ignore the slowness / turn off the lighting if you want to test.

Jason

I noticed LOS is disabled on those maps. Check that LOS is enabled. Doors and other toggleables do not draw with LOS disabled as they have no functionality without LOS. In 4.5.1, the doors would draw regardless of the LOS state.

jharp
December 21st, 2024, 04:50
Ok.

pindercarl
January 1st, 2025, 21:21
Ok.

I wanted to follow up and see if this was still an issue. Thanks.

Vaall
January 8th, 2025, 17:37
On my side, the problem still exists (even after the update of January 7)

Moon Wizard
January 8th, 2025, 23:48
Thanks for confirming. Carl has submitted a potential fix; but waiting for a bit more testing before we release. I'm hoping to release an update very soon; and I'll check back in here to see if the new update fixes once it's available.

Regards,
JPG

Vaall
January 10th, 2025, 17:44
I confirm that version 4.6.3 has corrected this bug and everything works perfectly on my side.

Many thanks

Moon Wizard
January 10th, 2025, 19:27
Thanks for confirming. I was just coming here to let you know.

Regards,
JPG