PDA

View Full Version : Theme bug / user error



packerfanjeff63
November 26th, 2024, 20:33
When your developers are bored, here is a suggestion on something you could fix/enhance to eliminate one more bug (and an hour trying to debug it):

Your user interface currently permits a DM to select all of the themes at the same time. I'm new to FGU, so when I first bought my license a couple months ago, not knowing what I was doing, I checked them all. In hindsight, it was silly, but alas, that's what I did.

When you do that (and I don't know if this first cropped up in 4.6 or not, since I'm just starting my campaign tonight), the combat results in the chat window had bugs in them (not all of the math was done and some results weren't displayed). It wasn't until I realized what I had done and went back to just one Theme that the bugs immediately went away. [I was chasing down presumed broken extensions at first].

So, my suggestion would be to change the UI to only permit the DM to pick one theme at a time. When you choose the next one, the first one you chose would become unchecked.

Not the most important thing for your developers, but something to add to the list.

Jeff

Zacchaeus
November 26th, 2024, 20:42
This would require a lot of reworking since themes are extensions and you can select many extensions. However there's no harm in adding your suggestion to the feature request. Link in my signature.

LordEntrails
November 26th, 2024, 22:46
To expand on Mr Z's answer, FG themes are just extensions. There is currently no difference to the code whether an extension is just modifying the theme assets or changing other parts of the code. A check to tell the difference to a theme vs a non-theme would require an addition to the code, AND would require extension authors to indicate if their extension is a theme. Which would require voluntary compliance.

Not that such can't be done, just that to date it hasn't and it still relies on humans to do the right thing.
You can add the idea to the Feature Request list found here: Fantasy Grounds - Feature Requests (https://www.fantasygrounds.com/featurerequests/featurerequests.php)

packerfanjeff63
November 27th, 2024, 20:05
ok - then never mind - certainly more important things to code.

kyle088
November 27th, 2024, 20:51
It’s easy to get carried away when trying things out for the first time. I think your suggestion to limit theme selection to just one at a time makes sense it’d save a lot of confusion for people new to FGU. Hopefully, the devs can take a look at it.

LordEntrails
November 27th, 2024, 21:12
The OP is not the first to have this issue. It comes up from time to time and it's pretty quick to clear up. But yes, it would be nice to resolve "permanently".

damned
November 27th, 2024, 21:23
Change themes to a new filesystem extension type - eg .thm
They are still coded exactly the same way (just like extensions are coded the same way as rulesets barring the base/extension.xml file name)
But then you could limit the allowed number of .thm files selected

You would have some grey areas - someone creates an extension that just changes the desktop or just the chatwindow - they would probably need to create that as an extension.

Moon Wizard
November 27th, 2024, 21:29
No need, if themes follow the standards we set out for naming. It's really an issue of finding the workflow and space to show in the loading window, when it's already pretty full.

I know that user experience in many places is something that Adam and I are planning to work on together in the new year.

Regards,
JPG

Mike Serfass
November 29th, 2024, 00:29
In Savage Worlds we need to load multiple themes.
Aside from the standard desktop themes, there's also a theme that changes our action cards, and themes that add/set bennies.
There are also companion themes that adjust themes designed for D&D for use in Savage Worlds.
So a single theme limitation wouldn't work for Savage Worlds.