PDA

View Full Version : Temporary Hit Point color in dark themes is not adjusted.



Vass_Dts
September 26th, 2024, 03:20
A picture is worth a thousand words: 62162

So, essentially, Temp HP are not visible in the dark theme.

I know that this is what we use to have a dark theme alter its HP colors for dark palettes:
ColorManager.setStandardDarkUIHealthColors(); And I know because I stole it for my own dark theme. :rv: Now, I could have sworn it used to change the Temp HP color but it's possible I am not remembering correctly. Even so, there ya go.

Moon Wizard
September 26th, 2024, 23:46
Are you sure that you are not overriding some colors somewhere else? This is what I see in the Core - Dark theme, which only uses that function to recolor.

Regards,
JPG

Vass_Dts
September 27th, 2024, 00:01
The screenshot was from core dark but I can’t remember if that particular campaign was extensions-free. I’ll check later tonight when I get home and I’ll let you know. :)

Trenloe
September 27th, 2024, 00:39
These are two different places - Moon Wizard's screenshot is from the Combat Tracker, not 100% sure where the composite image in post #1 is from - maybe a bit more information on that please?

Moon Wizard
September 27th, 2024, 01:09
Good point.

For those fields/templates not on CT, make sure that you remove any hard-coded color tag; and add this code:


function onInit()
setColor(ColorManager.getUIColor("health_shield"));
end


Regards,
JPG

Vass_Dts
September 27th, 2024, 01:20
My original screenshot was from the character sheet and it was using the default core themes (and it was a campaign with no extensions).

So, from the top: This is a screenshot from a campaign with no extensions and using the Core Dark theme displaying both the character sheet and the CT 62166

The colors are okay on the CT, not on Character Sheet. I'm not sure where I'm supposed to place that code in my own themes, but it seems it has to be placed in the core dark theme as well :p

Moon Wizard
September 27th, 2024, 01:46
Yeah, I think many of the character sheet temphp fields have not been updated to use the new health color tagging I registered for exactly this purpose. I'll be doing a full review this weekend of all the rulesets that we directly support, or that I have permission to modify from the developer.

If you see any other rulesets not respecting that after next Tuesday's update, you can ping the developer to have them look at this thread.

Regards,
JPG

Vass_Dts
September 27th, 2024, 01:56
Gotcha, thanks. :)