FG Fix List

[Foen]

Thought I'd start a (short!) thread with suggested fixes for the d20 ruleset, where there is an issue _and_ a solution. Hopefully the devs can add the solutions to the next drop.

Stuart

[Foen]

Prolem

The character selection list doesn't scroll (unless you have a mouse with a wheel button) which can make it difficult when there are large numbers of PCs in the campaign.

Solution

The d20 identityselection and characterlist window classes (utility.xml) incorrectly have a scroller in them, instead of a scrollercontrol. Renaming the windowclass xml elements fixes this problem.

[Foen]

Problem

Intermittently, the combat tracker is empty when it is re-opened, and the entries are lost. This seems to happen randomly.

Solution

The storeToRegistry and restoreFromRegistry functions(scripts/combattracker.lua) use the same registry name (combattracker) as the window position, so the restoration process picks up window save data and not tracker contents data, if it encounters the former first.

Changing the registry entry name (say to combattrackerdata) in the save/restor functions solves this problem.

[Griogre]

Problem
After a module map is drawn on or masked, when FG is exited and restarted the mask and line drawing are not associated with the module map - and thus not "remembered". The mask and drawing graphics are made they are just not saved with the correct path to the module map image. Because the map masks and drawings are saved, the folders holding these images accumulate these "orphaned" files.

Solution
Fix the paths saved in the xml to correctly point to the mask and drawing images.

[Foen]

Problem

The library sorts the books and categories in reverse alphabetical order (Z-A), instead of the more-normal ascending alphabetical order (A-Z).

Solution

The script file for the library window (scripts/library_booklist.lua) uses less-than '<' rather than greater-than '>' operators. Changes these operators on lines 77 and 80 in the onSortCompare function fixes this problem.

[Moon Wizard]

Problem

When submitting planned skill ranks in the skills page of the character sheet, the available ranks are not decremented.

Solution

The code to decrement exists in the file, but there is a reference issue.

Update line 64 of charsheet_skillist.lua:


local unspentnode = window.getDatabaseNode().getChild("skillpoints.unspent");

[Master]

They need to add scroll bars to every one of the windows IMHO. I know they want to keep an original look that separates them from the "windows look" but it is a needed functionality. I hate having to scroll through a text window by dragging a selection. It makes it impossible to read.

[Foen]

When re-opening an Item, the 'At a glance' text is shared even if the 'When identified' checkmark is ticked.

To reproduce this:

1. As GM open an Item and enter some text in the 'At a glance' and 'When identified' boxes.

2. Tick the 'When identified' checkmark.

3. Share the sheet with a player. Note that the 'When identified' text is displayed for the player.

4. Close the Item for All.

5. Open the same item. Note that the 'When identified' tick is still present.

6. Share the sheet with a player. Note that the 'At a glance' text is displayed for the player. This is incorrect.

7. Choose 'Update Shared Sheet', or toggle the checkmark off and on again. The 'When identified' text is now displayed correctly for the player.

To fix this, I think you need to change the onInit() function in the stringfield "identified" for the "item_client" window in adventure_items.xml from:


function onInit()
identifynode = getDatabaseNode().createChild("isidentified", "number");
identifynode.onUpdate = identifyUpdated;
end

to:


function onInit()
identifynode = getDatabaseNode().createChild("isidentified", "number");
identifynode.onUpdate = identifyUpdated;
identifyUpdated();
end


Originally submitted by Spyke.

[Spyke]

With controls built on the default checkbox template you can add a <checked /> tag to indicate that the checkbox should be initialised in the 'on' state. However, this only works if the control is not bound to the database.

Where the checkbox has been set previously, of course, and recorded in the database, it correctly returns the previous state, but on creating a new character sheet, where the node has not yet been created, it is ignoring the <checked /> tag, and always initialising as 'off'.

To fix this, change the following fragment of code from the onInit() function in template_checkbox.lua, from:


-- Get value from source node
if sourcename then
source = window.getDatabaseNode().createChild(sourcename[1], "number");
else
source = window.getDatabaseNode().createChild(getName(), "number");
endto:


-- Get value from source node
if sourcename then
source = window.getDatabaseNode().createChild(sourcename[1], "number");
else
source = window.getDatabaseNode().createChild(getName(), "number");
if checked then
source.setValue(1);
end
end
Spyke

[Foen]

The Call of Cthulhu ruleset incorporates these changes, thanks to everyone who contributed.

Foen

[Bidmaron]

Prolem

The character selection list doesn't scroll (unless you have a mouse with a wheel button) which can make it difficult when there are large numbers of PCs in the campaign.

Solution

The d20 identityselection and characterlist window classes (utility.xml) incorrectly have a scroller in them, instead of a scrollercontrol. Renaming the windowclass xml elements fixes this problem.

This one appears to be fixed in the most recent 2.2 revision.

[Bidmaron]

Problem

The library sorts the books and categories in reverse alphabetical order (Z-A), instead of the more-normal ascending alphabetical order (A-Z).

Solution

The script file for the library window (scripts/library_booklist.lua) uses less-than '<' rather than greater-than '>' operators. Changes these operators on lines 77 and 80 in the onSortCompare function fixes this problem.

This also appears to be fixed in 2.2

[Bidmaron]

When re-opening an Item, the 'At a glance' text is shared even if the 'When identified' checkmark is ticked.

To reproduce this:

1. As GM open an Item and enter some text in the 'At a glance' and 'When identified' boxes.

2. Tick the 'When identified' checkmark.

3. Share the sheet with a player. Note that the 'When identified' text is displayed for the player.

4. Close the Item for All.

5. Open the same item. Note that the 'When identified' tick is still present.

6. Share the sheet with a player. Note that the 'At a glance' text is displayed for the player. This is incorrect.

7. Choose 'Update Shared Sheet', or toggle the checkmark off and on again. The 'When identified' text is now displayed correctly for the player.

Originally submitted by Spyke.

This is also reported fixed in 2.2

[Foen]

Great, this thread has some use then!

*grin*

[Rashek]

Drawing a map has the "Drawn" portion appear on top of the Mask, is there a way to fix this (as a side note, a drawn only map does not even have a mask feature, we use back ground jpg's and draw the dungeon on top of the background)