PDA

View Full Version : Feats in the featlist has lost their names



Starwolf
May 2nd, 2024, 19:24
As I was working to prepare my campaign, i suddenly noticed that all the names to the feats in my feat list was gone. However, when I clicked and opened a feat the name was displayed in the feat description. Se attached pictures. It wasn't like this before, so something must have happened to the way feats are listed. And it must have happened pretty recently since last couple of updates or so.
60723 60724

Any idea what might have happened here and how I might fix this?

Moon Wizard
May 3rd, 2024, 16:29
I'm not seeing that on my side. I'm using modules that I made back around 2010, so they definitely haven't changed.

Regards,
JPG

LordEntrails
May 3rd, 2024, 20:58
Are you using any extensions?

Starwolf
May 3rd, 2024, 21:10
Are you using any extensions?

Yes, but no new extensions has been added the last year or so. I have used these datasets for a long time without any hitch. May it have been the updates to how FGU have a unified framework for windows across the different rules sets?

Moon Wizard
May 3rd, 2024, 22:24
I did a SVN source control log review of the file, and the field names for have not changed since they were originally added to the source control in 2017.

Mine are still showing up, so doesn't appear to be a general thing. The field name for that part of the data should be "name" with a type of "string".

Regards,
JPG

Starwolf
May 3rd, 2024, 22:41
I did a SVN source control log review of the file, and the field names for have not changed since they were originally added to the source control in 2017.

Mine are still showing up, so doesn't appear to be a general thing. The field name for that part of the data should be "name" with a type of "string".

Regards,
JPG

I havent done any changes to the data files..

Here is the content of the [Content_Types].xml

<?xml version="1.0" encoding="utf-8"?><Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"><Default Extension="xml" ContentType="" /><Default Extension="png" ContentType="" /></Types>

This is the content of the definition.xml

<?xml version="1.0" encoding="iso-8859-1"?>
<root version="2.2">
<name>Feats</name>
<author></author>
<ruleset>4E</ruleset>
</root>

And here is the header and the first feat of the db.xml file.

<?xml version="1.0" encoding="iso-8859-1"?>
<root version="2.2">

<reference static="true">
<feats>
<ArcaneAegisMulticlassSwordmage12171>
<name type="string">Arcane Aegis [Multiclass Swordmage]</name>
<source type="string">Other Feat</source>
<prerequisite type="string">Any multiclass swordmage feat, paragon multiclassing as a swordmage</prerequisite>
<shortdescription type="string">Choose a Swordmage Aegis power. You can use that power once per encounter.</shortdescription>
<description type="formattedtext"><table><tr><td><b>Benefit:</b> Choose a Swordmage Aegis power. You can use that power once per encounter.</td></tr></table><p>Published in Arcane Power, page(s) 135.</p></description>
<locked type="number">1</locked>
</ArcaneAegisMulticlassSwordmage12171>

The funny thing is that when I open the feats list with the button in the menu bar to the right I get a list of feats with their names.

60733

Edit: I created a new empty 4E campaign with no extensions and only activated the Feats module. The problem are still there.

Moon Wizard
May 3rd, 2024, 23:52
Do you have any unpacked versions of the 4E ruleset (i.e. subfolders) in your rulesets subfolder under the FG data folder? (accessible via button in upper left of FG launch screen)

Try doing a search for reference.feats.ArcaneAegisMulticlassSwordmage1217 1 to see if there are other references in the module. The place you are looking is where the main records are located when you click on the Feats sidebar button.

The "Feats" list link you are clicking on is a manually made list that the old parsers used to pull. If "name" is missing/empty in that list, it attempts to pull from target record name.

Regards,
JPG

Starwolf
May 4th, 2024, 01:22
I could not find any unpacked versions of the 4e ruleset. The ruleset I got was dated 16th of april this year i think it was.
I took a new look through the feats dataset and noticed one thing. In the description type Feats has a upper case F, while the all other mentions of feats are in all lower case. Could this be the reason? Attached just a little snippet of the file below.



<lists static="true">
<feats>
<description type="string">Feats</description>
<groups>
<feat2featsCategoryParagon>
<description type="string">Paragon (606)</description>
<powers>
<WhirlingIronDefense33681>
<link type="windowreference">
<class>powerdesc</class>
<recordname>reference.feats.WhirlingIronDefense33681@Feats</recordname>
</link>
</WhirlingIronDefense33681>
</powers>
</feat2featsCategoryParagon>
</groups>
</feats>
</lists>
<library>
<libraryModule>
<name type="string">Feats</name>
<categoryname type="string">Character Features</categoryname>
<entries>
<feats>
<librarylink type="windowreference">
<class>reference_classfeatlist</class>
<recordname>lists.feats@Feats</recordname>
</librarylink>
<name type="string">Feats (3271)</name>
</feats>
</entries>
</libraryModule>
</library>

Moon Wizard
May 4th, 2024, 03:28
Mine looks roughly the same. The name in the library section only refers to the text shown for the book in the Modules window, which is only for display and has nothing to do with lookup.

I may need to get you to PM me a copy of the module to test out via DropBox/OneDrive/GoogleDrive link.

Regards,
JPG

LordEntrails
May 4th, 2024, 06:19
Yes it is (95% sure) the extensions. The recent updates have changes the way may windows are defined. If the extensions have not been updated, then they can very well be broken. Not sure why they would not show a value, but that would be my first step to trouble shoot. Turn off all extensions and see if the feat names how up. If so, then re-enable them until you find out which one it is.

Moon might prove me wrong, but start there :)

Starwolf
May 4th, 2024, 06:35
Mine looks roughly the same. The name in the library section only refers to the text shown for the book in the Modules window, which is only for display and has nothing to do with lookup.

I may need to get you to PM me a copy of the module to test out via DropBox/OneDrive/GoogleDrive link.

Regards,
JPG


Done!

Starwolf
May 4th, 2024, 06:37
Yes it is (95% sure) the extensions. The recent updates have changes the way may windows are defined. If the extensions have not been updated, then they can very well be broken. Not sure why they would not show a value, but that would be my first step to trouble shoot. Turn off all extensions and see if the feat names how up. If so, then re-enable them until you find out which one it is.

Moon might prove me wrong, but start there :)

I don't think there are any of the extensions as I started a new campaign with no extensions running and the problem was still there.

skelekon
May 4th, 2024, 06:51
I noticed this problem after one of the recent updates with modules that are created using my Portable Compendium converter.

Based on what I can remember, and from checking the changes I made to fix it, the entries in the reference_classfeatlist window were originally using a <source></source> tag to define the name that appears in the first column.

I changed them all to <name></name> tags and that fixed the issue.


Edit to clarify the timing: going through my backups it looks like this occurred during an update in or around Sep 2023, and not during the March 2024 updates.

skelekon
May 4th, 2024, 08:01
I could not find any unpacked versions of the 4e ruleset. The ruleset I got was dated 16th of april this year i think it was.
I took a new look through the feats dataset and noticed one thing. In the description type Feats has a upper case F, while the all other mentions of feats are in all lower case. Could this be the reason? Attached just a little snippet of the file below.



<lists static="true">
<feats>
<description type="string">Feats</description>
<groups>
<feat2featsCategoryParagon>
<description type="string">Paragon (606)</description>
<powers>
<WhirlingIronDefense33681>
<link type="windowreference">
<class>powerdesc</class>
<recordname>reference.feats.WhirlingIronDefense33681@Feats</recordname>
</link>
</WhirlingIronDefense33681>
</powers>
</feat2featsCategoryParagon>
</groups>
</feats>
</lists>
<library>
<libraryModule>
<name type="string">Feats</name>
<categoryname type="string">Character Features</categoryname>
<entries>
<feats>
<librarylink type="windowreference">
<class>reference_classfeatlist</class>
<recordname>lists.feats@Feats</recordname>
</librarylink>
<name type="string">Feats (3271)</name>
</feats>
</entries>
</libraryModule>
</library>


Doing some more digging, I think the issue is that the individual feat entries within the <lists> tag now require a <name> tag to be displayed in the first column.

It seems that prior to Sep 2023-ish the entries within the reference_classfeatlist would grab the name entry from the linked record within the <reference><feats> tag, the same way it grabs the Prerequisites & Benefits.


If you add this tag immediately before the </WhirlingIronDefense33681> it should work according to my observations.

<name type="string">Whirling Iron Defense</name>


One of the devs can probably clarify - this is just my observation from creating modules of 4E rules elements.

Starwolf
May 4th, 2024, 14:45
One of the devs can probably clarify - this is just my observation from creating modules of 4E rules elements.

Makes kinda sense. I have had these modules since I scraped them from the original character builder site years ago. It might have been as far back as 2016 or something. I still got those files. I dont remember which software I used to get the data files downloaded with and generating the modules for Fantasygrounds. But it was a couple of years before FGU was announced at least.

Maybe I should try to make new module files as it seems a difficult task to insert the necessary code unless it is a search and replace. Last time I really ran fantasygrounds for character generation or any real games was almost 2 years ago.

kevininrussia
May 4th, 2024, 18:36
I was able to reproduce the issue. No Extensions. Need to go through Modules then to Feat.

https://i.imgur.com/ozvDN03.png

Moon Wizard
May 4th, 2024, 22:30
Thanks for the file, I was able to recreate the scenario. I'm planning to post a fix next week.

Regards,
JPG

Starwolf
May 5th, 2024, 03:28
Thanks for the file, I was able to recreate the scenario. I'm planning to post a fix next week.

Regards,
JPG

Thanks, that will be much appreciated.

Starwolf
May 5th, 2024, 04:48
I was able to reproduce the issue. No Extensions. Need to go through Modules then to Feat.

https://i.imgur.com/ozvDN03.png

How did you get the different module elements organized like that? The parser I used back them organized the stuff like the attached picture shows.

60741

I would love to get a better organization of the different elements

Trenloe
May 5th, 2024, 22:39
How did you get the different module elements organized like that? The parser I used back them organized the stuff like the attached picture shows.

60741

I would love to get a better organization of the different elements
Those are all individual modules. You'll need to combine them into a single db.xml file (or client.xml for a player facing module) within one module.

Moon Wizard
May 7th, 2024, 17:32
Just pushed an update to the rulesets that should fix this. Please run a new Check for Updates and try again.

Regards,
JPG

zereissen
May 7th, 2024, 17:37
I can see the names now. Thank you!

Starwolf
May 7th, 2024, 20:15
Thanks, it is back to normal. Much appreciated.