Log in

View Full Version : How is this still happening where remembered map corrupts location?



SilentRuin
April 3rd, 2024, 20:09
I reported this in TEST and gave example campaign and yet this is still happening in my other campaigns where if I have a fitted map up and exit the app with option to remember where the windows were it always comes back in some half assed lost location. Even the shortcut which during the session remembers the fitted map and displays it correctly turning the map off and on gets corrupted by this featured.

Example - imagine this map had map fit to fill and is fully in the window. Now imagine and exiting app and coming back up and in every campaign having your map not show up correctly where you left it. I admit I've not tried turning off the map window before exiting to see if it might not get the location corrupted but really that's not the point.

I can't believe I'm the only one seeing this - yet I hear nobody else complaining. I can't believe its not easily duplicatable - yet having reported it since TEST - there it still is. Do you guys store the full window map location data correctly? Do you do it when things are shutting down before its shut down or only in very special situation (not fitting) that I'm somehow not using?

Gist is this is frustrating given how long this has persisted.

60442

SilentRuin
April 3rd, 2024, 20:18
Just for fun I tried to use the navigation left/right/up/down to fit the window then exited - and it gave me even a different result. Something is seriously not right.

60443

SilentRuin
April 3rd, 2024, 20:22
And just to be absolutely clear I made of copy of the campaign - turned off all extensions - and the same corrupted map location on exiting and reentering the app still occurs.

Zacchaeus
April 3rd, 2024, 21:35
I can't replicate this in a new campaign without any extensions. I assume that you open a map and centre it in the image window; exit FG completely then re-open the same campaign. Doing this the map opens exactly where I left it. Can you replicate in a new campaign without extensions - I don't mean just switching off extensions in an existing campaign since those could still corrupt the db.xml file - but a new fresh campaign.

SilentRuin
April 3rd, 2024, 21:38
I can't replicate this in a new campaign without any extensions. I assume that you open a map and centre it in the image window; exit FG completely then re-open the same campaign. Doing this the map opens exactly where I left it. Can you replicate in a new campaign without extensions - I don't mean just switching off extensions in an existing campaign since those could still corrupt the db.xml file - but a new fresh campaign.

Give me a sec I'll create a new campaign with that exact module "Rhime of the FrostMaiden" goblin fort and see what happens.

SilentRuin
April 3rd, 2024, 21:46
Same thing. Garbage location. Here is campaign - I created new 5E with LAN and demo for password. When it came up I picked one module "Rhime of the Frostmaiden" not the player one. I think picked the ko... whatever the name of that map is in pictures above. I did a fit to fill - brought up empty CT just so same windows were up. Closed app. Came up - POOF - utter crap location exactly as I showed in first post. You can either duplicate this yourself or try the campaign I just created from scratch.

Either way I can't see how I'm only one getting this in my campaigns. LOS data? Who knows. This one is FGU bought map so its amazing nobody else is seeing this.

Ecks
April 3rd, 2024, 23:07
I can recreate, pretty much the same steps. Just create a new 5E campaign, enable "Restore Windows on Start", load 5E RotF, and then open an image from RotF. Then reload the campaign. The image window is restored in the correct place but the top of the image is centered in the window. Opening "Adventure Flowchart" is a good example, first opening of it shows the entire image, but after reload its shifted down halfway. It doesn't seem to happen with all images.

Edit: It seems to remember the location if I pan the image around first using mouse middle click, but if I don't move the image or if I press "Zoom to Fit" then after reload the image position is restored with the top of the map in the middle of the image window. Moving the image with the navigation buttons also doesn't seem to be remembered after reload.

SilentRuin
April 5th, 2024, 21:31
I can recreate, pretty much the same steps. Just create a new 5E campaign, enable "Restore Windows on Start", load 5E RotF, and then open an image from RotF. Then reload the campaign. The image window is restored in the correct place but the top of the image is centered in the window. Opening "Adventure Flowchart" is a good example, first opening of it shows the entire image, but after reload its shifted down halfway. It doesn't seem to happen with all images.

Edit: It seems to remember the location if I pan the image around first using mouse middle click, but if I don't move the image or if I press "Zoom to Fit" then after reload the image position is restored with the top of the map in the middle of the image window. Moving the image with the navigation buttons also doesn't seem to be remembered after reload.

Thanks for the workaround! Pan with middle mouse button does appear to be about the only way for it to remember where the map is.

As I'm still waiting (6 months?) for fix to the Image.addLayerPaintStamp not sizing assets correctly on the map when first placed - I was not holding out much hope of this being fixed anytime in the near future when I need it now for my games. This helps solve that (as long as I remember to middle mouse drag map before exiting map I suppose).

Thanks.

pindercarl
April 5th, 2024, 23:49
Thanks for the workaround! Pan with middle mouse button does appear to be about the only way for it to remember where the map is.

As I'm still waiting (6 months?) for fix to the Image.addLayerPaintStamp not sizing assets correctly on the map when first placed - I was not holding out much hope of this being fixed anytime in the near future when I need it now for my games. This helps solve that (as long as I remember to middle mouse drag map before exiting map I suppose).

Thanks.

Does this "Image.addLayerPaintStamp not sizing assets correctly on the map when first placed" refer to webm stamps? Or, are you seeing this with all paint stamps?

SilentRuin
April 6th, 2024, 04:42
Does this "Image.addLayerPaintStamp not sizing assets correctly on the map when first placed" refer to webm stamps? Or, are you seeing this with all paint stamps?

webm - was told "it was on the list" and a bunch of other things till I just gave up asking for it to be fixed as a lost cause.

https://www.fantasygrounds.com/forums/showthread.php?78466-Image-addLayerPaintStamp-not-respecting-w-and-h-grid-unit-scaling

Actually was waiting longer than 6 months... since last July. If I'm to be perfectly accurate on when it was discussed as "on the list to be fixed" then a later comment about it being "impacting only API" so why bother.

Honestly, I gave up on it - why i mentioned it as example here on not holding my breath on fixes on this or the TEST issue I mentioned in here about fitting maps and app corrupting location when it gets put back out there with save window option. It's like giving examples and throwing things into a post is the same as sending it into a file shredder.

pindercarl
April 6th, 2024, 13:20
webm - was told "it was on the list" and a bunch of other things till I just gave up asking for it to be fixed as a lost cause.

https://www.fantasygrounds.com/forums/showthread.php?78466-Image-addLayerPaintStamp-not-respecting-w-and-h-grid-unit-scaling

Actually was waiting longer than 6 months... since last July. If I'm to be perfectly accurate on when it was discussed as "on the list to be fixed" then a later comment about it being "impacting only API" so why bother.

Honestly, I gave up on it - why i mentioned it as example here on not holding my breath on fixes on this or the TEST issue I mentioned in here about fitting maps and app corrupting location when it gets put back out there with save window option. It's like giving examples and throwing things into a post is the same as sending it into a file shredder.

Thanks for confirming. That bug is part of what I am currently working on. It had not made it to the top of the list as we've only had one user report it as an issue.

SilentRuin
April 6th, 2024, 17:22
Thanks for confirming. That bug is part of what I am currently working on. It had not made it to the top of the list as we've only had one user report it as an issue.

Just for clarification, is that the API webm scaling bug or the one this thread is about - the maps never coming back up at the right location unless pan middle mouse was last operation used to set them?

Vass_Dts
April 6th, 2024, 17:48
We’ll, for what is worth, I’ll say that all of us who use B9’s and Ruin’s extensions for webm spell effects are not reporting it because we assumed you were aware of it. :)

Vass_Dts
April 6th, 2024, 19:47
BTW, Ruin, what I have consistently noticed working, is calling the webm a second time in a row. Maybe a workaround could be to have the extension place the asset, remove it, and place it again?

Moon Wizard
April 6th, 2024, 21:52
I identified and have a patch queued for the original report.

Regards,
JPG

SilentRuin
April 7th, 2024, 05:31
BTW, Ruin, what I have consistently noticed working, is calling the webm a second time in a row. Maybe a workaround could be to have the extension place the asset, remove it, and place it again?

Tried it - never worked that way. Though my extension will wipe the NPC/asset/effect whenever it is clicked again and not change the CT time left on effect. So that is what I've done since last July. Like if I have fog cloud self effect and its tiny - just click it again. Though I also try to go into assets search for "webm" then page through every asset so it runs at least once before I start a game. That "mostly" works (for host might have to have them all logged in when I do it for clients - not sure as its "mostly").

Moon Wizard
April 9th, 2024, 19:13
A fix for the saved position for this case has been pushed with v4.5.5 today.

Regards,
JPG

SilentRuin
April 9th, 2024, 20:59
A fix for the saved position for this case has been pushed with v4.5.5 today.

Regards,
JPG

Did the same fit to fill right mouse over the map then exited app and came back up in map with same results.

60508

Moon Wizard
April 9th, 2024, 23:14
I fixed the issue with the exact issue identified in the very concise steps provided by @Ecks.
https://www.fantasygrounds.com/forums/showthread.php?81043-How-is-this-still-happening-where-remembered-map-corrupts-location&p=713442&viewfull=1#post713442

If there is a specific case that still doesn't work, I still need concise, specific steps and the same data to recreate. Simple 1/2/3/4 types of concise steps work the best with no editorial.

Regards,
JPG

Moon Wizard
April 9th, 2024, 23:14
I fixed the issue with the exact issue identified in the very concise steps provided by @Ecks.
https://www.fantasygrounds.com/forums/showthread.php?81043-How-is-this-still-happening-where-remembered-map-corrupts-location&p=713442&viewfull=1#post713442

If there is a specific case that still doesn't work, I still need concise, specific steps and the same data to recreate. Simple 1/2/3/4 types of concise steps work the best with no editorial.

For example, I have no idea what exact steps you followed when opening that map, nor even what module that map comes from or whether it's a custom map.

Regards,
JPG

Moon Wizard
April 9th, 2024, 23:23
I just searched online, figured out that map was in RotF, loaded that module, opened that map, sized up once, used zoom to fit, and reloaded. This is what I got.

JPG

SilentRuin
April 10th, 2024, 03:44
I fixed the issue with the exact issue identified in the very concise steps provided by @Ecks.
https://www.fantasygrounds.com/forums/showthread.php?81043-How-is-this-still-happening-where-remembered-map-corrupts-location&p=713442&viewfull=1#post713442

If there is a specific case that still doesn't work, I still need concise, specific steps and the same data to recreate. Simple 1/2/3/4 types of concise steps work the best with no editorial.

For example, I have no idea what exact steps you followed when opening that map, nor even what module that map comes from or whether it's a custom map.

Regards,
JPG

So you ignore my example and description and hand made example campaign and ask me do it all again?

No thanks.

If you can't be bothered to use what I gave to you originally then I'll just live with the bug. The post you evidently utterly ignored...

https://www.fantasygrounds.com/forums/showthread.php?81043-How-is-this-still-happening-where-remembered-map-corrupts-location&p=713437&viewfull=1#post713437

Moon Wizard
April 10th, 2024, 04:35
I just brought up that campaign, clicked Zoom to Fit, then /reload. It's restoring just fine after that.
If you were expecting the previous campaign you posted to work, the window image view state was not saved correctly before; so you have to redo Zoom to Fit, then reload.

Regards,
JPG

SilentRuin
April 10th, 2024, 04:53
I downloaded that zip and tested it before i gave it to you again.

Im not an idiot of course i did zoom to fill before i exited.

Note carefully, at no time have i used the words zoom to fit in that example.

Fill is not Fit.

If you come back and tell me zoom to fill after coming up in app - exiting - and coming back up does not show the location off then i have no explanation why it consistenly does it for me in this example and other campaigns.

Moon Wizard
April 10th, 2024, 05:50
In the scenario I tested; I used the button on the image toolbar with the tooltip "Zoom to Fit", which is the same thing as "Zoom Extents" in the image data panel. The only place I can find a Zoom to Fill option is in the radial menu, which I never use; and most people don't use. I didn't see anywhere mentioned in your notes that you mentioned right click to use Zoom to Fill.

I just tried downloading the campaign fresh, opening the campaign, right clicking and selecting Zoom to Fill, and then reloading. It came up fine.

Maybe try deleting the windowstate.xml in that directory in case it's not updating for some reason?

Regards,
JPG

Trenloe
April 10th, 2024, 06:18
Note carefully, at no time have i used the words zoom to fit in that example.
I think maybe the mis-communication is that you twice used "fit to fill" which I don't think is an option in standard FG.

I'd recommend confirming exactly which process you're using, for example: if you're using the "Zoom to fill" (as mentioned by Moon Wizard this is via the right-click "View" menu in the image) or "Zoom to fit" (via the toolbar button or the image right-click "View" menu - please confirm which you're using) or the image edit "Zoom Extents" button or if you're following some other method to "fit to fill" the image. Hopefully this will allow you and Moon Wizard to get on the exact same page which I think is vital in troubleshooting your issue.

SilentRuin
April 10th, 2024, 14:32
In the example i did use fit to fill as that was what i thought it was doing so i guess that was to confusing a term.

Ill just use pan workaround as that does store the data and let others report FGU bugs as Im just to exhausted trying to figure out and deconstruct/fix all the stuff breaking extensions and general stuff like this and API problems that Ive had to report and rereport some of which im still waiting on a year later.

I suppose I'm no longer able to report things with equanimity as Im getting to irked by it all.

Ill cease and desist my reporting bugs and take a break.