Conversion Checker Issues

[LordEntrails]

So I've been having issues with Conversion Checker extension and I'm confused and frustrated.

Yesterday I spent a whole bunch of time resolving all the issues CC was giving me. I would fix all the listed ones, run it again and get new issues. Fix those, run it again, rinse & repeat. Ok, so that was annoying but fine and I eventually got it where CC would indicate nothing needed to be fixed (except the 3 external links to the DMG I intended to have). Then I shut down FG, went and did life things, then came back and out of curiosity I ran CC again since it was still loaded when I started up the campaign. And guess what? It showed 40+ new issues.

Also of note it was giving bad/missing links and when opening the record it had no such link visible. I had to remove the link in the xml itself.

Is this expected? It's quite annoying.

Here's the latest results;



Start Module Check: Current Campaign



This module links to the following modules: DD Dungeon Masters Guide, DD MM Monster Manual






Record: Link Target Missing - reference.npcdata.bandit@DD MM Monster Manual,
battle.id-00031.npclist.id-00001.link,


Record: Link Target Missing - reference.npcdata.zombie@DD MM Monster Manual,
battle.id-00067.npclist.id-00001.link,


Record: Link Target Missing - reference.npcdata.shrieker@DD MM Monster Manual,
battle.id-00140.npclist.id-00004.link,


Record: Link Target Missing - reference.npcdata.violetfungus@DD MM Monster Manual,
battle.id-00209.npclist.id-00002.link,


Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,
battlerandom.id-00003.npclist.id-00001.link,


Record: Link Target Missing - reference.npcdata.stirge@DD MM Monster Manual,
battlerandom.id-00005.npclist.id-00001.link,


Record: Link Target Missing - reference.npcdata.goblin@DD MM Monster Manual,
combattracker.list.id-00001.sourcelink,


Record: Link Target Missing - image.img_goblin_jpg@DD MM Monster Manual,
combattracker.list.id-00001.text,


Record: Link Target Missing - reference.refmanualdata.refpage_diseases@DD Dungeon Masters Guide,
encounter.id-00178.text,


Record: Link Target Missing - reference.refmanualdata.refpage_downtimeactivities @DD Dungeon Masters Guide,
encounter.id-00562.text,


Record: Link Target Missing - reference.spelldata.protectionfromevilandgood@*,
item.id-00096.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.zoneoftruth@*,
item.id-00097.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.speakwithplants@*,
item.id-00098.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.compulsion@*,
item.id-00099.description,


Record: Link Target Missing - reference.spelldata.spiderclimb@*,
item.id-00107.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.conjureelemental@*,
item.id-00186.description,


Record: Link Target Missing - reference.spelldata.masshealingword@*,
item.id-00205.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.fireball@*,
item.id-00209.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.arcanelock@*,
item.id-00210.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.jump@*,
item.id-00257.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.darkvision@*,
item.id-00259.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.knock@*,
item.id-00260.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.commune@*,
item.id-00282.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.curewounds@*,
item.id-00283.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.removecurse@*,
item.id-00284.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.dispelmagic@*,
item.id-00285.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.revivify@*,
item.id-00286.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.prayerofhealing@*,
item.id-00287.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.banishment@*,
itemtemplate.id-00001.description,


Record: Link Target Missing - reference.imagedata.img_spell_scroll_jpg@*,
itemtemplate.id-00001.description,


Record: Link Target Missing - image.img_blackpudding_jpg@DD MM Monster Manual,
npc.id-00328.text,


Record: Link Target Missing - reference.npcdata.firesnake@DD MM Monster Manual,
tables.id-00002.tablerows.id-00006.results.id-00001.resultlink,


Record: Link Target Missing - reference.spelldata.polymorph@*,
treasureparcels.id-00033.itemlist.id-00001.description,


Record: Link Target Missing - reference.npcdata.mastiff@*,
treasureparcels.id-00099.itemlist.id-00007.description,


Record: Link Target Missing - reference.spelldata.poisonspray@*,
treasureparcels.id-00129.itemlist.id-00005.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.colorspray@*,
treasureparcels.id-00129.itemlist.id-00006.spells.id-00001.link,


Record: Link Target Missing - reference.spelldata.disguiseself@*,
treasureparcels.id-00129.itemlist.id-00007.description,


Record: Link Target Missing - reference.npcdata.awakenedshrub@*,
treasureparcels.id-00140.itemlist.id-00001.description,


Record: Link Target Missing - reference.spelldata.dominatebeast@*,
treasureparcels.id-00166.itemlist.id-00001.description,


Finish Module Check.

[LordEntrails]

Oh, and many of these ~40 items are ones I have a record of fixing before...

[Zacchaeus]

Are you running the latest version? It was updated (well actually re-written) a few weeks ago. Make sure you don't have an old copy in your extension folder.

[LordEntrails]

Yea, it was updated after that fix. I think I updated last week as well...
File shows as last being updated on my machine 2/9/2024
edit: after an update that is still the current version.

[Zacchaeus]

The errors you are getting are genuine ones I think. They are showing that the spells are anonymous links which aren't used any more. I've been updating a lot of modules recently - converting them to campaign based creation rather than par5e and I do have to relink spells and some items in tables. However normally I get all the errors at once rather than piecemeal. I have seen this piecemeal thing though sometimes. It seems to stop reporting for whatever reason before it has looked at the whole database.

[LordEntrails]

ok, thanks. Yea, I was getting the peicemeal thing withing a single session of FG, but since I had run it and was no longer getting anymore I was cranky when I started up FG the next time and had new errors :)

[LordEntrails]

Mr Z, you didn't find a quick way to replace the anonymous links in the xml did you? It looks like the in module links do not use the name, but rather the NPC is node, so I don't see a good way to update the xml directly.

[Zacchaeus]

Mr Z, you didn't find a quick way to replace the anonymous links in the xml did you? It looks like the in module links do not use the name, but rather the NPC is node, so I don't see a good way to update the xml directly.
Not really. The problem is that you don’t know exactly where the links should point. If you know where they should point you could replace the @* with @modulename.

[LordEntrails]

I want them to point to the campaign itself. But thanks. I did notice that if I have the modules loaded, the CC does not list them as an error. But if I unload everything, then they show up. So that's part of where my confusion with the list of issues changing was coming from.

[superteddy57]

Toss up your campaign XML and I can look it over to give more directed suggestions

[Zacchaeus]

I want them to point to the campaign itself. But thanks. I did notice that if I have the modules loaded, the CC does not list them as an error. But if I unload everything, then they show up. So that's part of where my confusion with the list of issues changing was coming from.

Just removing the @* should do that I think.

[LordEntrails]

Thanks. Once you download it, would you mind editing my post and deleting it?

[LordEntrails]

I'm still seeing inconsistent behavior. (note, this is in 4.4.9)

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)


Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,
battlerandom.id-00003.npclist.id-00001.link,


xml:

<id-00003>
<cr type="string">3</cr>
<exp type="number">600</exp>
<name type="string">Goblin War Party</name>
<npclist>
<id-00001>
<count type="number">2</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00031</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
</maplink>
<name type="string">Goblin Warrior</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00001>
<id-00007>
<count type="number">1</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00030</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
</maplink>
<name type="string">Goblin Sargent</name>
<token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
</id-00007>
<id-00008>
<count type="number">4</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00184</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
<id-00003>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00003>
<id-00004>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00004>
</maplink>
<name type="string">Goblin</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00008>
</npclist>
</id-00003>
I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

edit: I found a similar error with an item template. The error was indicating as being related to a regular item (mace of disruption), but actually was in an item template called scroll of banishment (no idea why it had a item template, I deleted the template to resolve the issue.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

edit: Finally, whenI export to a module and open the module in a different campaign and run CC on it, I get errors again, mostly (?) the same, but this time some of the anonymous links that worked in the campaign does not work in the module (while some do work).

[Jiminimonka]

I'm still seeing inconsistent behavior.

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)


Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,
battlerandom.id-00003.npclist.id-00001.link,


xml:

<id-00003>
<cr type="string">3</cr>
<exp type="number">600</exp>
<name type="string">Goblin War Party</name>
<npclist>
<id-00001>
<count type="number">2</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00031</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
</maplink>
<name type="string">Goblin Warrior</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00001>
<id-00007>
<count type="number">1</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00030</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
</maplink>
<name type="string">Goblin Sargent</name>
<token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
</id-00007>
<id-00008>
<count type="number">4</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00184</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
<id-00003>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00003>
<id-00004>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00004>
</maplink>
<name type="string">Goblin</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00008>
</npclist>
</id-00003>
I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

It's always doing this, helpful for finding some mistakes but inconsistent is being lenient.

[superteddy57]

I'm still seeing inconsistent behavior. (note, this is in 4.4.9)

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)


Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,
battlerandom.id-00003.npclist.id-00001.link,


xml:

<id-00003>
<cr type="string">3</cr>
<exp type="number">600</exp>
<name type="string">Goblin War Party</name>
<npclist>
<id-00001>
<count type="number">2</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00031</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
</maplink>
<name type="string">Goblin Warrior</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00001>
<id-00007>
<count type="number">1</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00030</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
</maplink>
<name type="string">Goblin Sargent</name>
<token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
</id-00007>
<id-00008>
<count type="number">4</count>
<isidentified type="number">1</isidentified>
<link type="windowreference">
<class>npc</class>
<recordname>npc.id-00184</recordname>
</link>
<maplink>
<id-00001>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00001>
<id-00002>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00002>
<id-00003>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00003>
<id-00004>
<imageref type="windowreference">
<class />
<recordname />
</imageref>
<imagex type="number">0</imagex>
<imagey type="number">0</imagey>
</id-00004>
</maplink>
<name type="string">Goblin</name>
<token type="token">tokens/goblin.png@DD MM Monster Manual</token>
</id-00008>
</npclist>
</id-00003>
I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

edit: I found a similar error with an item template. The error was indicating as being related to a regular item (mace of disruption), but actually was in an item template called scroll of banishment (no idea why it had a item template, I deleted the template to resolve the issue.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

edit: Finally, whenI export to a module and open the module in a different campaign and run CC on it, I get errors again, mostly (?) the same, but this time some of the anonymous links that worked in the campaign does not work in the module (while some do work).

Can you zip up that campaign and send me a pm with a link to download? I need something to test against to check on this.

[superteddy57]

I've gone through with Moon and a further expansion of the tool should sort a few things we are seeing. Wildcard links will be separated out and some of the dynamically made windowlists won't be shown as they show up as false positives. An update will be pushed when it is ready.

[LordEntrails]

Thank you so much!

[superteddy57]

This should now be pushed LIVE

[LordEntrails]

Thank you :) No more inconsistencies, it seems to be working as expected. I also appreciate breaking out the anonymous links.

I will note that the removal of the link to the anonymous items does make it harder to track down the anon link, esp since the item only has the xml ID and not the UI name. Somethign to think about next time you are updating it, but nothing to worry about now.

[superteddy57]

Something to look at for sure next time.

[spoofer]

I am having an issue with the Converion Checker. I am trying to open all links. The first time I clickopen the next 10, it works. The second time, I get this error:

Script execution error: [string "ConversionChecker:scripts/LinkChecker.lua"]:370: attempt to index local 'v' (a userdata value)

[lokiare]

I am having an issue with the Converion Checker. I am trying to open all links. The first time I clickopen the next 10, it works. The second time, I get this error:

Script execution error: [string "ConversionChecker:scripts/LinkChecker.lua"]:370: attempt to index local 'v' (a userdata value)

Some things to check:

Have you tried deleting SWUFGANYFGDTP from your vault? This makes sure you are using the version from the Forge.
That you don't have very large modules. Due to how LUA works if your module is very large it can be overwhelmed by the number of links.
That you created the module in Fantasy Grounds and didn't do it by hand or using an external app.

[spoofer]

The bug is in the code. I guess the code is trying access a value "v" and this in the number the user types into the interface. It is set to a default value of 10. If you use the default value you get the error. If you type a value, then there is no error.

....

I tested a little bit. I closed everything, and started again. If I type a number before opening links, there is no error. Then the program seems to throw the error again if I keep using my new value.

[lokiare]

The bug is in the code. I guess the code is trying access a value "v" and this in the number the user types into the interface. It is set to a default value of 10. If you use the default value you get the error. If you type a value, then there is no error.

....

I tested a little bit. I closed everything, and started again. If I type a number before opening links, there is no error. Then the program seems to throw the error again if I keep using my new value.

Did you check the three things in my previous post?

[spoofer]

I cannot find SWUFGANYFGDTP in the Vault, so I assume that is not the problem. It is not the other two either.