D&D Official Theme, various issues after the last update

[Lo Zeno]

After the last update the D&D Official Theme shows alignment issues and errors in the console.

The following screenshots have been taken from a clean campaign, using the 5E ruleset and only the D&D Official Theme, no other extension:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58678&stc=1&d=1693384597
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58679&stc=1&d=1693384606
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58680&stc=1&d=1693384612

Also, when trying to create a new note both DM and players get the following errors:



[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)
[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)
[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)


I've also attached the compiled logs with the errors.

[Nemesis Unbound]

After the last update the D&D Official Theme shows alignment issues and errors in the console.

The following screenshots have been taken from a clean campaign, using the 5E ruleset and only the D&D Official Theme, no other extension:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58678&stc=1&d=1693384597
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58679&stc=1&d=1693384606
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58680&stc=1&d=1693384612

Also, when trying to create a new note both DM and players get the following errors:



[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)
[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)
[8/30/2023 9:32:13 AM] [ERROR] window: No vertical anchor defined for control (separator) in windowclass (note_header)


I've also attached the compiled logs with the errors.

I'm using the Pathfinder 1e rule set and also have a number of display problems. The text for hot keys has changed to an ugly and difficult to read mustard yellow colour. The icons and text for the Assets tab icons are now a bright neon light blue against a white background. The chat bar is an ugly grey colour that clashes with the rest of the theme. I am assuming these are all errors and have reported and provided my compiled logs already.

[LordEntrails]

I'm using the Pathfinder 1e rule set and also have a number of display problems. The text for hot keys has changed to an ugly and difficult to read mustard yellow colour. The icons and text for the Assets tab icons are now a bright neon light blue against a white background. The chat bar is an ugly grey colour that clashes with the rest of the theme. I am assuming these are all errors and have reported and provided my compiled logs already.
This type of behavior usually happens when you have more than one theme loaded. In a new campaign with no extensions do you see this behavior?

[Nemesis Unbound]

This type of behavior usually happens when you have more than one theme loaded. In a new campaign with no extensions do you see this behavior?

I still see the same problems with a new campaign, no extensions. Double checked my existing campaign and there is only one theme active. The only extensions are the Feature: Advanced Bestiary and the Golarion Languages and Fonts FGU.

[JohnFintch]

Same problem to me. Seems that something broke since last update.

[LordEntrails]

Nemesis and John, Please provide details such as Lo Zeno did in the OP. That will help the developers find and resolve the issues much more quickly. Thanks!

[Nemesis Unbound]

Here is my log and a couple of screenshots.

[Moon Wizard]

Just pushed several fixes for general themes, including the D&D Official theme.
I plan to look at and update the Pathfinder Official theme later today.

Regards,
JPG

[Zacchaeus]

I can reproduce this as well; both the theme shenanigans and the error when creating a new note. All you need to do is open a campaign with the theme and click on new note.

Edit: Moon Wizard was clearly already on the case.

[JohnFintch]

Sorry for that. Here we go all the info.58691

[Moon Wizard]

@JohnFintch, that's a community extension issue, as it does not occur when the 5E ruleset is loaded without any community extensions. You can see a number of extensions reported in your chat window on start up. You'll need to report to the offending community extension developer.

Regards,
JPG

[superteddy57]

Sorry for that. Here we go all the info.58691

Can you verify without extensions to see if you get the same error? Also ensure you have grabbed the latest update as well.

[JohnFintch]

Can you verify without extensions to see if you get the same error? Also ensure you have grabbed the latest update as well.

Look like it's a ext problem. I'm finding out which it is.

[Lo Zeno]

Just pushed several fixes for general themes, including the D&D Official theme.
I plan to look at and update the Pathfinder Official theme later today.

Regards,
JPG

Thanks Moon Wizard, that fixed the errors when creating a new note and solved the alignment issues I reported.
However, after downloading the update you just pushed I discovered a few more alignment issues in the D&D Official Theme. They're minor and do not negatively affect functionalities, but they're pretty noticeable:

In the Asset window, all the group icons have turned a weird cyan colour instead of the tan/dark colour it had originally:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58692&stc=1&d=1693413858

When opening any Image window, the identified/unidentified toggle icon is overlapping to the edge of the painted "frame", while it should be inside; also, the painted "frame" lacks the bottom which seems to be covered by the picture itself:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58694&stc=1&d=1693413927

The Encounter window has issues such as the CR box overlapping with the text "encounter" that should be on the right, the CR and XP box are pushed too high and covering the bottom of the painted header, and the separator line under the two boxes is covering the bottom of the two boxes, it's like everything at the top is "squished" together:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58696&stc=1&d=1693414070

The Quest window has essentially the same issues as the Encounter window, particularly noticeable here is how the CR number is overlapping with the label "Quest":
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58697&stc=1&d=1693414289

I hope I have caught them all this time.

[BaneTBC]

@JohnFintch It's Critically Awesome Essentials. The issue has already been reported on their Discord, but it could be a bit before it gets resolved. The error only occurs on the DM's(Hosts) side and not the clients so you'll have to decide if its too much of an issue and disable until resolved or if you can deal with it for the moment.

[JohnFintch]

@JohnFintch It's Critically Awesome Essentials. The issue has already been reported on their Discord, but it could be a bit before it gets resolved. The error only occurs on the DM's(Hosts) side and not the clients so you'll have to decide if its too much of an issue and disable until resolved or if you can deal with it for the moment.

Thanks very much for reply. I'll look if I could deal with it for the moment.

[Moon Wizard]

Hey all, I've updated the D&D Official theme again; as well as updates to the Pathfinder Official theme. Please run a new Check for Updates to pull the most recent for those themes.

Regards,
JPG

[Lo Zeno]

Hey all, I've updated the D&D Official theme again; as well as updates to the Pathfinder Official theme. Please run a new Check for Updates to pull the most recent for those themes.

Regards,
JPG

The asset window in the D&D Official Theme now looks fine, however the Image, Quest and Encounter windows still show the same weird alignments of elements, especially the odd overlapping of textboxes over text labels

[Lo Zeno]

Hey all, I've updated the D&D Official theme again; as well as updates to the Pathfinder Official theme. Please run a new Check for Updates to pull the most recent for those themes.

Regards,
JPG

I have tried selecting different themes, and I see many of the same issues repeating exactly the same (still using 5E ruleset). So I tried creating a new campaign and selecting no theme at all, and even the base theme has the same problems, so I suspect it's something at a more basic level, rather than theme specific adjustments:

With no theme selected, the Image window still shows the Identified/unidentified toggle "overlapping" the box:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58708&stc=1&d=1693471388
while it should instead be BETWEEN the two boxes, not overlapping with the edge (the following picture is from the FGU wiki):
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58709&stc=1&d=1693471563

The Quest window looks like this in every theme, with the "CR 0" text overlapping over the "Quest" word, such that the 0 and Q basically merge, and the XP box not aligned with the top title:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58711&stc=1&d=1693471741

And the Encounter window looks like this with the CR textbox covering half of the word "Encounter" and the bottom separator being too high:
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=58712&stc=1&d=1693471819

I have not taken screenshots of every theme I tried, but I see these same exact alignment issues in the Industrial, Winter, Wizard Desk, D&D Official and Leather themes, on top of seeing them when I select no theme at all, that's why I suspect it's not a theme-specific issue, but something underlying.

EDIT: Also in FG Classic theme.

[Moon Wizard]

Thanks for the reports. I'll get those fixed in the next theme hot fix update, probably tomorrow.

Regards,
JPG

[Lo Zeno]

Thanks for the reports. I'll get those fixed in the next theme hot fix update, probably tomorrow.

Regards,
JPG

The latest update seems to have solved all the visual issues I encountered!

[swest]

FYI:
The Pathfinder Official Theme throws the following error:



[ERROR] Script execution error: [string "P:DesktopPFRPGTheme"]:3: attempt to call field 'setSidebarCategoryIconColor' (a nil value)

I am up-to-date with FGU.

Thanks,

- s.west

[p.s. I know this is the D&D thread, but Moon Wizard mentioned the PFRPG theme earlier in the thread, so I just dropped it in here.]

[Moon Wizard]

@swest,

This is working for me without errors; so I expect that either you have an unpacked version of CoreRPG without the right ColorManager script functions, or you have another extension which is overriding the ColorManager script.

Regards,
JPG

[swest]

@swest,

This is working for me without errors; so I expect that either you have an unpacked version of CoreRPG without the right ColorManager script functions, or you have another extension which is overriding the ColorManager script.

Regards,
JPG

Oops! False alarm.

That was the case, exactly. I had been doing some development (which I'm currently not working on), and when it came my turn to run one of my group's games, I completely forgot about it.

Thank you, very much. This solves some other issues I was seeing and couldn't account for.

Cheers!

- s.west