5e - Glancing Blows houserule & Damage Adjustment Tags

[Kael the Adventurer]

Hello again! Got another extension for ya, this time automating the houserule of Glancing Blows (half-damage if an attack roll exactly equals a target's AC), as well as altering the Damage Adjustment tags in Fantasy Grounds to match the existing terminology in 5e. If either of those sound intriguing to you, check them out here! :D

Forge: Glancing Blows (https://forge.fantasygrounds.com/shop/items/1132/view)
Github: Glancing Blows (GitHub) (https://github.com/ThatDudeThatIsOverThere/Glancing-Blows)

Cheers,
~Kael the Adventurer

(P.S.: Our Master's Amulet (https://forge.fantasygrounds.com/shop/items/1120/view) extension, which also add/alters tags, is compatible with this one :) )

Version 1.0.0: Initial release, Glancing Blows, and Damage Adjustment tags
Version 1.1.1: Fixed bug where client-side rolls were not correctly triggering Glancing Blow halved damage, fixed assorted bugs caused by Fantasy Grounds updates, updated logo and icon graphics to match new Fantasy Grounds aesthetics, and (hopefully) improved compatibility with various other extensions.
Version 1.1.2: Fixes for compatibility with FGU v4.7.1, as well as with other extensions that have been updated since release.

[BushViper]

Hi there.

I like the extension, but I wanted to point out that it conflicts with MeAndUnique's Blissful Ignorance extension. Rolling damage is where I am seeing the bulk of the errors. I haven't done a lot of testing as the errors make using the two extensions together impossible. However, I can provide more details about what I encountered, if you would like.

Also, I had a question. Would it be possible to have a setting provides just the Glancing Blow houserule without the rest of the options? To be clear, I'd like to have it all, but having the option to pare it down when problems arise would be nice.



56898

[ThatDudeOverThere]

Hi there.

I like the extension, but I wanted to point out that it conflicts with MeAndUnique's Blissful Ignorance extension. Rolling damage is where I am seeing the bulk of the errors. I haven't done a lot of testing as the errors make using the two extensions together impossible. However, I can provide more details about what I encountered, if you would like.

Also, I had a question. Would it be possible to have a setting provides just the Glancing Blow houserule without the rest of the options? To be clear, I'd like to have it all, but having the option to pare it down when problems arise would be nice.



56898

Interesting, thanks for the report! We can take a look at this and see if we can find a solution.

[BushViper]

Interesting, thanks for the report! We can take a look at this and see if we can find a solution.

I don't want to speak for him, but in my experience MeAndUnique has always been extremely willing to help deconflict extensions that don't play well with his own.

You might reach out to him.

[ThatDudeOverThere]

I don't want to speak for him, but in my experience MeAndUnique has always been extremely willing to help deconflict extensions that don't play well with his own.

You might reach out to him.

Thanks! I had considered that as well. Any time I have ever needed to speak with MeAndUnique, they have always been pleasant to deal with.

Hopefully we won't need to though, we did do a fair amount of testing with Kit'n'Kaboodle and Constitutional ammendments but not blissfull ignorance, hopefully once we can actually dig in it will be an easy fix.

[MeAndUnique]

At a quick look on my end, I should add some extra safety code to prevent the error itself. However the nature of the error suggests that the flow of logic for how damage reduction/vulnerability has been adjusted, so even if I prevent the error from showing up there is a good chance that the functionality will still be impacted for Blissful Ignorance.

[MeAndUnique]

I should also clarify that I'm fully open to making additional considerations in Blissful Ignorance to accommodate Glancing Blows, though I'm super busy right now, so I won't have a chance to look for myself at this extension closely enough to figure out what those might be for a little while.

[Darth Decisive]

It also seems to be causing a problem with Better Combat Effects Gold! Specifically, with triggering the new Sneak Attack functionality!

[Kael the Adventurer]

It also seems to be causing a problem with Better Combat Effects Gold! Specifically, with triggering the new Sneak Attack functionality!

Oh dear! We are still working on a fix for the Blissful Ignorance compatibility, but we can take a look at that when we get some time. Can you please send me a link to the conflicting extension, and provide as many details as possible about when/where the bug is occurring?

[Darth Decisive]

Oh dear! We are still working on a fix for the Blissful Ignorance compatibility, but we can take a look at that when we get some time. Can you please send me a link to the conflicting extension, and provide as many details as possible about when/where the bug is occurring?

Sure thing!

The extension is Better Combat Effects Gold by Grim Press.

https://forge.fantasygrounds.com/shop/items/155/view

It does a whole bunch of stuff, but the conflicting thing happens with their automated Sneak Attack. Its set up so that if you have the Sneak Attack effect on you, a one-use DMG bonus is added to your next damage if you hit with an attack with a qualifying weapon for Sneak Attack. It also automates sneak attack damage for you based on your Rogue levels.

With both extensions active, if you make an attack with a creature with the Sneak Attack effect, something flares up and throws an error message. The attack will still roll and show if it is a hit or a miss, but the sneak attack automation won't trigger correctly. This error is thrown whether or not you qualify for sneak attack (like if you have disadvantage or no ally near the target).

[rhagelstrom]

Sure thing!

The extension is Better Combat Effects Gold by Grim Press.

https://forge.fantasygrounds.com/shop/items/155/view

It does a whole bunch of stuff, but the conflicting thing happens with their automated Sneak Attack. Its set up so that if you have the Sneak Attack effect on you, a one-use DMG bonus is added to your next damage if you hit with an attack with a qualifying weapon for Sneak Attack. It also automates sneak attack damage for you based on your Rogue levels.

With both extensions active, if you make an attack with a creature with the Sneak Attack effect, something flares up and throws an error message. The attack will still roll and show if it is a hit or a miss, but the sneak attack automation won't trigger correctly. This error is thrown whether or not you qualify for sneak attack (like if you have disadvantage or no ally near the target).

Looking at the BCEG conflict, it seems GB is overriding onAttack but never calling the original, which we can work with if you need it that way but I'd also suspect there are more conflicts with other things not yet discovered.

[ThatDudeOverThere]

Update: version 1.0.2 seems to be working as intended with the latest version of Blissful Ignorance.

[ThatDudeOverThere]

Looking at the BCEG conflict, it seems GB is overriding onAttack but never calling the original, which we can work with if you need it that way but I'd also suspect there are more conflicts with other things not yet discovered.

If you have any specific re-writes to propose we are willing to work with you to get it fixed. Unfortunately none of thus actually use Better Combat Effects Gold and so we are unable to test for compatability. We aren't unwilling to make changes, we just don't currently have access to the extension to know what changes to make, or to ensure they actually work.

As it is a paid extension I can't just download it to test for compatability. I personally can't justify paying for an extension I don't use, to fix a compatability issue with an extension we are giving away for free.

[rhagelstrom]

If you have any specific re-writes to propose we are willing to work with you to get it fixed. Unfortunately none of thus actually use Better Combat Effects Gold and so we are unable to test for compatability. We aren't unwilling to make changes, we just don't currently have access to the extension to know what changes to make, or to ensure they actually work.

As it is a paid extension I can't just download it to test for compatability. I personally can't justify paying for an extension I don't use, to fix a compatability issue with an extension we are giving away for free.

I put in a PR on your GitHub earlier today for your review that resolves the issue and should keep GB from butting heads with others in that area.

[BlazingAzureCrow]

Just popping in to note that I'm still having conflicts between this and Blissful Ignorance. Was this confirmed resolved?

[BushViper]

Just popping in to note that I'm still having conflicts between this and Blissful Ignorance. Was this confirmed resolved?

Having the same issue.

[BushViper]

The Glancing Blows extension prevents the DMGR code from Better Combat Effects Gold from functioning.

I don't know if there are any other conflicts, but this is one I came across personally.

[BushViper]

Turns out that Glancing Blows also prevents the Rob2e Mirror Image extension from functioning as well.

I love the concept and intend to keep using glancing blows, but my group decided to go back to tracking it manually because there are too many conflicts with more comprehensive extensions.

[BushViper]

I assume this ext has been abandoned given that the conflicts persist?

[rhagelstrom]

I assume this ext has been abandoned given that the conflicts persist?

You can try my branch https://github.com/rhagelstrom/Glancing-Blows/tree/bceg-conflict I put in a pull request a while back on the Authors GitHub.

[Kael the Adventurer]

I assume this ext has been abandoned given that the conflicts persist?

My team and I have not been able to work on this extension in quite some time due to life getting in the way, unfortunately. Beyond the compatibility issues, something we came across recently through inadvertent playtesting is that while the extension correctly detects Glancing Blows no matter if it is the host or a client who rolled the attack, it only actually halves the damage if the attack was rolled by the DM/host.

I would love to be able to tell you that this will be resolved soon, but the reality is that I simply don't know when we will be able to work on this again. Thanks for your understanding, and I apologize for the inconvenience.

[Kael the Adventurer]

You can try my branch https://github.com/rhagelstrom/Glancing-Blows/tree/bceg-conflict I put in a pull request a while back on the Authors GitHub.

Hey there, rhagelstrom! We have updated this extension to fix the bug where only the DM could roll Glancing Blow damage (successfully; players will now correctly roll GB damage) as well as some other bugs caused by Fantasy Grounds updates. When we did this, we started with the version/fork you made to fix compatibility with other extensions; we are hoping that that compatibility has remained intact with our changes, but we can't test that as we don't have access to those paid extensions ourselves. There's no obligation, of course, but if you're interested I would love to hear from you whether or not this version (v1.1.1, live in Forge and also published to GitHub) works with BCEG (etc.). Let me know!

Edit: Unfortunately, this extension is actually broken still/again; while it *can* roll GB damage correctly from the player side as well now, it does so only when you do a manual roll instead of a randomized (i.e.: normal) roll, which we didn't catch right away because we had been using manual rolls to test the extension. Frankly, at this point, we are fresh out of ideas; if anyone wants to take a look at this and give suggestions, feel free. https://github.com/ThatDudeThatIsOverThere/Glancing-Blows/tree/v1.1.1

[Kael the Adventurer]

Hey folks! I am happy to announce that functionality has been restored for this extension! Fixes have been implemented so that it's compatible with both FGU v4.7.1 and with our Shield Guardian/Master's Amulet extension. Latest version as of this comment is v1.1.2

[Gilafron]

Hi Kael,

It appears that this extension is not halving the damage on a glancing blow. See screen shot below.

67602

[Kael the Adventurer]

Yeah, a couple of our extensions broke with a recent FG update, unfortunately. Sigh. Thanks for letting me know, we'll try to take a look at that soon