PDA

View Full Version : Token Modules Disappeared?



Tailz Silver Paws
November 7th, 2022, 07:53
Dear Devs, I'm doing a little troubleshooting here as I have been contacted by two clients who have purchased two of my Token Packs via the Fantasy Grounds Forge. According to the customers the token modules were appearing in their in-application Assets Panels in Fantasy Grounds, but after the last Fantasy Grounds update the modules no longer appear.

The information I have so far from the customers is that the following token packs have disappeared:

Modern Furniture Tokens (https://forge.fantasygrounds.com/shop/items/480/view)
Fantasy Furniture III (https://forge.fantasygrounds.com/shop/items/614/view)


I just logged into a test campaign myself to see if the token modules are not appearing for me, and discovered that the only token module I can see in the Assets Panel is Monster Tokens III (https://forge.fantasygrounds.com/shop/items/640/view). All other token modules are persona non-grata (except for the default token modules that ship with Fantasy Grounds).

Have there recently been any changes that could cause this? Has the formatting of token packs recently been changed (I don't remember seeing any info in any developer news)?

ju95
November 7th, 2022, 16:20
Nothing has been changed on the forge or updater ends lately, so I'm not sure exactly how it could've broken. If you use the gift function to give me access to one of the items so I can test the normal use case I can attempt to see what the issue is.

Trenloe
November 7th, 2022, 16:57
It appears this is not limited to some of Tailz's tokens - I can't access tokens from some other Forge token products too.

For example. I can access tokens through "Assets" for these two: https://forge.fantasygrounds.com/shop/items/256/view and https://forge.fantasygrounds.com/shop/items/295/view

But I can't access tokens for this: https://forge.fantasygrounds.com/shop/items/255/view This module also include portraits, which I can access fine. So it's not an issue with the product being downloaded/installed by the updater, but something with the token aspect of the product.

I also can't access the tokens from this product: https://forge.fantasygrounds.com/shop/items/606/view

The only difference I can see between the two products listed above that work, and the two that don't, is that the two that work don't have a thumbnail.png file in the downloaded .dat vault file, but the two that don't show tokens do have a thumbnail.png file. I don't know if that's the cause, but it's the only difference I can see.

ju95
November 7th, 2022, 17:34
It appears this is not limited to some of Tailz's tokens - I can't access tokens from some other Forge token products too.

For example. I can access tokens through "Assets" for these two: https://forge.fantasygrounds.com/shop/items/256/view and https://forge.fantasygrounds.com/shop/items/295/view

But I can't access tokens for this: https://forge.fantasygrounds.com/shop/items/255/view This module also include portraits, which I can access fine. So it's not an issue with the product being downloaded/installed by the updater, but something with the token aspect of the product.

I also can't access the tokens from this product: https://forge.fantasygrounds.com/shop/items/606/view

The only difference I can see between the two products listed above that work, and the two that don't, is that the two that work don't have a thumbnail.png file in the downloaded .dat vault file, but the two that don't show tokens do have a thumbnail.png file. I don't know if that's the cause, but it's the only difference I can see.

That is strange. Thanks for the added info, as far as I can tell currently it should be working correctly, so I'll bring it up to John and see if something changed with the asset loading from the vault. If someone does notice a token pack not using the vault and also not working, please let me know so I can narrow the issue down to if it is a vault issue or not.

ju95
November 7th, 2022, 17:55
Found the issue. The items with the issue use Tokens with a capital T as the folder name, when the client now specifically checks for an all lowercase folder name for all initial asset paths (So images, portraits, tokens, etc). If these items were created with the token maker, let me know, but if they were uploaded direct just drop the capitalization and it should work again.

Trenloe
November 7th, 2022, 18:05
Found the issue. The items with the issue use Tokens with a capital T as the folder name, when the client now specifically checks for an all lowercase folder name for all initial asset paths (So images, portraits, tokens, etc).
Good find!

LordEntrails
November 7th, 2022, 18:25
Is there the intent to keep the new requirement for lowercase folder name or will a future update restore the ability to make the folder name case insensitive?

Moon Wizard
November 7th, 2022, 19:01
I think the intent is to keep this as lowercase. This has been a constant source of issues trying to maintain both, as the performance overhead for the sheer number of files in the catalog and vault when using case-sensitive vs. case-insensitive compare has a non-trivial impact on performance of loading.

Regards,
JPG

LordEntrails
November 7th, 2022, 19:06
Not a problem. Good reasoning and I'm all for performance!

Moon Wizard
November 7th, 2022, 20:08
I did a full review for load times over the summer, and made a lot of changes that coincided with other updates as well as upgrading the Unity toolchain. It's all sort of tied together and culminated in v4.3.0 release.

If I remember right, for the full catalog (2700 products), I think the load times for vaulted products were less than half of what they were previously in v4.2.2. (The effect is a lot less pronounced on unvaulted products.)

Regards,
JPG

LordEntrails
November 7th, 2022, 20:20
I did a full review for load times over the summer, and made a lot of changes that coincided with other updates as well as upgrading the Unity toolchain. It's all sort of tied together and culminated in v4.3.0 release.

If I remember right, for the full catalog (2700 products), I think the load times for vaulted products were less than half of what they were previously in v4.2.2. (The effect is a lot less pronounced on unvaulted products.)

Regards,
JPG
Excellent. Sounds like we might be at a point where the CSUAC+ assets might be manageable :)

Tailz Silver Paws
November 7th, 2022, 22:43
Found the issue. The items with the issue use Tokens with a capital T as the folder name, when the client now specifically checks for an all lowercase folder name for all initial asset paths (So images, portraits, tokens, etc). If these items were created with the token maker, let me know, but if they were uploaded direct just drop the capitalization and it should work again.

Thank you ju95 for discovering that this whole problem is caused by a T, instead of a t.

To everyone else, thank you to you as well!

I will push through the change to my packs ASAP.

On a side note, will this affect all folder names? What about folders within the tokens folder which are the names of Objects or Characters? For when they are displayed in the asset Panel, asthetics says have a capital letter for the start of the name, but since it is extracted from a folder name.... I think you get my point?

Moon Wizard
November 8th, 2022, 00:47
It's only for the root asset folders that specify the type of asset is included (images/, tokens/, portraits/, etc.).

Regards,
JPG

Tailz Silver Paws
November 8th, 2022, 01:26
It's only for the root asset folders that specify the type of asset is included (images/, tokens/, portraits/, etc.).

Regards,
JPG

Thank you for the update Moon Wizard! :D

Moon Wizard
November 8th, 2022, 01:58
Thanks for your patience; this whole discussion jogged my memory about all the work back in the summer.

Regards,
JPG