All tokens invisible to players following update.

[Rylan Storm]

I had a map open during my session last week, 5 players on the screen and around 5 NPCs. Since the update, no tokens are shown to the players at all.

I've moved them off the map, back onto the map, to no avail. It's not just the NPCs but all the tokens, players, pets etc. I've hid the NPC tokens, made them visible again, to no avail.

Any suggestions please? Could it be linked to "Token visibility did not always work correctly with ambient lighting setting, especially on session reload. Fixed." in any way?

[Rylan Storm]

To add to this, the players can interact with the token if I explain exactly where it is. It's just a visibility issue. So I've tried the pogs that come with the module and not the custom tokens I use. Still, same issue.

[Moon Wizard]

Can you please zip up and post the campaign, so I can forward to @cpinder?

Thanks,
JPG

[Mephiston]

Having the same issues with an online session right now.

[Moon Wizard]

@Mephiston,

Please zip up your campaign folder, and post for review.

Thanks,
JPG

[Rylan Storm]

OK. So I have a temporary fix.

Click "Enable/Disable Lighting" on and then off again. Tokens will appear. But you'll have to do it on every map you load. Uploading the campaign shortly.

[Moon Wizard]

Just pushed a hot fix with a fix to some of the new lighting shaders from @cpinder. Can you please run a new Check For Updates, and try again?

Regards,
JPG

[Rylan Storm]

Sorry Moon but that's not fixed it. I still have to Enable and Disable Lighting with every new map. Im just sending you the PM now with my campaign.

[pindercarl]

Sorry Moon but that's not fixed it. I still have to Enable and Disable Lighting with every new map. Im just sending you the PM now with my campaign.

Can you send me the campaign? John will just have to forward it to me anyway. Thanks.

[Moon Wizard]

I've forwarded your PM to @pindercarl.

JPG

[Moon Wizard]

Just pushed a hot fix from @pindercarl to address this issue. Please run a new Check for Updates, and try again.

Regards,
JPG

[gmkieran]

Our campaign experienced this issue tonight after updating to the latest available version. The issue seemed to be linked to the mask layer. By adding and removing the mask, the GM was able to render tokens already on the map visible, if they were marked visible in the combat tracker. Tokens that were not marked visible in the CT at the time the mask was added and removed did not become visible on the map until they had been marked visible in the CT and then the mask had been added and removed again.

edit: I see that the hotfix was pushed at 10:45 or shortly before. If that's EST that would be after we started our session, so we may have missed the hotfix. I have advised our GM and he will check.

[Shinmuriel]

I am having this same issue with my players, is there a fix?

[Moon Wizard]

Please run a new Check for Updates, and try again. A new version was pushed around 8PM Pacific time.

If you are still having an issue, please have the GM provide the zipped up campaign folder (via DropBox or Google Drive), and specify which map is affected, and any steps they followed to see the issue.

Thanks,
JPG

[Rylan Storm]

There has been a change but the issue does not appear to be resolved. In fact, I'd say that things have now got a little worse.

Here's what has happened

1) My players can now see their own tokens. However, looking at it, its very washed out.
2) They cannot see NPC tokens until I press Enable/Disable lighting at least once.
3) The little icons in the bottom left of a map, which shows who has that map open are missing.

I've attached a screenshot and my campaign has been provided. However, I do want to make it clear, this is not affecting a single map. It's all of them.

54762

[Rylan Storm]

Also, as another note, I think I need to clarify something.

The final state of "Enable/Disable Lighting" does not matter. It's not that it only works if lighting is disabled, or it only works if lighting is enabled. It's just that you have to press it at least once for tokens to appear. If you have lighting disabled, and you want it disabled, just turn it on then turn it off again etc.

I'm also questioning whether this is a separate issue from the reports we're seeing suggesting that line of sight is also broken. It looks like there is a general issue with map display since the update.

[Shinmuriel]

Appears to be fixed, thanks!

[Draykor]

I enabled mask and unhid the entire map to fix it.

[pindercarl]

Also, as another note, I think I need to clarify something.

The final state of "Enable/Disable Lighting" does not matter. It's not that it only works if lighting is disabled, or it only works if lighting is enabled. It's just that you have to press it at least once for tokens to appear. If you have lighting disabled, and you want it disabled, just turn it on then turn it off again etc.

I'm also questioning whether this is a separate issue from the reports we're seeing suggesting that line of sight is also broken. It looks like there is a general issue with map display since the update.

I am unable to reproduce the error in your campaign with the 10-18-2022 release.

[Rylan Storm]

Having seen Shinmuriel's comment above, I went and retested. There was no update. I chose a different map and, to make testing easier, I added a client on my own machine. It worked, as expected, immediately. I would have been tempted to come back here and announce that mine too was fixed. However, I've been in IT long enough to distrust these things, so I asked a friend to check and I chose a fresh map to test.

I have recorded the issue. It's fairly easy to reproduce but it's not consistent. I don't believe it's an issue with the campaign at all. The campaign has been working fine until I updated before yesterday's session.

Here is a video I have recorded, demonstrating the issue, https://youtu.be/Xd-uaHTeWVM I'm happy to jump on a zoom meeting to share my screen and discuss further.

[Trenloe]

Having seen Shinmuriel's comment above, I went and retested. There was no update. I chose a different map and, to make testing easier, I added a client on my own machine. It worked, as expected, immediately. I would have been tempted to come back here and announce that mine too was fixed. However, I've been in IT long enough to distrust these things, so I asked a friend to check and I chose a fresh map to test.
If it works OK for you, but not for a friend - are you and your friend both running in the "live" channel and fully updated to the latest version?

Compiling the logs on both the player side and the GM side might help to investigate any version mismatches: https://fantasygroundsunity.atlassian.net/wiki/spaces/FGCP/pages/1242136781/How+to+Compile+Logs

[Rylan Storm]

Just to clarify, the test was done with a 2nd client on my machine, and with a friend connected. Neither the 2nd client, or the connected friend can see the tokens until I refresh the lighting. When I then add a new token, I have to refresh the lighting once again before either the 2nd client, or the connected friend, can see the tokens.

I doubt that we're looking at a version mismatch. For one, the 2nd client is on my machine. Secondly, all of us online confirmed that we were getting an 89.5mb update at the same time.

Here's my logs if anyone can make sense of it.

[Trenloe]

Just to clarify, the test was done with a 2nd client on my machine, and with a friend connected. Neither the 2nd client, or the connected friend can see the tokens until I refresh the lighting.
Ah, sorry - I was confused by the "It worked, as expected, immediately" comment.

[Rylan Storm]

Yeah. That was when I did my intital test. As I say, Ive become too long in the tooth to accept that a passed test, when nothing has changed since the last failed test, represents success. So I ran a 2nd test with a friend connected but was immediately able to witness the error on the 2nd client.

[Zacchaeus]

I'm not seeing this either. One thing have you tested in a new campaign without any extensions?

[Rylan Storm]

Turned all extensions off. Not tested a new campaign. I've just done that now. Exactly the same issue.

[pindercarl]

Yeah. That was when I did my intital test. As I say, Ive become too long in the tooth to accept that a passed test, when nothing has changed since the last failed test, represents success. So I ran a 2nd test with a friend connected but was immediately able to witness the error on the 2nd client.

Just to clarify, the issue occurs when you have two clients connected (one local and one remote), but does not occur when only a local client is connected?

[Rylan Storm]

No, the issue appears consistently, almost all of the time.

Test 1 - Yesterday evening. 5 players connected. Players could not see tokens till I refreshed.
Hotfix
Test 2 - Yesterday evening. 2 players connected. Players could not see tokens till I refreshed.
Hotfix 2
Test 3 - Earlier today. 1 player connected. Player could not see tokens till I refreshed.
Test 4 - Earlier today. 2nd client on my machine connected. This was successful.
Test 5 - This evening. 2nd client on my machine connected. Could not see the token.
Test 6 - This evening. A player connected (whilst my 2nd client was connected) and could not see the token. This is the test shown in the video.

[pindercarl]

No, the issue appears consistently, almost all of the time.

Test 1 - Yesterday evening. 5 players connected. Players could not see tokens till I refreshed.
Hotfix
Test 2 - Yesterday evening. 2 players connected. Players could not see tokens till I refreshed.
Hotfix 2
Test 3 - Earlier today. 1 player connected. Player could not see tokens till I refreshed.
Test 4 - Earlier today. 2nd client on my machine connected. This was successful.
Test 5 - This evening. 2nd client on my machine connected. Could not see the token.
Test 6 - This evening. A player connected (whilst my 2nd client was connected) and could not see the token. This is the test shown in the video.

Thanks for the clarification. In the sample video, were the tokens invisible to the player added after the map was shared?

[Zacchaeus]

Turned all extensions off. Not tested a new campaign. I've just done that now. Exactly the same issue.

You don't have any unpacked rulesets in your ruleset folder? What ruleset and what theme are you using?

[pindercarl]

You don't have any unpacked rulesets in your ruleset folder? What ruleset and what theme are you using?

I don't think this is a ruleset issue. The original bug was that maps that did not use LOS, lighting, or masks were not setting the token visibility when the image was initialized. That's why toggling the state of the lighting fixes the visibility. At the moment, I trying to ascertain what other circumstances are not triggering a token visibility check when they should be.

[Rylan Storm]

Hmmn.

In the sample test I added Winter Wolf 1 before my friend logged in. I shared the map after I confirmed he was connected properly. He could not see it. I added Winter Wolf 2 after he was connected and he could not see that.
This matches the experience of the live session. The encounter was already running from last week, so the players and tokens were all on the map. I shared the maps again when I logged on to start the game.

So I'm experiencing the issue both ways, when I add the tokens before sharing and when I add them afterwards.

I've just realised something else also Enabling and Disabling Line of Sight makes the tokens dissapear again until I refresh the lighting once more. https://youtu.be/R_vuU10QRKM

[Rylan Storm]

All rulesets are packed. Theme is the generic one.

[pindercarl]

Hmmn.

In the sample test I added Winter Wolf 1 before my friend logged in. I shared the map after I confirmed he was connected properly. He could not see it. I added Winter Wolf 2 after he was connected and he could not see that.
This matches the experience of the live session. The encounter was already running from last week, so the players and tokens were all on the map. I shared the maps again when I logged on to start the game.

So I'm experiencing the issue both ways, when I add the tokens before sharing and when I add them afterwards.

I've just realised something else also Enabling and Disabling Line of Sight makes the tokens dissapear again until I refresh the lighting once more. https://youtu.be/R_vuU10QRKM

The tokens in video 3 are unfriendly, so I would expect them to be invisible to players unless they have a token with line-of-sight to the unfriendlies.

[Rylan Storm]

But they do. When I refresh the lighting, the 2nd client can see the tokens even though they arent on the map

[pindercarl]

I have been able to reproduce the error by adding tokens after the map has been shared. Re-sharing the map does not fix the problem. The map needs to be unshared and then reshared. Looking into the issue now.

[gmkieran]

We did some further experimenting tonight after updating to the latest available version. Adding tokens to a map the player had open did not populate tokens visible to the player. The tokens became visible if the player closed the map and re-opened it OR if the player closed the map and the GM re-shared it. Tokens that were on the map, but marked Not Visible in the combat tracker, did *not* become visible when the map was re-shared and the GM made the token visible in the CT until the map was closed and re-opened again, but other tokens that had already been set visible could be seen by the player.

Hope that helps!

[kmfdm]

Oh man, we had this problem too tonight but luckily the Lighting On/Off fixed it.
But it is weird, even when you put a new token on the board, got to turn Lighting back on/off.

[Roach]

We had andiffernt, but likely connected issue yesterday. My players could see all tokens on the map, even those set to 'hidden'. I even removed an invisible duergar from map and CT, and re-added him, and the players could immediately see the (supposedly hidden) token...

[Rylan Storm]

Given the issues we're seeing with the last update, missing tokens, lighting effects not working correctly, line of sight not being updated correctly, doors not allowing players to pass through, doors not updating the line of sight etc. is there any possibility of going back to the previous working build?

Tuesday's night session was ruined. I really don't feel like running a session until this gets fixed.

It strikes me that one of two things need to happen. Either we need a way of playing the older, working, build, whilst the new build continues as the live build or, preferably, SmiteWorks need to make a call to revert the build in the live channel and look at fixing these issues in a development branch. I'm happy to continue with testing either way.

[Zacchaeus]

You can revert to the previous build if the update was only ruleset changes but I don't believe that you can revert client changes.

[LordEntrails]

It strikes me that one of two things need to happen. Either we need a way of playing the older, working, build, whilst the new build continues as the live build or, preferably, SmiteWorks need to make a call to revert the build in the live channel and look at fixing these issues in a development branch. I'm happy to continue with testing either way.
This is why updates like these are available for several weeks prior to live release in the Beta channel. And are announced and discussed in the Laboratory (https://www.fantasygrounds.com/forums/forumdisplay.php?55-The-Laboratory). Unfortunately, no one testing there identified these issues.

Certainly no one is required or expected to test pre-releases, but those that can are very much appreciated.

As for rolling back this release, give that it has network changes in it necessitating all connected players also be on the same build, it would probably cause a great deal of trouble if it were to be reverted.

[Moon Wizard]

We've just rolled back most of the image changes made for v4.3 to work on them some more. This should now behave as it did in v4.2.2. Please run a new Check for Updates, and try again.

Regards,
JPG

[Rylan Storm]

Hey guys. I just want to say "Thank you" for this. I know it's not easy to have to roll back something you've pushed live but I think it really was needed here and I'm glad you were able to accomodate this.