Potential Ruleset Issues

[bmos]

I just noticed something about the relatively-new ActionAttack.onAttackResolve in 3.5E (and therefore PFRPG).

It has these two sections that check for variables (nDefenseVal and nAtkEffectsBonus) that are not available within their scope.


if nDefenseVal then
rCritConfirmRoll.sDesc = rCritConfirmRoll.sDesc .. " [AC " .. nDefenseVal .. "]";
end

if nAtkEffectsBonus and nAtkEffectsBonus ~= 0 then
local sFormat = "[" .. Interface.getString("effects_tag") .. " %+d]";
rCritConfirmRoll.sDesc = rCritConfirmRoll.sDesc .. " " .. string.format(sFormat, nAtkEffectsBonus);
end

This could be intentional, but I thought it was worth mentioning.
The new ruleset update looks great btw. The new addNPC/addPC stuff is neat.

[Moon Wizard]

Thanks for reporting. I'll look at getting these attached to the rRoll table soon.

Regards,
JPG

[Moon Wizard]

This is addressed in the hot fix I just pushed today.

Regards,
JPG

[bmos]

Awesome, thanks!

Rather than starting another thread, I'll just point out one more here :)

ActionDamage.applyDamage in 3.5E has a typo. "local nNonLethal" should be "local nNonlethal" as that is how all later uses of this variable are capitalized.
I don't think it's causing any issues, but it's accidentally a global variable.

[Moon Wizard]

Thanks, I checked in, so it will be addressed in the next 3.5E push, whenever that happens.

Regards,
JPG