Bug: Allied wildcards get bennie when villians geta Joker

[Lonewolf]

Tip of the hat to Savage Doswelk for spotting this one.

Replication steps:

Start a new campaign
Have a PC character sheet with assigned allied wildcards
Add PC and allies to CT
Add NPC hostiles
Keep clicking on next round button on CT until hostiles get a joker bonus.


Behaviour encountered: A set bennies will be given to hostile NPC side and allied wildcards.

Expected behaviour: Only a set bennies will be given to hostile NPC side

With more testing it appears that a PC getting a joker does not grant them to allied wildcards. So they will only ever geta bennies when hostile NPCs do.

[Moon Wizard]

I'll pass on to Ikael.

Regards,
JPG

[FrodoB]

I believe the issue is that


if DB.getValue(nodeCT, "type") == "npc" and CharacterManager.isWildCard(nodeCT) then

should read


if DB.getValue(nodeCT, "type") == "npc" and CharacterManager.isWildCard(nodeCT) and DB.getValue(nodeCT, "friendfoe") == "foe" then


If Ikael looks into this thread it might be an easy fix. :)

(manager_actioncard.lua, function triggerJokersWild(winGroup, oCard))

[Ikael]

You're right on the track here. This bug has been around since forever! Thank you got reporting this and figuring out the root cause.


I believe the issue is that


if DB.getValue(nodeCT, "type") == "npc" and CharacterManager.isWildCard(nodeCT) then

should read


if DB.getValue(nodeCT, "type") == "npc" and CharacterManager.isWildCard(nodeCT) and DB.getValue(nodeCT, "friendfoe") == "foe" then


If Ikael looks into this thread it might be an easy fix. :)

(manager_actioncard.lua, function triggerJokersWild(winGroup, oCard))

[Jiminimonka]

Bennie awards on Jokers don't seem to be working for "friendly" NPCs or "enemy" NPCs either in a test combat I just did. Players got Bennies just fine but not NPCs.

[FrodoB]

Works fine for me. Added 3 Wildcards to the combat tracker, skipped through combat until a Joker got drawn - all the enemy NPCs and the GM got a Benny.

Friendly NPCs are not supposed to get a Benny on a Joker.

[Jiminimonka]

Works fine for me. Added 3 Wildcards to the combat tracker, skipped through combat until a Joker got drawn - all the enemy NPCs and the GM got a Benny.

Friendly NPCs are not supposed to get a Benny on a Joker.

Cool, didn't know that, so it is working fine. Thanks