Occluder editing weirdness

[darrenan]

I've been seeing a lot of strange behavior with editing occluders lately. Not sure if it's from the last patch, or something earlier. I don't have solid repros for most of what I've been seeing, but I keep running into the following types of issues:


Intersection points not being properly created/added when drawing occluder rectangles over one another. Doesn't happen all the time.
When using the rectangle selection tool, points outside of the selection seem to be added to the selection but not being visually marked as selected. After deleting, undoing the delete, and then reselecting, it works fine.
When hitting enter to clear the selection or finish a group action, previously deleted points come back, or unrelated lines between points get deleted (I have a video of this one (https://1drv.ms/v/s!AhrZz9P9Tf8FoKpkc-xwcE7WfeRifA?e=7Z4o3R)). In this video I do a rectangle selection of two points, use ctrl-arrow to move the points up a few pixels, and then hit enter to finish the operation and deselect the points, which then deletes an unrelated line and causes some previously deleted points to reappear.



Is anyone else seeing these kinds of issues or is it just me? I feel like the occluder editing code needs a good solid code review.

I had two extensions loaded:
CSV Table Importer (https://forge.fantasygrounds.com/shop/items/34/view)
FG Dev Tools - Conversion Checker (https://forge.fantasygrounds.com/shop/items/100/view)

[pindercarl]

I've been seeing a lot of strange behavior with editing occluders lately. Not sure if it's from the last patch, or something earlier. I don't have solid repros for most of what I've been seeing, but I keep running into the following types of issues:


Intersection points not being properly created/added when drawing occluder rectangles over one another. Doesn't happen all the time.
When using the rectangle selection tool, points outside of the selection seem to be added to the selection but not being visually marked as selected. After deleting, undoing the delete, and then reselecting, it works fine.
When hitting enter to clear the selection or finish a group action, previously deleted points come back, or unrelated lines between points get deleted (I have a video of this one (https://1drv.ms/v/s!AhrZz9P9Tf8FoKpkc-xwcE7WfeRifA?e=7Z4o3R)). In this video I do a rectangle selection of two points, use ctrl-arrow to move the points up a few pixels, and then hit enter to finish the operation and deselect the points, which then deletes an unrelated line and causes some previously deleted points to reappear.



Is anyone else seeing these kinds of issues or is it just me? I feel like the occluder editing code needs a good solid code review.

I had two extensions loaded:
CSV Table Importer (https://forge.fantasygrounds.com/shop/items/34/view)
FG Dev Tools - Conversion Checker (https://forge.fantasygrounds.com/shop/items/100/view)

Thanks for the video. I was able to reproduce from that information.

[Artimer1]

I am also having weird occluder issues similar to what is seen in that video darennan. For me, when I select some occluders, and click to simplify them, they do get simplified, but when I deselect the ones that are still there to move on to do something else, more occluders populate along the existing lines than had been deleted from the simplification. Also, I drew a circle of occluders with the circle tool, which was made of approximately 40 occluders. When I try to move just one occluder in the circle out of place after the circle had been drawn, I have like 300 new occluders randomly fill in my circle towards the bottom. Haven't yet found any mention of this behavior outside of your post.

Any advice on how to make this not happen would be greatly appreciated

[Moon Wizard]

Do you have a video of what you are experiencing? Seeing the exact steps is very useful to figuring out what is going on.

Regards,
JPG

[Artimer1]

Do you have a video of what you are experiencing? Seeing the exact steps is very useful to figuring out what is going on.

Regards,
JPG

Yeah here it is (I am just showing what happens when I move a point, trying to select them is being kind of slow) https://www.loom.com/share/9d32a1b9d054437aa28570173f160129

[LordEntrails]

Interesting video, my first assumption is that it looks like their are multiple copies of the circle and other elements on the same place. By chance did you import the LOS elements from something like Dungeon Draft? Or did you create it yourself and can test that you did not create duplicates?

[Artimer1]

Interesting video, my first assumption is that it looks like their are multiple copies of the circle and other elements on the same place. By chance did you import the LOS elements from something like Dungeon Draft? Or did you create it yourself and can test that you did not create duplicates?

I did not import the LOS, they were made by me on this map. I also created the map with assets from FG map packs. There are other layers with LOS on them though. I just created a new map with only one layer of LOS, and a similar thing is happening, but, since there is only one layer, I have noticed that new nodes only show up when two lines of LOS cross each other newly after moving an LOS node. The new nodes are created on the new intersections of LOS lines.. is this a glitch or is this supposed to happen?

[LordEntrails]

New nodes on intersections is intentional. It's so that the segments can be trimmed etc.
I know it can be annoying at times when trying to move things and not cause them, but generally it is a good thing to avoid unintentional tiny gaps.

[bice56079]

It is well established that there are LoS issues (even with perfect LoS setup on a map). Hopefully, these will get fixed by SW but no matter what you do it is entirely possible for a los issue.

[Artimer1]

New nodes on intersections is intentional. It's so that the segments can be trimmed etc.
I know it can be annoying at times when trying to move things and not cause them, but generally it is a good thing to avoid unintentional tiny gaps.

Okay, thanks for the insight LordEntrails!

[Mike Serfass]

Granted, sometimes new points appear because it's not apparent that two lines are overlapping or how they're crossing. However, I've had points just appear on a simple circle that are not touching any other occluder. I'm also experiencing the behaviors that darrenan and Artimer1 are. They happen somewhat regularly.

[pindercarl]

I did not import the LOS, they were made by me on this map. I also created the map with assets from FG map packs. There are other layers with LOS on them though. I just created a new map with only one layer of LOS, and a similar thing is happening, but, since there is only one layer, I have noticed that new nodes only show up when two lines of LOS cross each other newly after moving an LOS node. The new nodes are created on the new intersections of LOS lines.. is this a glitch or is this supposed to happen?

I would be helpful if you could provide a copy of the campaign from the video. You mention that there are other layers with LOS on them. Occluders on hidden layers are considered when inserting points at occluder intersections. As mentioned, the new points are created intentionally. The algorithm does not allow for crossing occluders, so the points are added at intersections.

[jharp]

There is also the situation that when you import LoS it doesn't always fix overlaps until you select points that cause it to consider the overlap. I've found the best process for initial LoS import is to select all points with a click-drag box. This will "fix" a lot of situations on LoS.
Jason

[pindercarl]

There is also the situation that when you import LoS it doesn't always fix overlaps until you select points that cause it to consider the overlap. I've found the best process for initial LoS import is to select all points with a click-drag box. This will "fix" a lot of situations on LoS.
Jason

What's the method you are using to import LOS data? Perhaps we can address the problematic intersections at that time.

[jharp]

The data is imported by image import with XML file.
Jason

[pindercarl]

The data is imported by image import with XML file.
Jason

Got it. The XML file is exported from external mapping software.

[jharp]

Got it. The XML file is exported from external mapping software.

Yes. So I suspect that during the import no verification is done. Thus when I highlight all points a bit of verify / correct is done. I just deal with it that way and it seems to work.

Jason

[pindercarl]

Yes. So I suspect that during the import no verification is done. Thus when I highlight all points a bit of verify / correct is done. I just deal with it that way and it seems to work.

Jason

Can you provide an example of the data exported? I'd like to add the verification, but we don't want to add to the load time of modules that are developed internally.