PDA

View Full Version : CoreRPG Bug Report - Extraneous Code?



Minty23185Fresh
April 24th, 2022, 14:38
I apologize if this is in the wrong forum.
I couldn't find a "Bug Reports" subforum under CoreRPG, as one can for 5E and some other rulesets.

I believe there is extraneous code in the CoreRPG file:
...\rulesets\CoreRPG\common\scripts\number_linked. lua

In the CalculateSources() function at line 19 (as of this date) there is the statement:


local c = 0;


The variable, c, is incremented in line 36, but as far as I can tell, c, serves no other purpose.
It's simply extraneous code.
If it has purpose please explain what it is.

[EDIT] Smiteworks developers who might read this please see post #2 & #4 also

Thanks for listening.

Minty23185Fresh
April 24th, 2022, 16:28
Actually, at line 47, it appears as though the parameter is extraneous in


function onSourceUpdate(source)


(I've seen extraneous parameters before in other script and didn't bother to report it, but I am mentioning it this time because of post #1)

Trenloe
April 24th, 2022, 16:42
I apologize if this is in the wrong forum.
The laboratory is for beta testing FG releases. Please don't post here unless you're having issues with code in the test channel.

Minty23185Fresh
April 24th, 2022, 16:56
And in code somewhat related (since I'm in the area)

I believe there is extraneous code in the CoreRPG file:
...\rulesets\CoreRPG\common\scripts\number_modifie r.lua (different file than that mentioned in posts #1 & #2)

At line ~44 (the approximation is because I have so many Debug.console calls in the file):


function updateModifier(source)

Minty23185Fresh
April 24th, 2022, 16:58
The laboratory is for beta testing FG releases. Please don't post here unless you're having issues with code in the test channel.

Trenloe, would you please help me out, since I'm obviously confused, where would you like this posted?

LordEntrails
April 25th, 2022, 00:17
MOD: I'm going to pick the House of Healing. Ive seen these types or reports before, and not sure if they were there, or the Workshop. But this will get us closer :)

Moon Wizard
April 25th, 2022, 01:01
Probably the Workshop is best for these sort of reports.

However, for unused code, there is no urgency to change the scripts as they have been working for years, and I usually only look at those items when I rewrite sections.

Regards,
JPG

Minty23185Fresh
April 25th, 2022, 04:18
Thank you Lord Entrails and Moon Wizard, I’ll try to keep these two destinations in mind.