PDA

View Full Version : DR stacking incorrectly in PF1 ruleset



Callum
March 30th, 2022, 22:56
In tonight's game, we noticed that where PCs had multiple sources of DR on the Combat Tracker, the sum of all of them was being subtracted from incoming damage, rather than the single largest value. I'm running FGU v4.1.16 and using the Pathfinder 1E ruleset, with four extensions from the Forge: Token Height Indicator (https://forge.fantasygrounds.com/shop/items/67/view), PF Effect Removal Extension (https://forge.fantasygrounds.com/shop/items/407/view), Spell Formatting (https://forge.fantasygrounds.com/shop/items/30/view) and Upgrade NPC Actions (https://forge.fantasygrounds.com/shop/items/35/view).

I've now tested this in a new campaign, with no extensions, and the same thing happens (see attached screenshot).

52230

Moon Wizard
April 1st, 2022, 00:02
There's no current mechanism in the code to determine whether DR elements are the same or separate; so DR effects do not support stacking.

Regards,
JPG

Zarestia
April 1st, 2022, 00:29
This extension should fix the DR stacking issue. Getting this into the real ruleset would of course be better but is of course an undertaking I can't fathom.

https://forge.fantasygrounds.com/shop/items/1/view

Callum
April 1st, 2022, 14:44
There's no current mechanism in the code to determine whether DR elements are the same or separate; so DR effects do not support stacking.

Regards,
JPG
Thanks for your reply, JPG - unfortunately, I don't understand it! How can "DR elements" be the same? Aren't two different effects in the Combat Tracker "separate"?

Callum
April 1st, 2022, 14:45
This extension should fix the DR stacking issue. Getting this into the real ruleset would of course be better but is of course an undertaking I can't fathom.

https://forge.fantasygrounds.com/shop/items/1/view

Thanks, Zarestia - I'll give it a go. That extension looks quite complex, though, with lots of other stuff in.

DCrumb
April 1st, 2022, 22:35
Thanks for your reply, JPG - unfortunately, I don't understand it! How can "DR elements" be the same? Aren't two different effects in the Combat Tracker "separate"?

From my understanding of the code, it iterates through each effect, but doesn't remember any prior effects, so it will apply the DR for each effect separately. Thus it would be up to an extension, as listed, or up to the players and GM to watch out for any potential stacking violations.

Vhok
July 8th, 2023, 09:29
this is still an issue. i have an animal companion with 2 different types of DR, its going to be very annoying to manually adjust his health after every hit. can this please get fixed?

srbongo
July 8th, 2023, 12:37
this is still an issue. i have an animal companion with 2 different types of DR, its going to be very annoying to manually adjust his health after every hit. can this please get fixed?

You're going to have to use the extension listed above, or another one, in order for it to affect it. As @Zerestia said, it's a pretty large undertaking to get it into the base code. To be fair, the extension is quite good, worth it, and free.

Vhok
July 8th, 2023, 14:17
my gm did get the extension but it has so much other stuff in it also. i don't like it when people go "its a huge undertaking to do this" when its been years and the person who did make the extension did it and he's just a random guy.

i feel like this post comes off a bit rude and i don't mean it that way just not sure how else to word it, so adding this on after.

LordEntrails
July 8th, 2023, 20:17
Make sure it is on the wish list. And then remember that there are thousands of requests for the developers. They have to prioritize those. And I suspect most things that already have community extension solutions are probably not prioritized very high. They tend to develop those things that have the "most bang for the buck" or can't be done with community extensions.

srbongo
July 9th, 2023, 00:36
i feel like this post comes off a bit rude and i don't mean it that way just not sure how else to word it, so adding this on after.

Hey no worries, I get you. No offense here and I actually agree with the sentiment (even if I think it's going to be tough).