[BRP] Skill roll modifier bug has been reinstated

[peterb]

Hello,

Last December a long time bug in the BRP ruleset was fixed. When modifying a skill roll, the modifier should not modify the actual dice roll, it should modify the target value (i.e. the skill level). The same goes for attack rolls.

For example, the code for "Attacks" used to look like this after the change in December:


function action(draginfo)
local nodeChar = window.windowlist.window.getDatabaseNode()
local rActor = ActorManager.resolveActor(nodeChar);

local sModDesc, nMod = ModifierStack.getStack(true);
local rAttack = {};
rAttack.baseattack = getValue() + nMod;
rAttack.label = window.name.getValue();

ActionAttack.performRoll(draginfo, rActor, rAttack);
return true;
end


Now it looks like this:


function action(draginfo)
local nodeChar = window.windowlist.window.getDatabaseNode()
local rActor = ActorManager.resolveActor(nodeChar);

local rAttack = {};
rAttack.baseattack = getValue();
rAttack.label = window.name.getValue();

ActionAttack.performRoll(draginfo, rActor, rAttack);
return true;
end


Skill rolls are pretty central to BRP so I would appreciate if you put back the code that makes skill work as they should.

Thanks,
Peter

[Moon Wizard]

I just pushed an update to the Test/beta channel with some adjustments to the BRP rolling code. All of the d100 rolls (ability, attack, skill, powers) have been adjusted to apply the modifier stack to the target, instead of the roll.

Regards,
JPG

[peterb]

I just pushed an update to the Test/beta channel with some adjustments to the BRP rolling code. All of the d100 rolls (ability, attack, skill, powers) have been adjusted to apply the modifier stack to the target, instead of the roll.

Regards,
JPG

Thanks!

/Peter