PDA

View Full Version : handleFactionDropOnImage function is not placing tokens at drop point



SilentRuin
September 7th, 2021, 06:11
It appears that handleFactionDropOnImage is now placing tokens offset from drop point relative to center of the current map. If I place near center of map it appears to place the tokens nearest the drop point. If I place them farther toward the edges of the map the offset where the tokens appear after dragging and dropping the CT faction icon to a point on the map becomes larger and larger.

Moon Wizard
September 7th, 2021, 15:12
Yes, a fix is in the works.

It's related to this thread:
https://www.fantasygrounds.com/forums/showthread.php?70324-4-1-5-image-onDrop-x-y-to-Token-addToken-x-y-draw-location-miss-match&p=618223&viewfull=1#post618223

The fix will be a return to the way that v4.1.4 calculated (for now); but a UI scale modifier is needed as well so a ruleset update is needed and I'm in the middle of a larger change that will be in Test channel soon.

Regards,
JPG

SilentRuin
September 8th, 2021, 18:32
Yes, a fix is in the works.

It's related to this thread:
https://www.fantasygrounds.com/forums/showthread.php?70324-4-1-5-image-onDrop-x-y-to-Token-addToken-x-y-draw-location-miss-match&p=618223&viewfull=1#post618223

The fix will be a return to the way that v4.1.4 calculated (for now); but a UI scale modifier is needed as well so a ruleset update is needed and I'm in the middle of a larger change that will be in Test channel soon.

Regards,
JPG

Thanks for the fix - I updated my override version of that particular function to mirror it (as I could not override it as the changes I required were imbedded in the middle of this function). Tested - works.

[My change is optionally guarded so if they turn it off it will call the original version of this function]