5E Trust Issues - Lock Character Sheets Extension

[damned]

Trust Issues for 5E locks key fields to prevent them from being accidentally modified during the game.

The GM can lock all sheets using /pclock and unlock them with /pcunlock or the GM can unlock sheets individually by clicking on that characters padlock icon on their character sheet.

Character sheets will have a padlock beside their name to indicate whether the sheet is locked or not.

This is the first public release and locks the following fields:


All Abilities
All Saves
Proficiency
Max HP
Perception
All Skills (misc field)
Coins



Find it here: https://forge.fantasygrounds.com/shop/items/104/view

Please post any issues below and any requests.

[damned]

reserved

[FyreM]

opening a 'fresh' 5e campain, the only extention loaded is Trust issues....
-- in settings there is an entry for :
PC: INSPIRATION SLOTS <standard/2/3/>
no matter what the setting, however, any PC Character sheet shows 3 Inspiratiion slots.

https://imgur.com/a/mbEN2dP.jpg

[damned]

Thank you - Ill investigate that tonight and report back.

[damned]

Ive uploaded a new build and set it to Live. I think there is still some manual process that SmiteWorks do before you will receive the update but it should be coming soon...

[FyreM]

Checked for updates, and yep, your patch is live.
and yes, it is fixed.

[damned]

Update today also locks coins. This was harder than expected so holler if you have any issues.

[SmackDaddy]

Update today also locks coins. This was harder than expected so holler if you have any issues.

Rock on!!! LOL sly players could nudge their amounts in a direction and I've had to take screenshots at the end of each session to be sure I *know* what they are starting with "just in case" -- LOL thank you for this!

[Schneiderpants]

Only works for 5e? My groups plays PF1E and slight changes have been made without my knowledge a few times.

[damned]

Only works for 5e? My groups plays PF1E and slight changes have been made without my knowledge a few times.

At this stage its 5E only. I have not had a lot of requests for it for other systems.

[damned]

Sorry guys this wont be patched till Sunday 6th.

[damned]

I cant lock coin fields anymore - at least not at this time.
Extension has been updated on the Forge.

[nephranka]

Looks to be a conflict with Winnowing Pursuits and this ext. The search in their ext is not working when both are loaded. I will be posting in that thread as well.

[anathemort]

There's not much I can do about this because I don't have this extension. @damned you can see all my code in the repo here (https://gitlab.com/anathemort/FGWinnowingPursuits); if you'd like to collab on a solution feel free to reach out here or on Discord (anathemort#5773).

[damned]

The issue is we are both adding a script file to the windowclass charsheet_inventory

Im adding:

<script>
function onInit()
update();
end
function update()
local nodeRecord = getDatabaseNode();

local bReadOnly = WindowManager.getReadOnlyState(nodeRecord);
end
</script>

Only one is going to work...

[nephranka]

Thanks for looking into this. This sounds like a deal breaker? Meaning I can use one or the other but not both?

[anathemort]

The issue is we are both adding a script file to the windowclass charsheet_inventory

Im adding:

<script>
function onInit()
update();
end
function update()
local nodeRecord = getDatabaseNode();

local bReadOnly = WindowManager.getReadOnlyState(nodeRecord);
end
</script>

Only one is going to work...

damned, wouldn't it work if you called super.onInit()? This is what I did for compatibility with the core stuff on another window. Example here (https://gitlab.com/anathemort/FGWinnowingPursuits/-/blob/master/src/scripts/inventory_search.lua#L5-8).

[damned]

Yes you are right. Updated now.

[anathemort]

Yes you are right. Updated now.

Thank you! @nephranka can you verify compat for us?

[nephranka]

Thank you! @nephranka can you verify compat for us?

Looks good here. Working normal. Thank you both!

[jptheronmd]

Hi there, thank you for the mod, its really cool. Picked up a problem recently. Here is the screen shot of the error. Only occurs when I open an inventory page. Screen shot of inventory page and the error log.

[damned]

What are the other extensions running?
It looks like there are some other character sheet changes in effect there?

[jptheronmd]

What are the other extensions running?
It looks like there are some other character sheet changes in effect there?

Yes there are. I think that is the issue. I was trying to figure out exactly which one is causing the conflict but cant. The main one I am using is mad nomad's. I will try to find out which one and then let you know.

Seems to be MNM Character Sheet Tweaks, but only when used together with Constitutional Amendments. When either mod is used alone (without the ext to make them work together) there is no error. As they are run together with the additional extension then the error occurs.

[austintatious]

Hi there, if you are still taking suggestions, I've run into players tweaking the dex modifier in the armor calculation, which modifies their AC

52586

[Minty23185Fresh]

damned, Regarding our extension conflict issue…. I’ve been looking into the solution (https://www.fantasygrounds.com/forums/showthread.php?73557-Is-the-quot-expanding-rectangle-quot-of-relation-quot-relative-quot-anchoring-a-dynamic-anchor) I mentioned in another post.

I’m wondering if we want to change tactics, and use an icon cycler control up there. When extensions load they’d look for an icon cycler control up there, load one if it’s not there and “register” their icon in the controller. If that won’t work, maybe we need a “icon tray” underneath the name?

I’m traveling starting tomorrow. Won’t be back for 10 days. No access to PCs. Phone only.

[nephranka]

Yes there are. I think that is the issue. I was trying to figure out exactly which one is causing the conflict but cant. The main one I am using is mad nomad's. I will try to find out which one and then let you know.

Seems to be MNM Character Sheet Tweaks, but only when used together with Constitutional Amendments. When either mod is used alone (without the ext to make them work together) there is no error. As they are run together with the additional extension then the error occurs.

I have something similar with MNM character sheet tweaks ext. If they are run together the lock will not allow you to change its state. If it is unlocked, you can't lock it and vise versa.

[celebrindal]

At this stage its 5E only. I have not had a lot of requests for it for other systems.

Nuther bump for PF1E

[Iron Tyrant]

Great .ext I got it from the Forge!

Would be great if you could avoid players to add/change spells, actions numbers and LEVELUP boxes.
Yep really trust issues here.

[damned]

What are action numbers and levelup boxes please?

[Iron Tyrant]

What are action numbers and levelup boxes please?

Like the ability to change an action script modifier from Actions (like Shortsword: Dex mod+prof+misc) and so on.

Levelup: the clickable box near XP where you level up a PC in the sheet.

Can thoose be blocked by Trust Issues? Is it possible to develop some sort of restriction?

[nephranka]

Hello! I am not sure if you have seen the changes on TEST but this ext is throwing errors due to the changes to sheet. I know it is early but I thought I would pass it along in case.

[damned]

Thanks for the Heads Up. I have not had a look at TEST yet - will do so very soon.

[nephranka]

Have you been able to look at the changes now they are live?

[damned]

Updated just now [B]nephranka/B] - let me know if you find any more issues

[nephranka]

I will take a look and report back. Thank you.

[nephranka]

Looks like we still have an issue. When you click the actions tab you get iadd error multiple time. Clean campaign 5e only this ext loaded.

[damned]

Damn. That was some experimental code that should not have been there.
New build is uploading now and will be ready in 5mins.

[nephranka]

Damn damned! You got it. Thanks!

[BushViper]

@damned I have your extension and the /pclock and /pcunlock commands still 'work' according to the chat, but the character sheet no longer has the padlock. The padlock has been an issue for me for awhile as I couldn't ever click on it to lock/unlock the sheets as intended, but now it's completely vanished.

Is that because I'm using Sir Motte's theme?

[LordEntrails]

@damned I have your extension and the /pclock and /pcunlock commands still 'work' according to the chat, but the character sheet no longer has the padlock. The padlock has been an issue for me for awhile as I couldn't ever click on it to lock/unlock the sheets as intended, but now it's completely vanished.

Is that because I'm using Sir Motte's theme?
Most likely. Turn off the theme and see if the padlock comes back. If so, then let damned and Sir Motte know and then hopefully they can work together to resolve.

[BushViper]

Well, the good news is that it's not the theme, but the bad news is I have no idea which extension is causing the issue and I have a session tonight so the troubleshooting will have to wait.

[SmackDaddy]

Aside from also not seeing the lock shown on the character sheets, I keep getting this in my console over and over (not sure if the 2nd and 3rd lines are from Trust Issues, but the rest are and I have the most current version loaded):

[8/6/2022 8:21:47 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:04 PM] [WARNING] window: Anchored static height ignored for control (filter_lbl) in windowclass (charsheet_actions)
[8/6/2022 9:04:47 PM] [WARNING] window: Anchored static height ignored for control (filter_lbl) in windowclass (charsheet_actions)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)

[damned]

The Padlock is anchored as follows:


<anchored position="insidetopright" offset="0,25" width="20" height="20" />

Perhaps other extensions are doing something to cover it up or in some other way effecting the positioning.

As to the sources/handler error - I dont do anything with handlers and AC sources.
I have made a tweak to remove some more code from the extension but it may still be conflicting with other extensions.

If you see the console below there are no warnings or errors with Trust issues loaded.
You can also see the positioning of the padlock since the CoreRPG changes recently.

BushViper can you post a screenshot of your character sheet?



53880

[BushViper]

Sure. 53881

[BushViper]

[8/6/2022 8:21:47 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)
[8/6/2022 8:22:19 PM] [ERROR] Handler error: [string "ac"]:15: attempt to index global 'sources' (a nil value)

I get that error as well, but I think it's from MNMs Character Sheet Tweaks, but I haven't taken the time to confirm it yet.

[Zarestia]

[8/6/2022 8:22:04 PM] [WARNING] window: Anchored static height ignored for control (filter_lbl) in windowclass (charsheet_actions)
[8/6/2022 9:04:47 PM] [WARNING] window: Anchored static height ignored for control (filter_lbl) in windowclass (charsheet_actions)

Filter_lbl should be from Winnowing Pursuits.

[damned]

The map/pin icon looks like it maybe sitting over the lock icon or it might be behind inspiration...

[damned]

Ive pushed a new build that contains 2 extensions

You should only load one or the other. The second extension is called 5E Trust Issues - Alt. This positions the padlock elsewhere.

[BushViper]

The map/pin icon looks like it maybe sitting over the lock icon or it might be behind inspiration...

Yep, I think so too. I noticed it when I uploaded the screen. However, for me in the past, the padlock was always off to the left of the Inspiration marker.

[damned]

Yep, I think so too. I noticed it when I uploaded the screen. However, for me in the past, the padlock was always off to the left of the Inspiration marker.

Did the Alt version work for you?

[BushViper]

Did the Alt version work for you?

I've been away from home all day. I'll check it tonight.

[nephranka]

I am using MNM tweeks and coin manager with either of the trust issues ext and I not seeing the lock.

[BushViper]

I'm fairly confident that the extension causing the conflict is MNM's Character Sheet Tweaks.

[BushViper]

Did the Alt version work for you?

Just checked, and no, it's still the same.

I'm checking now to see if my suspicion about MNM CST is correct.

**EDIT**

Yep, it's definitely Mad Nomad's Character Sheet Tweaks that is blocking the padlock.

[nephranka]

I can confirm the conflict with MNM tweaks.

[damned]

Im sorry guys - I dont have MNM Tweaks.

[johnshep]

This ext causes a list of errors to come up, will it be fixed or updated?

[nephranka]

MNM might help out if you are able to talk dev to dev. Not to put any more work on you but I have found devs are more likely to work with other devs than just us users ;)
Just a thought.

[damned]

This ext causes a list of errors to come up, will it be fixed or updated?

You will need to provide some actual information. I dont see any errors when loading this extension on 5E.

[damned]

MNM might help out if you are able to talk dev to dev. Not to put any more work on you but I have found devs are more likely to work with other devs than just us users ;)
Just a thought.

It looks like MNM Tweaks is completely rewriting the common section of the character sheet. This is going to make it very hard to be compatible with other extensions that operate in that area.

[damned]

MNM might help out if you are able to talk dev to dev. Not to put any more work on you but I have found devs are more likely to work with other devs than just us users ;)
Just a thought.

Also your screenshot looks quite different to the Bushviper one?
Bushviper is also running a theme on his screenshot?

[nephranka]

Yeah. No theme for me but no lock as well. MNM tweaks does move a lot around on the sheet, so I am not surprised it is an issue. MNM is usually pretty good at helping other devs to fix compatibility issues. I will pop over to his discord to let him know what is going on.

[Mad Nomad]

First off, make sure you are using the MNM tweaks extension from the forge. I made some big updates after the recent FGU updates to fix compatibility. Since I haven't heard about this before, I suspect it probably is addressed with that, but i could be wrong.
If that's not it, I am guessing there might be issues with relative positioning and the like that may be causing the compatibility issues. Because of the kinds of changes I was making, I had to do some extensive adjustments to the xml. I have a backlog and can try to take a look at it in near future. I will also send a copy of the extension over to damned to see if there might be an easy fix he can find.

[nephranka]

First off, make sure you are using the MNM tweaks extension from the forge. I made some big updates after the recent FGU updates to fix compatibility. Since I haven't heard about this before, I suspect it probably is addressed with that, but i could be wrong.
If that's not it, I am guessing there might be issues with relative positioning and the like that may be causing the compatibility issues. Because of the kinds of changes I was making, I had to do some extensive adjustments to the xml. I have a backlog and can try to take a look at it in near future. I will also send a copy of the extension over to damned to see if there might be an easy fix he can find.

Yep. I am up to date. Here is the screen I supplied earlier in the thread. Is v7 not the most recent? Tweaks on = no lock. Tweaks off = lock.

Thanks for helping out. I am hopeful it is an easy fix.

[damned]

Mad Nomad has sent me a copy of his extension. Ill look at it over the weekend.

[nephranka]

Mad Nomad has sent me a copy of his extension. Ill look at it over the weekend.

Cool! Thank you.

[spencerg]

love this extension and cannot believe this isnt baked in. The fragile nature of the character sheets always surprised me. One problem though -- no extensions - new campaign - locked sheet - I can edit proficiency and AC. Known issue>?

54412

54413

I wish everything was locked down. Can't tell you how many times someone has unintentionally toggled something on/off they shouldn't have, and we wound up playing incorrectly. Its not really an issue of trust with my players, as it is with just accidental breaking a stat.

There has got to be better ways to keep the sheet unbroken apart from exporting and crosschecking.

Versioning anyone? Revert changes?

Anyways,

I was expecting 'lock' to mean, they can't toggle proficiency, ctrl+scroll up modifiers, ect. ect.

Any advice is much appreciated.

[spencerg]

Mad Nomad has sent me a copy of his extension. Ill look at it over the weekend.

was just going to report the same thing :)

Also, post below has some images
this extension is exactly what i was looking for. As it stands, im not so much concerned about it working with MN sheets, as i am wanting it to lock down toggling proficiencies and some of the other fields. As it stands now, it’s allowing you to modify a few things that are listed as lockout. Tested on clean campaign. bravo on this ect, such a headache preventer. I keep a close eye on the sheets because it’s so incredibly easy to modify things you shouldn’t have. This should honestly be baked into the core. Let me know if u need additional info or help testing.

cheers !

ps. didnt you just post an action economy tracker ;) on fire

[spencerg]

Mad Nomad has sent me a copy of his extension. Ill look at it over the weekend.

Last time i checked with a clean environment, i was still able to toggle proficiency, saves, skills … but abilities did lockout. Is this something you’re aware of? I tried going in to look at it myself, but for some reason, I can’t find the extension in the extensions folder.. even though i have it and it’s on. in any event, I don’t want to spam about it, but i think this is a hugely valuable extension that saves alot of stress. It so easy for a new player to break their sheet unintentionally, and right now i have to manually back up those fields to a doc, and cross check to make sure it’s right periodically. I screwed one up the other day, just one wrong click… lost proficiency. Any help greatly appreciated dammed,

and bravo on this great idea. Let me know if i can test provide feedback.

ps. Being logged in as DM wouldn’t change the way this behaves right? What i mean is im screwing with the character sheets as a GM host… would it matter?

[spencerg]

I didn't want to spam you Dammed, I'm just curious if you saw my message.

Is it intended behavior to

1) be allowed to toggle proficiencies on/off/expertise when locked?
2) be allowed to modify abilities?

What I was looking for was a way to lock down all of that, and I thought that's what this did. Its so easy to accidently toggle those off and not even notice it.

[damned]

Hi spencerg,

The Abilities (STR, DEX, etc) on Front Page are locked but not the Abilities lists on Abilities tab. Is there anything in there that players break?
Proficiency should be locked.

[spencerg]

Hi spencerg,

The Abilities (STR, DEX, etc) on Front Page are locked but not the Abilities lists on Abilities tab. Is there anything in there that players break?
Proficiency should be locked.

Hi Damned,

Should have clarified, I mean the abilities (str/dex) ect on front page. When i disable MN ui extensions the ability lock seems to work (even if i can’t see it in the ui i console command it /pclock

My biggest issue however is the proficiencies. I have a clean install, and i’ve tested with no extensions multiple times, and still i am able to toggle the proficiency (stars) on/off ect.

Is there any difference between me as a DM tested vs client? no matter what i do, it has never worked for me regarding proficiencies. It’s so easy to tick/untuck the star and break the character.. that’s why i prefer to have it locked.

thank you for your hardwork

[damned]

Please try and update again and report back.

[spencerg]

You fixed Proficiencies :)

However, I can still edit Abilities and toggle proficiency for saves :)

Its mad nomads u.i. extensions causing this.
I am a developer myself, and I tried poking around at the extension to see if i could hack a fix into it...but your extension doesnt appear in the extensions folder ? (just genuinely curious why)

In any event, here is the image - circled is the editable inputs I can modify.
I disabled MN character sheet edits, and sure enough, that solved the ability score being editable.
The only thing I'd ask for other than compatibility with MN character sheet, is too Lock the proficiency input next to saves.

Thank you Damned!

PS. I use world builder and love it, great extension!

55478

[damned]

Ive pushed another build.

[spencerg]

Ive pushed another build.


Awesome! Thank you very much

[Roach]

Was there a version that didn't have "Trust Issues" in the filename? I have it twice in my extension selection, and have it once through the Forge, but cannot find the second instance that is being loaded...

[damned]

Was there a version that didn't have "Trust Issues" in the filename? I have it twice in my extension selection, and have it once through the Forge, but cannot find the second instance that is being loaded...

I dont believe so. AFAICR it was only ever available on the forge.
Ahhh - there is now two builds in the same package. The second one is supposed to show up as 5E Trust issues - Alt and it just places the lock in a different position. Ill try and fix that naming. Thanks for pointing it out.

[damned]

Please update again and let me know if that is showing properly?

[Roach]

Yes. it now shows up with the "Alt" tag.
TBH, I wouldn't have noticed it if I hadn't had issues with other extensions that I originally got from DMG and later were moved to the Forge, so checked the whole list of "unused extensions" as well... (I don't have players that change their char sheets around, so there's no need for the extension for me.)

[damned]

I don't have players that change their char sheets around, so there's no need for the extension for me.

That is the best solution.

[nephranka]

Mad Nomad has sent me a copy of his extension. Ill look at it over the weekend.

Were you ever able to get this working with MNM?

[BushViper]

Were you ever able to get this working with MNM?

It's not currently working for me with either version.

[spencerg]

Yes. it now shows up with the "Alt" tag.
TBH, I wouldn't have noticed it if I hadn't had issues with other extensions that I originally got from DMG and later were moved to the Forge, so checked the whole list of "unused extensions" as well... (I don't have players that change their char sheets around, so there's no need for the extension for me.)

it’s isn’t just about “players who change their sheets”… it’s about accidentally changing something, which is extremely easy to do. Then, the DM has to fix it 99% of the time, thats IF he kept track of the previous value - was he proficient in this before? was it 14 or 15? Amplify this by all the characters and moving parts of a game… this is why this extension is important and why this functionality is actually baked into other rulesets like 2e ( they lock it down to prevent accidentally breaking things ) - 5e has a very loose u.i. and in my opinion that’s not good.. especially for the DM

[BushViper]

it’s isn’t just about “players who change their sheets”… it’s about accidentally changing something, which is extremely easy to do. Then, the DM has to fix it 99% of the time, thats IF he kept track of the previous value - was he proficient in this before? was it 14 or 15? Amplify this by all the characters and moving parts of a game… this is why this extension is important and why this functionality is actually baked into other rulesets like 2e ( they lock it down to prevent accidentally breaking things ) - 5e has a very loose u.i. and in my opinion that’s not good.. especially for the DM

This is the entire reason I use the extension. Before I started using it my players would often accidently change something and tell me, but half the time neither of us could remember what the original setting/number was.

[damned]

I have added a new build that adds another variant 5E Trust Issues - MNM for compatibility with Mad Nomads Character Sheet Tweaks.
There are now three versions that will show up - only select one please!

[Laerun]

When it comes to managing player character sheets on the Fantasy Grounds Unity VTT platform, some GMs may be concerned about unintentional or accidental changes that could occur. While adding more extensions to control and prevent such changes may seem like a solution, there is actually a simpler and more effective way to approach this issue.

By creating a backup copy of each player character's XML file before each level-up, you can easily prevent potential issues and provide more flexibility for players to use their characters in other games at different levels. Additionally, having a backup of each level provides you with a way to audit and review any issues that may arise during gameplay.

It is important to note that relying on only one copy of a character's XML file can be risky, as it leaves you vulnerable to losing important information if any issues arise. However, by making a habit of copying a character and renaming it with a naming convention that includes the level and any other relevant information, you can easily keep track of each iteration of a character's build.

In summary, using a backup system is a reliable and efficient way to manage player character sheets on the Fantasy Grounds Unity VTT platform. It eliminates the need for additional extensions and reduces the risk of potential complications.Making an copy of a character is very simple and quick.The GM will have a backup to compare quickly with a backup PC record.

[nephranka]

I have added a new build that adds another variant 5E Trust Issues - MNM for compatibility with Mad Nomads Character Sheet Tweaks.
There are now three versions that will show up - only select one please!

Thanks for this but I am not seeing the update on the forge.

[damned]

My mistake. Try again.

[nephranka]

My mistake. Try again.

Got it now! Thanks!

[BushViper]

Confirmed that this now works with MNMs ext.

Thank you.

[Retorus]

Greetings.
I tried to use your extension, but it doesn't block the character sheet and throws an error:

[ERROR] Handler error: [string "W:charsheet_overview"]:35: attempt to call field 'update' (a nil value)
Rules 5E. What could be the problem?

[damned]

Welcome Retorus

You will need to provide more information. When does the error occur? What actions preceded it? Can you share your db.xml and steps to reproduce? What other extensions are you runing?

[Retorus]

Uploaded logs to google drive and sent to PM.
To reproduce the error, you need to run the campaign, lock the character sheet and then open it.
Tried disabling all extensions that may affect the work of the character sheet - similarly.
db.xml is still needed or is there enough logs? If needed, where can I find it?

[damned]

Please try and unload Big Portraits and retest.

[Retorus]

This I tried. There are several launches of the campaign in the console.log file. At the very end there is a boot log with:

[4/21/2023 5:02:44 PM] EXTENSION: D&D Official Language Fonts\rfor Fantasy Grounds\rCopyright 2015 Smiteworks USA, LLC.\rD&D Copyright 2015 Wizards of the Coast LLC
[4/21/2023 5:02:44 PM] EXTENSION: Dungeons & Dragons Theme v1.0\rfor Fantasy Grounds\rCopyright 2015 Smiteworks USA, LLC.\rD&D Copyright 2015 Wizards of the Coast LLC.
[4/21/2023 5:02:44 PM] EXTENSION: Dungeons & Dragons, D&D, Wizards of the Coast, their respective logos, the dragon ampersand, all Wizards titles, the fifth edition rules, and Wizards' character names and distinctive likenesses are property and copyright of Wizards of the Coast LLC in the USA and other countries. Used with permission.
[4/21/2023 5:02:44 PM] EXTENSION: Extension (Fonts - Extended Languages) loaded.
[4/21/2023 5:02:44 PM] EXTENSION: 5E Trust Issues Version 1.3 20221216\r\nThis fan made extension created by Damned
[4/21/2023 5:02:44 PM] EXTENSION: Fen's NPC Portrait Workaround v2.2.2
[4/21/2023 5:02:44 PM] EXTENSION: Replace GM Icon v1.0, FGC/FGU\r10/18/22 Justin Freitas

[damned]

I just subscribed to Big Portraits. When I load both Big Portraits and Trust Issues I get the error. If I load only one or the other I do not get the error. They are both working in the same space as each other and changing some of the same things.

[damned]

In Big Portraits it is deleting one or more entries from 5E that Trust Issues is trying to extend.



<number_linked name="profbonus" merge="delete" />

[damned]

In Standard 5E the area in red is configured by one windowclass and the area in green by another - see Image 1.

https://www.fantasygrounds.com/forums/attachment.php?attachmentid=57111

Big Portraits moves some things from the green windowclass to the red windowclass - see Image 2. My script is looking for them in the red windowclass and cant find them so errors.

https://www.fantasygrounds.com/forums/attachment.php?attachmentid=57110

5711057111

[damned]

Trust Issues now supports Big Portraits.

[warelock]

I bought this extension, enabled locking, and players can still edit their character sheets. I tried all three variants of this extension. I either need this fixed or I need a refund.

[BushViper]

I bought this extension, enabled locking, and players can still edit their character sheets. I tried all three variants of this extension. I either need this fixed or I need a refund.

I'm not the creator, but the ext doesn't prevent the editing of every field. Is it not preventing the areas it says it stops or a field that it doesn't?

[Zacchaeus]

I bought this extension, enabled locking, and players can still edit their character sheets. I tried all three variants of this extension. I either need this fixed or I need a refund.

Welcome to the forums.

Can you be more specific please. As noted in the Forge description and in the first post in this thread only 'key' fields such as ability scores, saving throws etc are locked. Other parts of the character sheet (such as name, notes etc) can still be edited. Can you specify which fields that can be locked aren't being locked or what exactly it is you expect to be locked that isn't. Also are you testing without any other extensions loaded? It is possible that if this one isn't working it may be because some other extension is interfering.

[nephranka]

I note you can still change the coins by dragging a negative number from the modifier box to the coin amount with the lock on even though you can not directly edit the coin amounts.

[nephranka]

With the new update, the lock now overlaps the chat button.

[nephranka]

Also, there is an error when you try to change a value before unlocking then unlock the sheet.

[damned]

Please can you share your db.xml and ill have a look at this over the weekend.

[nephranka]

Please can you share your db.xml and ill have a look at this over the weekend.

Sure thing. Here is the db. You should see:

1. The lock icon is overlapping.
2. If you have the lock on you can still change money values using the modifier box and dragging values.
3. Go to the Skills tab and unlock. It should throw an error. If not then try changing a prof. This can happen on the inventory tab as well but not always.

Thanks for looking into it. Let me know if you need more information.

[damned]

It is very difficult to stop the modifier route without it impacting other drag and drop events.
I have added a message that the player has modified currency any time that occurs.
I have fixed the positioning.
Let me know how it goes.

[damned]

I bought this extension, enabled locking, and players can still edit their character sheets. I tried all three variants of this extension. I either need this fixed or I need a refund.

Sorry I missed your message.
You can refund in the Forge no questions asked for 30 days.
See the first post for what things are locked - everything is is not.

[nephranka]

It is very difficult to stop the modifier route without it impacting other drag and drop events.
I have added a message that the player has modified currency any time that occurs.
I have fixed the positioning.
Let me know how it goes.

The overlap is gone. I understand the modifier box but under testing no message was given. Will this just be a client side effect?

The error on the Skills tab it still happening.

[damned]

Please try again.

[nephranka]

No errors and I see the message on the client side. Thanks for getting this all working.

[nephranka]

Looks like this needs updating for the 2024 ruleset.

[BushViper]

Yep. Nomad pushed a bunch of updates and looks like there are some downstream consequences. 62186

[nephranka]

Any chance this will be fixed? It looks like errors on multiple tabs.

10/22/2024 5:56:57 AM] [ERROR] windowlist: Could not find windowclass ()

[10/22/2024 5:56:57 AM] [ERROR] Script execution error: [string "TrustIssues:..gn/scripts/char_skilllist.lua"]:43: createWindow: Unable to create window

[10/22/2024 5:56:57 AM] [ERROR] window: No vertical anchor defined for control (misc) in windowclass (char_skill_item)

[10/22/2024 5:58:05 AM] [ERROR] Script execution error: [string "TrustIssues:..gn/scripts/char_inventory.lua"]:25: attempt to index global 'encumbrancebase_label' (a nil value)

[10/22/2024 5:58:18 AM] [ERROR] Handler error: [string "W:charsheet_overview"]:33: attempt to index field 'contents' (a nil value)

[damned]

Im sorry I am having a lot of difficulty adapting the new character sheet changes.

[nephranka]

Im sorry I am having a lot of difficulty adapting the new character sheet changes.

No worries just checking in.

[PencerMan]

Any luck on fixing things?

[wigginshd]

Hey, love the extension! I'm just checking in on the bug reported above by nephranka.

[aelin339]

63322

Hey there i got differents errors, i dont know why? I use this for only 5e and it gives error with my game. i tried with a new game without any other ext but still gives errors

[aelin339]

that second error

[Moon Wizard]

Just pushed an update to the beta Test channel to support character sheet locking in the 5E ruleset as noted in the Laboratory forum. Scheduled for release in late February.
(It does not limit lock/unlock to GM; but does allow either GM or player to unlock/lock the sheet and all the fields will lock.)

Regards,
JPG

[damned]

Just pushed an update to the beta Test channel to support character sheet locking in the 5E ruleset as noted in the Laboratory forum. Scheduled for release in late February.
(It does not limit lock/unlock to GM; but does allow either GM or player to unlock/lock the sheet and all the fields will lock.)

Regards,
JPG

This is great news!

[dmbrown]

Very cool. Moon Wizard, maybe in the future there could be an option to have it where only the GM could lock/unlock?

[Gorwor]

Any news about this expansion?

[Moon Wizard]

What are you asking for exactly? I don't believe that the community developer is working on this extension any longer; and the PC sheet unlock/lock is included in several of the built-in rulesets now as well.

Regards,
JPG

[Gorwor]

I have been using FG for a few weeks as a GM for my players. Specifically, I am surprised by the following facts:
1) Players can very easily change anything in their character log without the change being recorded anywhere. An example is the inventory, where they can very easily change the number of anything, and it is practically impossible for the GM to find out. Yes, I understand that this is the same situation when playing with paper logs, but I would expect that this could be addressed in some way in a computer program.
2) What I find even stranger is the lock on items. I give the player an item, identified, with some parameters and a description that I create - and the player can unlock it and edit anything there. Again, without any possibility for the GM to influence this. What is the point of the lock icon if virtually anyone can edit and change this item record without restriction, including the parameters?

[Trenloe]

What I find even stranger is the lock on items. I give the player an item, identified, with some parameters and a description that I create - and the player can unlock it and edit anything there. Again, without any possibility for the GM to influence this. What is the point of the lock icon if virtually anyone can edit and change this item record without restriction, including the parameters?
The record lock is primarily to hide fields that don't have any data and also prevent accidental changes (clicking on cycler controls, etc.) it is not meant as a lock to prevent players changing data. As you mention, players in a face-to-face game can change anything on their character sheet, the same is the case in FG.

As a GM I'd expect my players to manage their characters - it would be a large overhead for me to have to also update PC sheets with relevant changes/additions. If you feel one of your players is being dishonest, then I recommend making a copy of their PC sheet before a session (drag/drop the PC within the character activation window and then right-click -> Take Ownership to stop the players seeing the copy). Then at the end of your session you can compare a before-and-after PC and address any issues with the player in question as needed.

[LordEntrails]

I have been using FG for a few weeks as a GM for my players. Specifically, I am surprised by the following facts:
1) Players can very easily change anything in their character log without the change being recorded anywhere. An example is the inventory, where they can very easily change the number of anything, and it is practically impossible for the GM to find out. Yes, I understand that this is the same situation when playing with paper logs, but I would expect that this could be addressed in some way in a computer program.
2) What I find even stranger is the lock on items. I give the player an item, identified, with some parameters and a description that I create - and the player can unlock it and edit anything there. Again, without any possibility for the GM to influence this. What is the point of the lock icon if virtually anyone can edit and change this item record without restriction, including the parameters?
Welcome to the forums :)
I get it. I know where you are coming from. And some GM's prefer to have more rigid control/visibility. Because FG doesn't have it, some GM's will export or copy their players' character records after each session so they can compare them.

The lock icon is there to prevent accidental changes. Not intentional changes.

I don't have your concerns, because I don't play with folks that I don't trust. And as well, I don't care what the players do or have because we are all there to have fun and I'm fortunate enough to play with like minded folks.

Back in the paper and pencil days, I had a few campaigns where we played with folks who cheated, or as they probably thought, altered reality to fit their imagination. Those groups didn't last long and those players were left out when new campaigns formed.

I'm sure some other folks will chime in with ideas to help you out. I guess my only advice is to try and not let it worry you if players alter things wrong and if they do consider handling it out of character.

[Gorwor]

Changing the lock on an item so that only the GM can control it seems so basic to me that it is completely beyond my comprehension that it does not work that way in the default settings.

[Moon Wizard]

Because the unlock turns on a bunch of UI elements to be able to delete list items and sub-records as well as block being able to create or level up your character in addition to just allowing specific field edits; so it does a lot more than just lock down fields. The current unlock/lock is to allow players to have full editing capability; while keeping the sheet generally locked (such as during play) to prevent accidental changes.

The sheet lock is not the same as a "GM lock down" on the character sheet; and is a different feature than what you are asking for.

You can suggest/vote on feature requests in my signature below.

Regards,
JPG

[Gorwor]

But I'm talking about the lock on the item sheet, not on the character's journal. Editing items should be entirely in the hands of the GM—and only if it's a modifiable item (a book, for example) does it make sense to unlock such an item for the player themselves so that they can further modify its contents (description, price, weight, etc.).

[LordEntrails]

But I'm talking about the lock on the item sheet, not on the character's journal. Editing items should be entirely in the hands of the GM—and only if it's a modifiable item (a book, for example) does it make sense to unlock such an item for the player themselves so that they can further modify its contents (description, price, weight, etc.).
Same, because lock hides blank fields and prevents accidental change.
Their is no intent to prevent players from changing/editing anything that is on their character sheet.
If they change the properties of an item on their character sheet, they are only changing that instance of the item. It does not change the master version that the DM has in their library list.

If you desire that functionality, then please add it to the Feature Request list in Moon's signature so the community can vote on it.

[Trenloe]

Changing the lock on an item so that only the GM can control it seems so basic to me that it is completely beyond my comprehension that it does not work that way in the default settings.
That's expectation vs different functionality - you're expecting completely different functionality than what has been implemented. As has been explained a few times now in this thread, the item lock is not a GM lock, it is a lock that makes the record read-only/editable by anyone who owns the record - it also hides empty fields to make the record view more streamline. This is the same functionality for all FG records, not just items - the lock controls read-only & hide empty fields vs. edit mode, it is not a GM lock. As was mentioned by Lord Entrails - item (and other record) data is copied to a character sheet and the player takes ownership of that data, and can edit that data only on the PC sheet.