PDA

View Full Version : CoreRPG Party Item Weight



bmos
June 11th, 2021, 18:25
This extension adds a weight total to the party inventory and to treasure parcels.

Extension Homepage, README, and Codebase (https://github.com/bmos/FG-CoreRPG-Party-Inventory-Weight)
FantasyGrounds Forge (https://forge.fantasygrounds.com/shop/items/18/view)
Ext Files and Changelog (https://github.com/bmos/FG-CoreRPG-Party-Inventory-Weight/releases)
License Information (https://github.com/bmos/FG-CoreRPG-Party-Inventory-Weight/blob/master/LICENSE.md)
Bug Tracker and Suggestions (https://github.com/bmos/FG-CoreRPG-Party-Inventory-Weight/issues)

I publish most updates in my combo thread (https://www.fantasygrounds.com/forums/showthread.php?60308-bmos-extensions) (with only major updates in this individual thread which is primarily for discussion and bug reports). To ensure you're kept informed of future updates, either subscribe to that thread (for updates to all my extensions) or create a GitHub account and follow the specific repository of each extension you use. Or just check the releases linked in the first post of the thread periodically.

bmos
June 11th, 2021, 18:46
Screenshot as an example:
https://user-images.githubusercontent.com/1916835/123844723-5ded3500-d8e1-11eb-8c63-8cc0c04ee77e.png
https://user-images.githubusercontent.com/1916835/123844744-634a7f80-d8e1-11eb-99d5-b71bf28f1fcc.png

Zarestia
June 11th, 2021, 22:54
Nice new extension :)

Just two quick question:
- Do the players & the DM both see this?
- Does it include the weight of unidentified items?

bmos
June 12th, 2021, 02:46
Nice new extension :)

Just two quick question:
- Do the players & the DM both see this?
- Does it include the weight of unidentified items?GM-only and yes it does

EDIT: should it be player visible also?

Khoredran
June 13th, 2021, 14:44
I tried it for the first time in my Live game yesterday and I got several errors during play with this. I wonder if I did something wrong?
The party weight stayed at 0 no matter how many items I was adding to the party sheet.
This was on PFRPG1 ruleset.

47559
47560

bmos
June 13th, 2021, 20:26
I tried it for the first time in my Live game yesterday and I got several errors during play with this.Hmm. Sorry about that, but thanks for the bug report.
We're you using it with CoinWeight or not?

EDIT: nevermind, I realized the problem. I have to post a new version of Coins Weight which includes a change allowing other extensions to access the denominations defined in it.
EDIT2: Coin Weight v1.5 (https://github.com/bmos/FG-CoreRPG-Coins-Weight/releases/tag/v1.5) has been posted.

Sudain
June 15th, 2021, 06:07
I noticed that it only does two digits, and so anything above that (or with decimals) aren't displayed fully. Is that expected behavior?

47603
47604

Thank you for this extension! :)

bmos
June 15th, 2021, 12:45
I noticed that it only does two digits, and so anything above that (or with decimals) aren't displayed fully. Is that expected behavior?

47603
47604

Thank you for this extension! :)Ah, I suppose I should move it somewhere where there is more space for more digits and also do some rounding. Thanks.

kevininrussia
June 17th, 2021, 18:03
I also noticed not having enough room for the weight when more then 2 characters. I am using the Winter Theme. I also noticed there is an "Lb" at the top of the list. Is this the new area you plan on adding the weight?

https://i.imgur.com/bRsqaqH.png

kevininrussia
June 17th, 2021, 18:08
I deleted two items which should have lowered the weight total but the removed items was not deducted from the weight. 4E ruleset.

https://i.imgur.com/KpLyaq0.png

kevininrussia
June 17th, 2021, 18:13
Tested the item removal with no extensions loaded with 4E ruleset. Same issue. Added 50lb Plate Armor then removed. Still shows the weight amount.

https://i.imgur.com/jComU87.png

bmos
June 17th, 2021, 18:22
Added 50lb Plate Armor then removed. Still shows the weight amount.Ah! Forgot to add a handler looking for items/coins being removed. Thanks!

EDIT: posted a hotfix.

Merell
January 6th, 2022, 03:44
bmos I sent you a PM and tried to attach a JPG that apparently did not work. Here is a copy of the proposed modification I suggested. With even a miss spelling of Current.....

50788

bmos
January 6th, 2022, 15:18
bmos I sent you a PM and tried to attach a JPG that apparently did not work. Here is a copy of the proposed modification I suggested. With even a miss spelling of Current.....

50788Yeah, easy to add.
I'll put it on the list and hopefully can get to it pretty soon.

bmos
January 7th, 2022, 15:48
bmos I sent you a PM and tried to attach a JPG that apparently did not work. Here is a copy of the proposed modification I suggested. With even a miss spelling of Current.....

50788I didn't have time to pretty it up or automate anything, but here is a beta build you can manually install into your extensions folder that gives you a basic number field to keep track of that max weight limit.

kevininrussia
February 5th, 2022, 20:58
4E ruleset.
I'm getting an error when opening a parcel or trying to create a new one.
No other extensions loaded.

[2/5/2022 12:54:33 PM] RULESET: Dungeons and Dragons (4E) ruleset (v2021-11-15) for Fantasy Grounds
Copyright 2021 Smiteworks USA, LLC
[2/5/2022 12:54:33 PM] RULESET: Core RPG ruleset (v2022-01-04) for Fantasy Grounds
Copyright 2022 Smiteworks USA, LLC
[2/5/2022 12:54:33 PM] EXTENSION: CoreRPG - Party Item Weight v1.4\nFor Fantasy Grounds v4.1+\nBy bmos
[2/5/2022 12:54:33 PM] MEASURE: LOAD - PART 2 - 6.6223806
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (coinframe) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)
[2/5/2022 12:54:37 PM] [ERROR] window: Control (parcelweight) anchoring to an undefined control (contentframe) in windowclass (treasureparcel)

bmos
February 6th, 2022, 15:13
Thanks. I posted an update that fixes 4e and also adds color coding to make it more obvious when party inventory is beyond the max weight i added in the 1.4 beta.

NerdisaurusWrex
June 11th, 2022, 16:05
I have v2 of your Coin Weight extension added too, but the coins in the Parcel don't register in the Total Weight box, and no Coins item shows up in the Parcel Inventory field. Am I doing something wrong?

bmos
June 11th, 2022, 21:38
I have v2 of your Coin Weight extension added too, but the coins in the Parcel don't register in the Total Weight box, and no Coins item shows up in the Parcel Inventory field. Am I doing something wrong?Thanks for pointing that out. Looks like I forgot to update this when I released the new version of Coins Weight.
I'm pushing a new version of this that doesn't even need Coins Weight anymore.

Tenebris
October 27th, 2022, 13:22
I am currently encountering an error with this extension in 2e whenever I add or remove items from the Party Sheet:

[ERROR] Handler error: [string "ty-Inventory-Weight:..ts/parcelweight.lua"]:22: attempt to index a nil value

I do have a number of other extensions, so it may be an issue of playing nice, but I just don't know enough about it to say one way or the other. Since it does seem to be originating from your extension, I thought I would put it on your radar.

Thank you for your many extensions! They are much appreciated.

bmos
October 27th, 2022, 22:18
I am currently encountering an error with this extension in 2e whenever I add or remove items from the Party Sheet:

[ERROR] Handler error: [string "ty-Inventory-Weight:..ts/parcelweight.lua"]:22: attempt to index a nil value

I do have a number of other extensions, so it may be an issue of playing nice, but I just don't know enough about it to say one way or the other. Since it does seem to be originating from your extension, I thought I would put it on your radar.

Thank you for your many extensions! They are much appreciated.Not seeing any issues testing it solo. As usual, first step is to remove all your other extensions and see if you can still reproduce the issue. If you can't, add back your extensions in groups or one at a time to figure out which one is incompatible.
If you can reproduce the issue without any other extensions loaded, please send me your campaign db.xml so I can track it down.

Azrael1337
June 13th, 2023, 17:43
EDIT: should it be player visible also?

I would like it if it would be visible to players too.
Maybe add a toggleable option for that?

Would that be possible to implement?

Azrael1337
June 18th, 2023, 23:07
Okay, did it myself by removing the <gmvisibleonly /> attribute from the ps_inventory.xml file :p

bmos
June 19th, 2023, 02:26
I've added that as a feature request. https://github.com/FG-Unofficial-Developers-Guild/FG-CoreRPG-Party-Inventory-Weight/issues/6
I'll take a look at it when I get a chance.