SFRPG List Sorting Bug...

[HoloGnome]

It looks like the SFRPG ruleset has a bug where it no longer alphabetically sorts items in any of the lists on the Abilities tabs. It affects both classic and FGU environments.

(Also, the item entry for this screen is now incredibly cumbersome. Please restore the ability to directly create items via right-click. If you make the client so hard to use that it is no longer easily usable for basic character entry, then that is somewhat of a disincentive to use it.)

[Evolivolution]

I cant reproduce this at all. My lists still get sorted alphabetically and I also can add items with right click. Please make sure to test this without any extensions and give some steps on how to reproduce this error.

[HoloGnome]

- No extensions loaded
- FG Classic or FGU

Steps to Reproduce Item Creation Bug:
1. Open SFRPG Classic 3.3.13 (for example)
2. Go to the abilities tab of a new character
3. Try to right-click to add an entry to Class Abilities
It doesn't work. See attached screenshot.

Steps to Reproduce List Sorting Bug:
1. Open SFRPG Classic 3.3.13 (for example)
2. Go to the abilities tab of an existing character
3. Rename some abilities
The list doesn't sort. See attached screenshot.

(...and at the time I reported this bug, there were no pending updates and these functions were working fine in PFRPG, so not inheriting from Core)

[Moon Wizard]

The current ruleset version for SFRPG is v2021-03-02. The previous version reported before that was v2.1.18. Please make sure that you don't have any unpacked ruleset folders in your FG data folder.

I'm not able to reproduce the ability creation issue. (See picture with latest Live ruleset running.)

For the sorting, I am able to recreate; so I'll ask superteddy57 to look at it.

Regards,
JPG

[HoloGnome]

After updating to the just-released version, right-click Ability create is now working, but dynamic list sorting is still not working. After changing the Ability names, the PC Ability list will only end up sorted if I completely reload the SFRPG campaign. So...still broken. (Oh - good you can reproduce it - you posted while I was creating this post)

I don't have any SFRPG unpacked rulesets in my data folder.

You may wish to update the right-click issue in the change history - there seems to have been a change that fixed it since my report.

SFRPG shows only:
[SFRPG] Token health bars not displaying or updating correctly. Fixed.
[SFRPG] Window titles not displaying correctly. Fixed.
https://www.fantasygrounds.com/filelibrary/patchnotes_ruleset.html

There is no mention of any Starfinder updates in the 3/2 release notes here, but SFRPG obviously changed:
https://www.fantasygrounds.com/forums/showthread.php?66659-Release-Updates-for-March-2nd-2021

The previous ruleset current as of 3/1 was 12,079,104 bytes. The new ruleset current as of 3/3 is: 12,080,636 bytes.

It would also be helpful if you could include windows versioning resources in the .pak files. The rulesets don't display any external versioning information. It would be a useful quality addition.

[madman]

Works for me..

[Moon Wizard]

I think there is something else going on; in that added abilities are sorted differently. I'll see if @superteddy57 can figure it out.

Regards,
JPG

[Evolivolution]

- No extensions loaded
- FG Classic or FGU

Steps to Reproduce Item Creation Bug:
1. Open SFRPG Classic 3.3.13 (for example)
2. Go to the abilities tab of a new character
3. Try to right-click to add an entry to Class Abilities
It doesn't work. See attached screenshot.

Steps to Reproduce List Sorting Bug:
1. Open SFRPG Classic 3.3.13 (for example)
2. Go to the abilities tab of an existing character
3. Rename some abilities
The list doesn't sort. See attached screenshot.

(...and at the time I reported this bug, there were no pending updates and these functions were working fine in PFRPG, so not inheriting from Core)

Okay I'm gonna be honest with but this looks awfully wrong. 44528 This is how it should look. It automatically sorts any items that are related to another Ability below them and it also sorts them alphabetically after fullfilling that first rule. Now I don't know where 'Life Science Checks' in your build is comming from. Maybe something to keep in mind is that the sorter does its work when you add an item. It doesn't re-sort a changed item (after you changed the name for example). But it does re-sort the whole list whenever you add or remove any items. I also don't know why yours didn't sort the Revelations under 'Stellar Revelation' and so on. Did you create these things yourself or are you using the CRB version of these abilities. I'd assume you changed the 'Su' into 'SU' as well. Although this should have any influence regarding your problem.
Just for reference I quickly edited my Abilities to fit the little letters you put in front of them and after creating a new item it looks like this 44529.

[superteddy57]

As Evolivolution has pointed out the sort starts with the record.
44530

You have a set of radios along the top to help with the organization and tell the character sheet what type of feature it is. If it's a feature that doesn't have choices, then it's a feature. If it has sub selections then it's a special feature. Since Paizo didn't differentiate These two, it was setup by us to help organize and load base class features like you would see with 5e. Source has no bearing on automation, just a way to keep track of where the feature has come from in case the DM limits which books features can be collected from. The next in line is the feature. This is how it links skills together to be sorted. The name must match the parent feature it needs to be linked under. If it doesn't match it doesn't sort it under it. Level is used during level ups to automatically add them if added to the base class record. I hope this helps.

44531

[superteddy57]

I do see that the list isn't updating when the name is changed. I will get that sorted and pushed with the next update.

[HoloGnome]

Great - thanks. Glad you were able to find the problem. I will check it in the "latest" and get back to you. Do the .pak rulesets have versions now?

Otherwise, I have a very basic install, I definitely add and/or rename items manually, items were not sorting except upon launching and the create item function was also previously broken, as originally reported (fixed with the 3/3 release). For the create item bug, you should be able to retroactively confirm and document it by using the SFRPG ruleset version from your SCM archive that was public when I reported the problem.

[superteddy57]

Versioning is now done by date. SFRPG is now currently locked for Light and Vision feature update.

[HoloGnome]

Respectfully, date is not a very good way to do file versioning. The OS modifies the file creation date when you download and "create" the file. The best way is to embed the dedicated versioning resources (and it's easy to do). And, it's not just an issue with SFRPG - it relates to all the FG .pak rulesets...and other files. Also, a top-level FG version doesn't help when the rulesets are constantly changing between revs and have no embedded version data.

Were you able to reproduce the issue with add item, as above? I'd like to know if it is something you were able to fix previously, or if there is still some linging issue that is specific to my system resulting in unexpected behavior, etc.

Thanks.

[HoloGnome]

Here is the link to the previously failing ruleset (current as of 3/1) under FGU with the following 2 bugs noted above:

1. cannot right-click add new items under abilities
2. does not dynamically sort abilities

https://drive.google.com/file/d/10xmjzwA3wMqQJV2LZDTvoGQtGIeATm4A/view?usp=sharing

Please verify on any FGU system. Thanks.

[EDIT 4/3: Ignore - the latest FG versions break regression testing for all previous ruleset versions.]

[Moon Wizard]

The version information has been changed textually to be the date; it has nothing to do with the file modification dates. It's purely for quick identification of the version in the chat window and log.

I'll let superteddy look at the issues reported; but we'll be testing only against the current Live version (and/or the Test version) only.

Regards,
JPG

[madman]

I just tested this in the Live version and it works just fine. Have you updated since you had the problem?

Madman..

[HoloGnome]

Moon Wizard:
1. Bug regression against previous versions is standard QA practice. In this case, I am asking for someone (anyone really) to verify the problems I saw with the above-posted code to rule out other variables associated with my system. [Can any other user help me out?] If the "can't right-click add" problem is reproducible, then it is not being caused by my (somewhat generic) install. Further, if that problem no longer exists, then it was obviously fixed and (both bugs) should be noted in the change history for the sake of the quality process. If nobody can verify them, then I have to keep digging to figure out why my system is different. The amount of time it takes to do this reasonable test is minimal.

Edit: I also see that it is now impossible to regress anything with old rulesets. OK - that's one way to address the quality process through version name elimination criteria.

2. Isn't it time to adopt a unified versioning strategy across all products and modules? Haven't you standardized in SCM? I see the text date in the chat for Core RPG...but not a great strategy. What is the versioning strategy when you have 2 releases on the same day? Further, if you include the desktop-based versioning resources, then users can check the file versions and verify or report on their installs without having to launch the app to look for text strings in the chat.

Edit for 2 above: I see that you guys have shifted to date versioning for everything. That is not a great or industry-standard choice. The world runs on Major.minor.patch where the patch should increment when patches occur.

Madman:
I will check the latest releases. Retrospectively, if the problems are gone, then there is no problem with system and the only issues are that bug fixes are not being documented in the change histories and the external version identification bears improvement.

------------------------------------

Edit: Superteddy: In SFRPG 3/30 FGU, the right-click add bug is fixed, which means that it was identified and fixed in a prior ruleset and is not a problem with my system. Thanks. The dynamic ability sorting bug is fixed in some contexts and not others. I have attached a broken character sheet. You should check to make sure that you are reading in, indexing into, and sorting the full ability db list when you open the sheet - that doesn't seem to be happening. In the attached broken character, "A Monkey" remains at the bottom on open. I added A2 and D items that were correctly inserted, but A still remained at the bottom, which indicates that the loading/sorting is still not correct. Let me know if you need any more testing on this one. Happy to help.

In addition, the 3/30 SFRPG ruleset (and maybe others) are not setting the scroll visbility for new items. When the ability list has enough items to scroll and you add a new item, it remains scrolled out of the visible area (or at the bottom) on creation. The new item correctly has cursor focus, but is not visible and the user has to scroll to the bottom to find it or type blindly.

Also, the direction of the import/export arrows is (historically) backwards. From a usability standpoint, it should be:Export/Out/Down Arrow/Away from Window; Import/In/Up Arrow/Into Window -- long-standing problem.

[deer_buster]

1. Not really on them to validate a possible bug that existed in code that isn't current. Their time is much better spent on fixing things that can be verified and adding functionality/features.
2. If I remember correctly, adding an incremental alpha at the end of the date if it goes up. It's not an ideal versioning system, but since they aren't automatically incremented (it depends on the developer remembering to update it), it's what we get. Again, rather than going through and setting up a proper versioning system, time and resources better spent elsewhere.

Thing to remember, they are a small shop with limited personnel and resources trying to output the highest ROI they can. Nowhere near being an industry standardized shop in terms of staffing or resources or discipline (not a dig on anybody, it's just the way small shops typically operate).