Log in

View Full Version : Ongoing Acquisitions Inc. Campaign Broken



Vam
February 13th, 2021, 18:02
TL;DR: An update appears to have broken Acquisitions Inc for ongoing campaigns. Scroll to the bottom for how I think I fixed it.

I had a strange issue yesterday while running the Acquisitions Inc campaign. When I tried to load the map the characters are on, I got the message


"A module you are attempting to use is not loaded.

D&D Acquisitions Incorporated Adventures

Activate module and attempt to open the link again?"



I said yes, but it did not help.
I tried manually unloading and reloading the module. It did not help.
I tried exiting FGU and removing the vault/WOTC5EAI.dat file, and then running the updater. It did re-download WOTC5EAI.dat, but the problem persisted.
I disabled all community extensions, but it did not help.


At that point we gave up on making it work for that session and carried on with the D&D Beyond version, using FGU for the combat tracker on encounters. I'd lost my notes on the story entries, but the session wasn't a complete loss.

Today I took some more time to straighten things out for next week's session.

I looked under modules for Acquisitions Inc, and I found three modules available:

D&D Acquisitions Incorporated
D&D Acquisitions Incorporated - Players
DD Acquisitions Incorporated Adventures


I found the reference manual there, which I had a link to in one of my campaign story records. So I made another link to each of the reference manuals to see the difference in the XML.



<link class="reference_manual" recordname="reference.refmanualindex@D&amp;D Acquisitions Incorporated Adventures">Acquisitions Inc Reference (old)</link>
<link class="reference_manual" recordname="reference.refmanualindex@DD Acquisitions Incorporated Adventures">Acquisitions Inc Reference (new - adventure)</link>
<link class="reference_manual" recordname="reference.refmanualindex@DD Acquisitions Incorporated">Acquisitions Inc Reference (new - supplement)</link>
<link class="reference_manual" recordname="reference.refmanualindex@DD Acquisitions Incorporated Players">Acquisitions Inc Reference (new - players)</link>


The original link contains "D&amp;D" while the new ones contain just "DD".

Likewise in my moduledb folder, I had:

D&D Acquisitions Incorporated Adventures.xml
DD Acquisitions Incorporated Adventures.xml
DD Acquisitions Incorporated.xml


This solution appears to have worked for me:

In the moduledb folder I replaced DD Acquisitions Incorporated Adventures.xml with D&D Acquisitions Incorporated Adventures.xml, and I used a text editor to replace all instances of "D&apm;D" with "DD" in both that file and db.xml.

Everything seems to be back to normal for the campaign now.

I imagine this is related to this thread (https://www.fantasygrounds.com/forums/showthread.php?65482-Acquisitions-Inc-conversion-issues) but sadly the updated module is still riddled with squares where quotes should be, likely from a bad character encoding.

I post this here both to ask Smiteworks to avoid renaming modules so that issues like these can be avoided (or providing an automated transition process if renaming is absolutely required) and to help anyone else who finds their AI campaign broken.

Moon Wizard
February 15th, 2021, 04:12
I've worked with the DLC developer to untangle the situation. We give explicit direction to DLC developers NOT to rename modules. In fact, we have a distinct "displayname" tag exactly to allow them to change the visual name, without changing the data reference name.

I've pushed a hot fix to fix back to the original name (incorrectly changed on Feb. 3); since all the data in the module was keyed to the original name anyway. Additionally, we have fixed the FGU font encoding issues while we were at it.

Regards,
JPG

Vam
February 15th, 2021, 13:21
Thanks for this Moon Wizard. I've restored a backup from before my own "fix" and it is working. I've also spot checked the character encoding and it looks good.

When I was looking at character encoding I happened to try to go through the "D&D Acquisitions Incorporated Adventures" module, and saw that it was missing. So now, when you look for it in the main module it says to find it in D&D Acquisitions Incorporated Adventures, but it doesn't exist there. Can this be restored? The story entries look ok.

Thanks again!

Moon Wizard
February 15th, 2021, 21:00
I'm not following what you are asking. It has a new display name; though the "reference name" has been restored.

What is missing exactly?

Regards,
JPG

Vam
February 15th, 2021, 21:07
Sorry, I didn't communicate that very well. It's the Reference Manual that is missing from the "D&D Acquisitions Incorporated Adventures" module.

Zacchaeus
February 15th, 2021, 21:12
I don't think the adventure ever had a reference part. There's the DM and Players modules which are both reference manuals but the adventure doesn't have a reference

Vam
February 15th, 2021, 22:43
I just double checked using a PC I haven't updated in a while. All three used to have a reference manual, and the DM version referred to the 'Adventures' version. I agree that this is a strange way to break it down since there isn't any reason to separate the adventure from the DM version.

Here's a screen shots from the DM module showing the table of contents and the instruction to refer to the Adventures module:
43755

Here's the table of contents for the reference manual in the Adventures module before the update:
43756

After the update the Adventures module no longer contains that reference manual.

Zacchaeus
February 16th, 2021, 00:30
Ah, I stand corrected. I was of course looking at the latest module when I checked. I’ll make sure the developer gets to know.

rob2e
February 16th, 2021, 05:39
The reference manual was INDEED (somehow) missing, this has been fixed for the next update.

Moon Wizard
February 16th, 2021, 05:48
I pushed Rob's fixes to the patch system. The issue was that I pushed a module with the default tools; and Rob uses a community tool to develop the reference manual that I don't use.

Apologies for all the chaos.

Regards,
JPG

Vam
February 16th, 2021, 13:23
Thanks everyone - much appreciated. Sorry for my confusing initial description of the problem.