Chat Links

[bmos]

I noticed this morning that web links in extension load announcements aren't working in Unity.
Can anyone else confirm that?

EDIT: see post #3 for better information

[humby]

Are you including the "http:" / "https:" at the beginning of the link? Typing "https://www.bbc.co.uk" works for me, but "www.bbc.co.uk" does not.

If you are using them, are you using any extensions? If so, does it still happen when you load your campaign with them all switched off (including any themes you may have)?

https://www.fantasygrounds.com/forums/attachment.php?attachmentid=41104&d=1605362395

[bmos]

Are you including the "http:" / "https:" at the beginning of the link? Typing "https://www.bbc.co.uk" works for me, but "www.bbc.co.uk" does not.

If you are using them, are you using any extensions? If so, does it still happen when you load your campaign with them all switched off (including any themes you may have)?

https://www.fantasygrounds.com/forums/attachment.php?attachmentid=41104&d=1605362395I should have been more specific, sorry!
The issue I am having is that extension announcements that include links aren't working.
This code in extension.xml works in Classic:

<announcement text='https://www.fantasygrounds.com/forums/showthread.php?63620-PFRPG-Upgrade-NPC-Actions-Extension\nUpgrade NPC Actions v1.0:\nThis extension replaces NPC spell effects and descriptions with those from the "PFRPG - Spellbook" module.' font='emotefont' />
and shows the link button in Unity as well but it doesn't do anything when clicked.

[humby]

Did some testing - it appears that if your announcement does not have an icon associated with it, the link does not work. Don't know if that's a bug or not, but adding the icon to the announcement text should make it work again.

[bmos]

Did some testing - it appears that if your announcement does not have an icon associated with it, the link does not work. Don't know if that's a bug or not, but adding the icon to the announcement text should make it work again.Actually, some of the extensions I am testing with do have icons.
Here is an example from one that does:

<announcement text="https://github.com/bmos/FG-PFRPG-Live-Hitpoints-from-Constitution\rPFRPG Live Hitpoints 1.4:\rThis extension seperates HP from CON and HP total to assist with rage and other game mechanics effecting base HP." icon="BandageLogo" font="emotefont" />
41115
neither link works

I don't think it could be anything but a bug. Showing a link icon that does nothing is pointless.
If it intentionally doesn't support links anymore (Classic does) then the link shouldn't be shown (or should be shown as text).
So either a bug that it doesn't work or a bug that it shows it as a link.

[humby]

OK, quite a lot of poking and prodding later, it seems that the image thing was a red herring. For some reason, the hotspot for the link is not always over the normal link icon but instead is sometimes above it.

For example, in the image below, holding the palm of the mouse cursor over the highlighted spots allowed me to click the hotspot.
https://www.fantasygrounds.com/forums/attachment.php?attachmentid=41127&stc=1&d=1605401418

I agree that this is a bug - hopefully one of the devs will be able to shed further light on what's going on...

[bmos]

OK, quite a lot of poking and prodding later, it seems that the image thing was a red herring. For some reason, the hotspot for the link is not always over the normal link icon but instead is sometimes above it.Nice find!! I wonder if it has to do with UI scaling...

[Kelrugem]

Nice find!! I wonder if it has to do with UI scaling...

When I am not mistaken, in FGC these things were at that place, while in FGU the icon stuff moved to the middle of the left boundary of the chat message; the code seems to expect that the icons etc. are still where they were in FGC :) So, the "hitbox" has to be updated :D

[bmos]

When I am not mistaken, in FGC these things were at that place, while in FGU the icon stuff moved to the middle of the left boundary of the chat message; the code seems to expect that the icons etc. are still where they were in FGC :) So, the "hitbox" has to be updated :D

Ah! It's because my announcement is multi-line.
A single-line announcement causes that button to be in-line and thus function correctly.
IMO this reinforces your hypothesis.

[Carlos]

Ah! It's because my announcement is multi-line.
A single-line announcement causes that button to be in-line and thus function correctly.
IMO this reinforces your hypothesis.

When a bug like this is identified... what happens next? How is all the stuff in the forum being tracked? Does this go into a private Jira instance used by the developers? I assume Jira because Confluence is being used for the public wiki.

[Moon Wizard]

The first thing I usually try to do is to get information to recreate the issue and/or try to recreate the issue.
Then, I either fix (if simple and one of the areas I develop) or add a ticket to Jira for prioritization (if complex or managed by another developer).

I've added Jira tickets for all the recent items you reported for us to investigate. We may have more questions as we dig in.

Regards,
JPG

[Carlos]

The first thing I usually try to do is to get information to recreate the issue and/or try to recreate the issue.
Then, I either fix (if simple and one of the areas I develop) or add a ticket to Jira for prioritization (if complex or managed by another developer).

I've added Jira tickets for all the recent items you reported for us to investigate. We may have more questions as we dig in.

Thank you very much for doing this work, I know how time consuming it can be to filter input from users. I'm in progress of trying to recreate some of the failure modes I've seen from clean initial campaigns. It's great to hear that you have a process for tracking these.