[BUG] Reveal and hide mask bounding box colors wrong when using ctrl+click dragging

[Carlos]

Summary: Reveal and hide mask bounding box colors wrong when using shift or ctrl.
Ruleset(s): Dungeons & Dragons (5E)
New Campaign / FGC Migrated Campaign: New campaign for testing.
Extensions/Themes: None.
Modules Loaded: None.
Operating System / Language Setting: Windows 10, English (United States)

Steps to Reproduce:

I say "wrong color" for the bounding box based on the FGC colors which are RED for reveal and BLUE for hide. The bounding box context color is VERY useful when you're about to reveal or hide something. Thus knowing which the operation is going to be and using a color is very useful.

Latest version: v4.0.1 ULTIMATE (2020-11-11)


Create a new map.
Enable mask.
Select "Reveal Area"
Use the mouse to reveal a square portion of the mask
Press ctrl+click and drag (FGC legacy shortcut) to hide a smaller square
Press ctrl+click and drag again (FGC legacy shortcut) to hide a smaller square


Expected behaviour:

When click and dragging the bounding box color is RED (reveal mask)
When ctrl+click is pressed the bounding box color is BLUE (hide mask)


Observed behaviour:

When click and dragging the bounding box color is RED (correct)
When ctrl+click and dragging the bounding box is RED and mask is revealed (incorrect, should hide mask)
When ctrl+click and dragging the bounding box is BLUE (color changes) and mask is revealed (incorrect, should hide mask)


Notes:

I would like ctrl+click to work again instead of having to click on "Reveal area" or "Hide area".
At the very least the "Reveal area" bounding box should ALWAYS be RED, and the "Hide area" bounding box should ALWAYS be BLUE, but not randomly switch colors.
It looks like some code is present to support ctrl+click but it doesn't work as intended (just makes the bounding box blue on the second attempt but doesn't hide area).

[Kelrugem]

Note: Alt is now the hotkey for inverting the behaviour, not ctrl :) (that got now standardized, so, alt is the hotkey when it is about inverting of some control when possible :) )

EDIT: My argument applies to shift not alt :D See below :)

[Sulimo]

I think they changed some of the key combos.

Hold Shift to re-mask works.

Use Alt to unmask arbitrary shapes, Shift+Alt to re-mask arbitrary shapes.

Working with Images (https://fantasygroundsunity.atlassian.net/wiki/spaces/FGU/pages/950633/Working+with+Images+as+the+GM).

[Kelrugem]

I think they changed some of the key combos.

Hold Shift to re-mask works.

Use Alt to unmask arbitrary shapes, Shift+Alt to re-mask arbitrary shapes.

Working with Images (https://fantasygroundsunity.atlassian.net/wiki/spaces/FGU/pages/950633/Working+with+Images+as+the+GM).

Ah, yes, it was shift, not alt :) thanks; I always need to test the hotkeys because I always forget it :D

[Carlos]

I think they changed some of the key combos.

Hold Shift to re-mask works.

Use Alt to unmask arbitrary shapes, Shift+Alt to re-mask arbitrary shapes.

Working with Images (https://fantasygroundsunity.atlassian.net/wiki/spaces/FGU/pages/950633/Working+with+Images+as+the+GM).

Yes, holding shift for re-masking works.

It is still a bug that with ctrl the bounding boxes change color.

If Shift is the re-mask key then it also is buggy because it fails to set the bounding box to the correct expected color we've been using for more than a decade.

There is no reason not to use colors for these operations correctly.

It is useful and important to use color for context during mask and un-mask operations since it helps the DM.

[Weissrolf]

Ah, yes, it was shift, not alt :) thanks; I always need to test the hotkeys because I always forget it :D

Which is why I suggested that the mouse-pointer should change accordingly when a hotkey is pressed. This is how it works in Photoshop.

[Carlos]

Which is why I suggested that the mouse-pointer should change accordingly when a hotkey is pressed. This is how it works in Photoshop.

Agreed. This would be a great way to indicate the mask/unmask operations.

[Kelrugem]

Which is why I suggested that the mouse-pointer should change accordingly when a hotkey is pressed. This is how it works in Photoshop.

Yeah, I never said anything against the colouring, that I would like to have, too :) Though it would not help in that special case, because I would still need to test first to see with which hotkey the colour is different :D ( and also because in that case it was just about whether it is free-form or not, I did not need to end procedure to see what it does)