PDA

View Full Version : [5e]Bug: Max Crit wrong total


deer_buster
July 10th, 2020, 03:12
So, I got a chance to Crit & Max with my Sneak Attack on a short sword, which is normally 1d6+4. My sneak attack is normally 1d6. That results in a roll total of 4d6+4, which should be 28 total. Result came out as 20. Roll text said 2d6-4=8 and 2d6=12.

EDIT: Wrong screenshot. See the 3rd post....
Bercilak
July 10th, 2020, 20:21
First, congrats on that crit!
I'm definitely no expert on FGU, but it looks like the damage output was 29 done to Ravina, even though the dice roll graphic output was wrong at 18.
I wonder if this is connected to the Reroll issue folks are seeing.
deer_buster
July 10th, 2020, 21:44
Not sure why I put the wrong capture in there..
deer_buster
July 11th, 2020, 20:40
Can anyone else confirm this?
cevikd
July 11th, 2020, 20:51
Sounds like they may have addressed this in today’s patch?

https://www.fantasygrounds.com/forums/showthread.php?54466-FGU-Early-Access-Updates&p=525471&viewfull=1#post525471
Zacchaeus
July 11th, 2020, 20:52
Indeed. It has just been patched.
deer_buster
July 11th, 2020, 21:10
Well, yeah, it has been patched. Still not perfect. It does seem to calculate the right amount and apply it. But the display is off...
Zacchaeus
July 11th, 2020, 21:23
I'm seeing the correct display and result. Not sure what's going on at your end.
Moon Wizard
July 11th, 2020, 23:08
Which ruleset?

It has to be patched in each ruleset. I've patched it in Core/5E/4E/3.5E/PFRPG/d20Mod/CoC. I tried to do it globally, but that caused other problems as you saw from the build earlier this week. By doing it this way, the chat total isn't right, but the ruleset still calculates correctly. To fix the display, it needs to be fixed in each ruleset.

For any ruleset programmers, if you change any die.result values, you also need to clear or set the die.value values. This allows the ruleset to calculate the values correctly, since values can be different than displayed results in FGU for systems that support dice that have different values.

Regards,
JPG
deer_buster
July 12th, 2020, 02:26
I'm seeing the correct display and result. Not sure what's going on at your end.

Yeah, probably my fault...I had the 5e ruleset extracted to try and troubleshoot, and it doesn't patch extracted rulesets...only the packed ones.
deer_buster
July 12th, 2020, 02:29
Yep, it works now in my 5e now that I deleted the extracted copy. Even works MAX-HALF-CRITICAL correctly. Good job Moon