PDA

View Full Version : [Bug] loadorder broken ?



deff
April 15th, 2020, 09:08
Hello,

I have 2 extensions, one should be loaded before the other one.

So for the 1st, i put :

<loadorder>50</loadorder>
</properties>


So for the 1st, i put :

<loadorder>100</loadorder>
</properties>

It seems to work before the last update, but now it looks like it is random.

So sometime, the second one is first :/

Moon Wizard
April 15th, 2020, 09:41
Nothing was changed in the extension ordering between updates. How do you know that the ordering is off?
Please note that global scripts are not fired in load order; so you would mainly see in template/window/script overrides.

Regards,
JPG

deff
April 15th, 2020, 09:48
Thanks to the logo, i can see Cthullhu ext is loaded before COC ext. So in the char sheet, some modifications from cthulhu extension, like madness points, are no longer visible.

https://ibb.co/bQ8N3Zb

In FG3, it works.

deff
April 15th, 2020, 17:30
To help, here are 2 little extensions, one with loadorder 50 , and the other one 100. Like this you can test on your side.

https://www.dropbox.com/s/ym389pkbvbg9ir6/loadOrder50.ext?dl=0
https://www.dropbox.com/s/rh5nwg5qtxacizo/loadOrder100.ext?dl=0

As the screenshot show, the loadorder50 has been loaded at the end.

https://ibb.co/zJ4Fccz



Maybe it is nothing related to the last update and the loadorder has never worked in FGU....

Moon Wizard
April 16th, 2020, 01:05
The announcement text is not guaranteed to be in load order.

JPG

deff
April 16th, 2020, 06:43
The announcement text is not guaranteed to be in load order.

JPG

That's why i add a change of the desktop.png with the number of the load number painted :) and it is not correct that i have 50 displayed.

Moon Wizard
April 16th, 2020, 08:07
Well, I'll add a task to investigate the issue, once we get past some of the more pressing issues. (FGU-1047)

Regards,
JPG

deff
April 16th, 2020, 08:13
Thank you Moon Wizard :)

deff
April 20th, 2020, 21:02
If it can help, several tests show that extensions seems to be loaded following their file name <filenqme>.ext.

So it is a workaround (add a prefix to the file name) but loadorder should work in the future or it will be a mess :)

Minty23185Fresh
May 20th, 2020, 01:51
I concur with deff, it appears as though <loadorder> is broken. The load order for two of my extensions is important and is causing issues in FGU. If I try to remedy the issue with <loadorder> it doesn’t work. But if I rename the extension files so that they fall alphabetically in the desired load order things work out just fine.

deff
June 6th, 2020, 07:40
@Minty23185Fresh does the last update fix it for you. For me it doesn't look like :(

Moon Wizard
June 6th, 2020, 08:50
It appears to be working for me. I even used your loadOrder50 and loadOrder100 extensions to make sure it solved that ordering situation.

Load order of extensions is an ascending order numerically.

Regards,
JPG

Minty23185Fresh
June 6th, 2020, 14:34
@Minty23185Fresh does the last update fix it for you. For me it doesn't look like :(
I don’t know, but I’ll check. I’m not an FGU user, but some of the users of my extensions are, so when they have issues I try to determine what the problems are. Since I’m not an FGU user I‘m unaware of these sorts of things until someone brings it to my attention.

deff
June 6th, 2020, 14:49
Ok my bad, it was late yesterday ^^ I tested it and it works :)
Thank you Moon