Starfinder Ship Combat and Character Ship Roles Extension

[superteddy57]

The extension is no longer being offered due to the end of the testing period of the feature. It is now located on the Test server for further testing.

The thread for future feedback and bugs will be located here: https://www.fantasygrounds.com/forums/showthread.php?53280-Starfinder-Ship-Combat-moving-to-main-code&p=471883#post471883

Thank you
To all who have assisted in testing and providing feedback, I want to thank you for your patience and help during this process. You all have been great in providing feedback, bug reporting, and guidance on how the system should work. Please enjoy the new feature and be sure to report any great encounters you may have.

Dominic "SuperTeddy57"

[damned]

Wow. This is so cool superteddy57!!

[Ulric]

This looks great! My group will try it out tomorrow!

[Ulric]

I found a bug that affects the Player's combat tracker. I d/l the new extension SFSC v1.0.0.ext (https://www.fantasygrounds.com/forums/attachment.php?attachmentid=30876&d=1576528615) and loaded it before my game last night. With the new extension loaded Player's were not able to get the "Next Actor Button" to function. I as the GM could advance the "Next Actor Button" on my combat tracker. Player's were able to use the button correctly once I unloaded SFSC v1.0.0.ext (https://www.fantasygrounds.com/forums/attachment.php?attachmentid=30876&d=1576528615). I will continue to test over the next few days.

[superteddy57]

Ok thank you. I will add it to the list of things to get working for you

[ssostac1]

When I installed this extension, it seems to have disabled the automation on the normal Combat Tracker for PCs/NPCs. Rolling initiative does not automatically get entered into the combat tracker, and damage does not update in the combat tracker. Removing the extension solves the problem. I have no other extensions running.

[superteddy57]

I have replicated this and will look into what is causing the base Combat Tracker from failing it's inherent automation. Thanks for the find

[ssostac1]

Also, attempting to advance to the next round in the Starship Combat Tracker gives the following error: Script Error: [string "scripts/manager_starship_combat.lua"]:709: attempt to call global 'isCTHidden' (a nil value).

This is going to be a wonderful tool for starship combat though, I am really looking forward to it. Thanks for all of your hard work!

[superteddy57]

Ok thank you. I've made some changes and updated the extension to allow expansion to working with tokens on a map or image. Didn't want to release it till I can figure out how the standard combat tracker's damage drops aren't registering. That bug you reported should be fixed with this update. Just need some time to figure out this other bug.

[superteddy57]

Updated first post with update to extension.

[Serv]

First of all, thanks for making this a reality! My groups have long waited for some starship functionality.

A couple of things regarding NPC ships:

1) I'm not able to figure out how to roll for skill checks.
2) It looks like it is using the incorrect modifier for weapon attacks. It is using the pilot's modifier instead.

Thanks!

[superteddy57]

Skill checks are done from the crew toggle and a selector is available next to the crew member you wish to apply their gunnery ranks to the gunnery roll

[iamscience]

Seeing an issue with rolling skill checks as GM (just when testing things out).

In PC Ships > Crew tab I can't roll skill checks. This happens for everything but Gunnery actions as far as I can tell:
Script Error: [string "action1"]:1: attempt to call global 'getRoll' (a nil value)

These actions work when you're logged in as the PC tho.

The only way to roll as the GM is from the PC sheet > Ships tab.

In addition, enemy attacks against PC ships seem to be broken. They always compare against a Defense value of 10, regardless of the ships actual AC/TL value.

[superteddy57]

I will check this over and see if I can replicate. I will report back if I can see what might be causing what you are experiencing.

[superteddy57]

Updated first post with additions and fixes for latest bugs

[superteddy57]

Made a hotfix for an issue I missed in my list of things to fix. Fixed PC Ships not having their AC/TL being factored when NPC ships attacked them.

[Yujin]

Hi. If roll action Encurage Vs DC 10, fron PC Sheet,- have error. Script Error: [string "scripts/manager_action_shipskill.lua"]:30: attempt to concatenate field 'sSkillName' (a nil value)
31070

[superteddy57]

Updated first post with fixes v1.2.4

[superteddy57]

Updated first post with fixes v1.2.5

[superteddy57]

Updated first post with fixes v1.2.6

[stephan_]

I can barely keep up with downloading them. :)

[superteddy57]

I'm sorry! I would have let them simmer for a week if they were features, but these were game breaking and wanted to have them fixed. Don't want you guys having broken systems.

[stephan_]

No worries! Appreciated!

[CMDRBULB]

Super appreciate the work you are doing!

I have been encountering a bug while attempting to roll skill checks from the crew tab on the ship combat tracker.

This happens only when rolling for any crew position OTHER than Captain.

Script Error: [string "scripts/manager_action_shipskill.lua"]:63: bad argument #1 to 'lower' (string expected, got nil)

31098

I tried a variety of ships and still had this issue. Still love the extension and excited to use it tonight!

[superteddy57]

Updated first post with fix to NPC Crew skill checks not rollilng

[stephan_]

We used the extension successfully in today's game.

It's way easier to run starship combat, one bug (in addition to the "can't advance CT" bug) was reported on the players' side (but I can't provide any additional details as I was occupied running the game):

With the extension enabled, the "skills/basic info tabs are missing" from the party sheet.

[superteddy57]

I will have a look and see if I can replicate. Thank you for providing the bugs.

[superteddy57]

Updated first post with new feature to allow PC's to change role on ship from PC Sheet and fixed a bug for damage not being added to ShipCT.

[Zerqz]

Thank you for this!! Added some much needed ship combat functionality.

[superteddy57]

My pleasure! Please report back any bugs or feedback here.

[superteddy57]

Updated first post with new version v1.2.9

[docwat232]

How are folks using the ship combat tracker with a map?

The tokens added to a map from the ship combat tracker aren't using a facing indicator if the token:facing option is turned on.

Everything else looks great so far. Thanks!

[superteddy57]

I'll have a look into getting that working with Ships.

[stephan_]

In the meantime I highly recommend making ship tokens with integrated arcs (see here (https://www.fantasygrounds.com/forums/showthread.php?48858-Space-Battle-needs-a-60%BA-and-a-120%BA-arc!!!)).

[Ulric]

CoreRuleSet v3.3.9, SFRPG v1.2.6, SFSC V1.2.9 No extensions running other than SFSC

I built two different simple PC ships and I was able to reproduce these errors with both ships.

In addition to the errors below I could not edit shields on the NPC ship Death's Head Necroglider from the "Ship Combat Traker" but I could edit other NPC starship shields from the combat tracker.


SFSC Console Error Messages


These console errors are always reported on the Player’s Computer. I never got a Console popup on my GM computer.


When opening the PC Ship Sheet on the GM computer from the Ship Combat Tracker. This message would popup on the Player’s Computer.


Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)


When the GM opens the Build Point Summary on the PC Ship Sheet it causes the error console on the PC’s computer to open and report the following errors.


Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)




This event also creates a new blank entry on the Build Point Summary Sheet every time the GM opens the PC’s Ship Sheet. If the GM deletes these new blank entries the Player’s console popup and reports the following error.

31195


Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Script Error: [string "campaign/scripts/charsheet_actions_starship..."]:105: setValue: Unable to create node
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label11) in windowclass (charsheet_actions_starship)
Ruleset Warning: window: Anchored static height ignored for control (label12) in windowclass (charsheet_actions_starship)

[superteddy57]

I can't replicate your issue. I will need more information or a copy of the campaign that you are playing to see what is going on. The particular script error points to roleChange function for PC Sheets and particularly setting the showhideactions button to a certain state. With the information provided, just not sure what might be causing it. If you want to work together through this, you can reach me on discord to chat further or we can continue here.