(Prototype) Extension for (dis)advantage

[Kelrugem]

Forge link (FGU only; FGC use attached versions below): https://forge.fantasygrounds.com/shop/items/6/view
(https://forge.fantasygrounds.com/shop/items/6/view)

Hi :)

This is the support thread for my extension adding (dis)advantage effects and modifier buttons to CoreRPG based rulesets (not needed for 5E) :) See the forge link above for the FGU version and the attached version for an FGC version :) (the FGC version does only contain the effects)

Best,

Kelrugem

[Kelrugem]

I now added a separate extension where you do not have the automatic removal. This fixed all the issues I have seen in 3.5e/PF1 (except that with damage because this is really not possible on CoreRPG level) :) But you have to think about removing the effect then again (I may find a better solution in my extension later) or you define the effect in such a way that it expires on the next roll but then the cast button and "save on me" problem comes back :) (so for these situations you need it without the automatic removal)

[Kelrugem]

Some other observation (edited this also into the first post):

It's independent of the type and number of dice, gladly :) But: When you have more than one die as in 2d6 which are also of the same type, then there is no visual clue yet which dice are taken, it does not necessarily take the combination with the highest/smalles result but it's still correctly handled. E.g. for 2d6 every d6 gets a separate d6 partner so they build some pair. From this pair the highest/smallest number is taken, but you can not really see which dice are paired because all will have the same colour :) You have to trust my code then :P

[Asgurgolas]

I love you, man! O_o

[Kelrugem]

Hi :)

Just here to say it does not need any update for 3.3.10

Sorry, that I couldn't improve the extension yet, my PhD is at the moment very distracting :) I already have some ideas how to improve it to make it better for more rulesets :) But no idea when I have time for that

Best,

Kelrugem

PS: I also realized after some testing that effects also count as "rolls", so, the best way at the moment is to apply the (dis)advantage effect right before the roll affected by that :) Then less quirks in general :) (but that should be easy to fix, I just need to check first whether there is some die in the roll)

[Kelrugem]

Hi :)

Finally I updated that extension and now all the problems (with respect to 3.5e/PF1; I do not know other rulesets :P) got fixed :) Except damage rolls for 3.5e/PF1 while having these effects, this I can only fix in my 3.5e/PF1 version only :)

The solution was: These effects now only get triggered when there is really some physical die involved. Thence, applying effects or pressing the cast button will not trigger them anymore avoiding basically all the problems mentioned above :) Gladly, this extension is now not a prototype anymore (as far as it is possible at the level of CoreRPG) :)

I will soon add that to my 3.5e/Pf1 version and mention it in the threads there

[Kelrugem]

New update :)

I cleaned up a bit of the code (for improvements related to the damage roll of 3.5e; not important for most other rulesets, still the same as usual. When something changes then only in the better direction)

And I implemented now stacking of these effects: It takes either advantage or disadvantage whichever effect is dominant in sense of numbers; when both have the same number of effects on a character then they will negate each other such that the roll will be a standard one :)

[tahl_liadon]

.
hey, @kelrugem -- i discovered last night that the kel(dis)advantage double-rolls every dice... atks (d20) as well as damage (or any die type).

plz confirm if this is currently the case. if so, i had to remove effect for witch (mis)fortune as it was double-rolling everything X-D

[Kelrugem]

.
hey, @kelrugem -- i discovered last night that the kel(dis)advantage double-rolls every dice... atks (d20) as well as damage (or any die type).

plz confirm if this is currently the case. if so, i had to remove effect for witch (mis)fortune as it was double-rolling everything X-D

At the moment, the (dis)advantage effects affect everything, yes :D There is no way to tell the effect which roll it should affect :) This will come in the next release of save versus tags :) (by the way do not load the extension here when you also use save versus tags/full overlay package because the (dis)advantage effects are included there :) (it should not produce any error though to load both, it is simply not needed))

Therefore the suggestion is to add that effect just before the roll to which it should be applied :) (and let it expire on next roll) I added this information in my effect pdf, too, to make it more clear that it affects everything :)

(it was first designed as CoreRPG extensions and therefore it affects everything because there is no specific type of die in CoreRPG, then the only option is every die :D)

[Kelrugem]

Updated for 3.3.11 :)

[Kelrugem]

Updated to 3.3.12 :)

[TripleKidney]

Does this work with PF2? I have installed it, and FGU says it has loaded, but dang if I can find it anywhere when I open the program. Maybe I'm just looking in the wrong place.

I think this would work great for my campaign where I need an "unluck aura" from gremlins.

Any assistance would be appreciated.

[Kelrugem]

Does this work with PF2? I have installed it, and FGU says it has loaded, but dang if I can find it anywhere when I open the program. Maybe I'm just looking in the wrong place.

I think this would work great for my campaign where I need an "unluck aura" from gremlins.

Any assistance would be appreciated.

I never tried it out there :)

When you have loaded the extension, then just apply the effect keladvantage (or keldisadvantage) directly before the roll you want to make :)

[TripleKidney]

I never tried it out there :)

When you have loaded the extension, then just apply the effect keladvantage (or keldisadvantage) directly before the roll you want to make :)

I got it to work! I created an effect with the names you provided, dragged them to the effected PC, and tested a few save rolls. Works great. Thanks!

[Kelrugem]

I got it to work! I created an effect with the names you provided, dragged them to the effected PC, and tested a few save rolls. Works great. Thanks!

Cool :)

[Kelrugem]

Updated to the most current version of FG :)

[Kelrugem]

New update, it should be now much more compatible with CoreRPG-based rulesets :)

[Kelrugem]

This extension is now on the forge :) Beware, it has the prefix Feature:, so, you may need to activate it again :) And there is only the version with the automatic removal; I plan to add a setting about whether or not it is the automatic removal one such that there will be only one extension :)

Forge link: https://forge.fantasygrounds.com/shop/items/6/view

[Kelrugem]

New update :)

Now there is only one extension; I've added an option where you can (de)activate a possible automatic removal of the effects :) (under Effect automation in the options)

And the chat messages are now more "beautiful", they will have the typical green or red colour if using advantage and disadvantage, respectively; the chat message will also list which numbers were dropped now :) (if more than one die was affected, then it will show all dropped numbers in the same order as the dice results they were compared with. So, [DROPPED 5, 7] and a result of 6, 8 means that you had advantage (so, 5 smaller than 6 and therefore 5 was dropped))

[Kelrugem]

I have updated this extension. Mainly for streamlining; for users nothing changes, but I have a note for fellow devs: This extension adds now rRoll.adv as an integer to affected rolls. If rRoll.adv is positive or negative, then it has advantage or disadvantage, respectively. If it is zero or nil, then the corresponding roll is not affected. This allows to count (dis)advantage effects :)

[mordkhaan]

Found an issue and have confirmed in a new campaign with no other extensions and only DMs Guide loaded
open up a treasure table like Treasure Horde: Challenge 5-10 and then roll on it
This will popup a console error
Script execution error: [string "scripts/manager_actions.lua"]:152: attempt to perform arithmetic on local 'nAdvantage' (a nil value

[Kelrugem]

Found an issue and have confirmed in a new campaign with no other extensions and only DMs Guide loaded
open up a treasure table like Treasure Horde: Challenge 5-10 and then roll on it
This will popup a console error
Script execution error: [string "scripts/manager_actions.lua"]:152: attempt to perform arithmetic on local 'nAdvantage' (a nil value

thanks for the report, I will look into this :)

[Kelrugem]

I just fixed this bug and uploaded the new version in the forge :)

Moreover, I also added new modifier buttons to the modifier window (click the +/- button in the upper right of the sidebar) for advantage and disadvantage, under the category General. Clicking on one of them will force advantage and disadvantage, respectively, regardless of how many effects exist in the combat tracker :)

[Kelrugem]

Small update for compatibility with the most recent version of FG :)

[mordkhaan]

FYI, seems latest FGU update rolls 4 dice not 2 when Adva button is depressed prior to an attack
confirmed in a campaign with only this ext loaded

[Kelrugem]

FYI, seems latest FGU update rolls 4 dice not 2 when Adva button is depressed prior to an attack
confirmed in a campaign with only this ext loaded

Oh, good to know, thanks! :) I didn't know that parts of that code got changed in the new patch, I try to update as soon as possible :)

[Kelrugem]

FYI, seems latest FGU update rolls 4 dice not 2 when Adva button is depressed prior to an attack
confirmed in a campaign with only this ext loaded

I just tested it: It works for me and it is still compatible

But I have an assumption: Did you test this in 5E? Be aware of that this extension does not support 5E because 5E already has such buttons :) If you use this extension in 5E, then the following happens: My code is activated and the native code of 5E :) Therefore the quadruple :)

It should be possible to resolve this; however, is there a specific reason why you need this extension in 5E? Since 5E already has a (dis)advantage system, you do not need this extension :) The extension is for other rulesets which do not have such an implemented mechanic :)

[Kelrugem]

New small update for compatibility with the newest FG version :)

[seanny]

This is fun.

I tried this in 13th Age and also OSE rulesets ,works great.

Thank you very much.

I tried in D&D 2E and also in OSRIC by Doomguard rulesets as well ,
I got a funny result there-
I got 4 dice rolls ,and the best of the four was given.
Pretty neat but maybe over powered.

Maybe could this be checked ,if not -all good since it is fun to use as is ;
especially for 13th Age and OSE.

I did most of my testing in the Test Channel ,but had to test OSE in Live Channel ,since OSE does not work in test channel -in case that makes any difference.

[Kelrugem]

This is fun.

I tried this in 13th Age and also OSE rulesets ,works great.

Thank you very much.

I tried in D&D 2E and also in OSRIC by Doomguard rulesets as well ,
I got a funny result there-
I got 4 dice rolls ,and the best of the four was given.
Pretty neat but maybe over powered.

Maybe could this be checked ,if not -all good since it is fun to use as is ;
especially for 13th Age and OSE.

I did most of my testing in the Test Channel ,but had to test OSE in Live Channel ,since OSE does not work in test channel -in case that makes any difference.

Thanks for your words and report :)

Currently I am on a trip (visiting my family and friends and giving talks about my research etc.), but I am soon back home and can look at such things :)

Can you tell me what dice you were rolling, so that I can reproduce and understand the error you meant? :) Thanks :)

[seanny]

I was just using d20s for a standard attack roll.
I think the Osric Ruleset makes use of the D&D 2E ruleset ,so enough just to look at the 2E ruleset I think.

I basically used the modifier tab ,picked advantage ,which I moved to hotbar for easy access.
Then I press on my hotbar tab twice.
Then make my d20 attack roll.
How I normally make my attack roll ,is grab the d20 dice from my character sheet ,then drop on the enemy token on the map. I find this is both quick and satisfying. Then I watch the result in the chat box.

Then 4 d20s are thrown.
The best result is given.

This is how I like to use your extension. Using my hotbar link.

BUT I have also used your special keladvantage in effects tab and dropped on a character as well.
I don't like this as much since it effects damage rolls too - to me advantage should only effect d20 attack rolls.

In options I set no automatic effect removal.