PDA

View Full Version : Issue with Merge Delete



damned
July 16th, 2018, 00:22
Im getting one error on opening each character sheet once per session in a MoreCore extension
Ruleset Error: windowlist: Could not find windowclass () for control (spell_list) in windowclass (charsheet_more)
the original ruleset code is:

<list_text name="spell_list">
<anchored to="spellsframe">
<left offset="10" />
<top offset="30" />
<right offset="-4" />
<bottom offset="-10" />
</anchored>
<newfocus>name</newfocus>
<datasource>.spelllist1</datasource>
<class>spell_rolls</class>
<acceptdrop>
<class>spells</class>
<class>referencetext</class>
<class>referencetextwide</class>
<field>*</field>
</acceptdrop>
</list_text>
and the code in the extension to remove is:

<list_text name="spell_list" merge="delete" />

Any thoughts?

Trenloe
July 16th, 2018, 00:44
What merge rule do you have set <windowclass> entry that control is in within your extension?

damned
July 16th, 2018, 01:14
What merge rule do you have set <windowclass> entry that control is in within your extension?

Windowclass and sheetdata are both merge=join

Trenloe
July 16th, 2018, 01:23
In the example I can see in 5E, I don't see a join parameter for <sheetdata>. In fact, searching through the 5E and 3.5E ruleset I don't see a merge parameter in <sheetdata> anywhere.

damned
July 16th, 2018, 02:12
In the example I can see in 5E, I don't see a join parameter for <sheetdata>. In fact, searching through the 5E and 3.5E ruleset I don't see a merge parameter in <sheetdata> anywhere.

Ive always done it on both but in hindsight it is not do anything because it is not named. Because it's not named it also isn't causing an issue.

Ikael
July 16th, 2018, 06:37
Maybe some lua onInit is referencing spell_list control and tries to iterate its children through. Have you merge=deleted spell_rolls as well? If you have, you could try not to delete it and see if the issue occurs.

Ps: you don't need to give merge rules to sheetdata, and probably should not. I don't know the soul life of FG engine but unless it's special case there might be "hidden" default merge rule defined for it and you don't want to alter it.

damned
July 16th, 2018, 07:26
Thanks Trenloe and Ikael

I had merge=deleted the spell_rolls as well.
Ill keep plugging away at it :)

damned
July 16th, 2018, 09:55
Im not sure but a close and restart of FG seems to have resolved the error?
I had moved on to other areas of the code and as far as I can see the code is still as above but is working.

Trenloe
July 16th, 2018, 17:28
Im not sure but a close and restart of FG seems to have resolved the error?
I had moved on to other areas of the code and as far as I can see the code is still as above but is working.
Where was your <list_text name="spell_list" merge="delete" /> code? If it was in extension.xml then that file is usually only fully read/activated when you restart FG completely.

damned
July 16th, 2018, 22:52
Where was your <list_text name="spell_list" merge="delete" /> code? If it was in extension.xml then that file is usually only fully read/activated when you restart FG completely.

Ahhh... then this was the cause of my issue. Thanks!
Yesterday took a long time to achieve a little....!