Bug in CoC Char Sheet makes some rolls report as being another character or creature

[ianmward]

Hi Moon,

I finally tracked down a little bug that was annoying us in the CoC ruleset.

In campaign/record_char_main.xml
The code to make rolls gets the actor wrongly (I suspect it's been copied from the weapons or skills code where the window is a subwindow of the character sheet)
Line 187:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode().getChild("..."));
local sDesc = "[ABILITY] Idea Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode());
local sDesc = "[ABILITY] Idea Check (" .. nTotal .. "%)";

Line 220:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode().getChild("..."));
local sDesc = "[ABILITY] Luck Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode());
local sDesc = "[ABILITY] Luck Check (" .. nTotal .. "%)";

Line 253


local rActor = ActorManager.getActor("pc", window.getDatabaseNode().getChild("..."));
local sDesc = "[ABILITY] Know Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode());
local sDesc = "[ABILITY] Know Check (" .. nTotal .. "%)";

and line 371:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode().getChild("..."));
local sDesc = "[ABILITY] Know Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", node.getChild("..."));

local nTotal = getValue();
local sDesc = "[ABILITY] Sanity Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", node);

local nTotal = getValue();
local sDesc = "[ABILITY] Sanity Check (" .. nTotal .. "%)";

Also on the mini sheet, line 1023:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode().getChild("..."));
local sDesc = "[ABILITY] Sanity Check (" .. nTotal .. "%)";
Should be:


local rActor = ActorManager.getActor("pc", window.getDatabaseNode());
local sDesc = "[ABILITY] Sanity Check (" .. nTotal .. "%)";

PLEASE NOTE: The attack and damage rolls (lines 1129 & 1153) are correct and do not need fixing.

Cheers

Ian