PDA

View Full Version : Inventory Item Applied Weight Checkbox



d1wright
April 16th, 2014, 16:35
I've always liked how the inventory arranged your gear by item location so that you could see everything in your backpack indented below it.

I also liked that when you unchecked the backpack from applied weight, everything in the backpack was also unchecked. You dropped your backpack and everything in it. Great.

It looks as though this part of the feature has recently changed. I uncheck the backpack and the contents are still checked and added to my applied weight.

Is this an intended feature change?

Seen while running v3.03 with the core 3.5 and Pathfinder rulesets.

Moon Wizard
April 16th, 2014, 20:39
As far as I know, the apply weight checkbox was never linked to items contained, at least for the last couple years that I can remember and have code for.

That said, the inventory has not had a great "container" system. It's mainly just the indenting and sorting based on the Location field.

JPG

Myrddin
April 19th, 2014, 00:36
I agree with d1wright. This used to be a great time-saving feature of the inventory (whether by accident or design) with versions prior to 3.0. It would be great to get it back.

Trenloe
April 19th, 2014, 01:25
This did used to work asd1wright and Myrddin describe above, I've just tested this with the 3.5e 2.9.3 ruleset and it works as follows:

Initial example with a couple of items in the backpack - all weight icons are ticked:

https://dl.dropboxusercontent.com/u/39085830/Screenshots/Fantasy%20Grounds/Encumbrance%20-%201.jpg

Then, to"drop" the backpack, just remove the tick/check for the backpack and the ticks are automatically removed for all of the items located in the backpack and so the weight of all items in the backpack is removed as well:

https://dl.dropboxusercontent.com/u/39085830/Screenshots/Fantasy%20Grounds/Encumbrance%20-%202.jpg

The difference in the 3.0 ruleset is that none of the extra ticks are removed, so the weight is not adjusted accordingly.

Trenloe
April 19th, 2014, 01:57
Follow up:

There is code in 3.5e v2.9.3 the button_checkbox control that does this which is not in CoreRPG:

<button_checkbox name="carried">
<bounds>-58,4,12,12</bounds>
<checked />
<script>
function onValueChanged()
if window.name.getValue() ~= "" then
for _,v in ipairs(window.windowlist.getWindows()) do
if v.location.getValue() == window.name.getValue() then
v.carried.setState(getState());
end
end
end

local nodeWin = window.getDatabaseNode();
if nodeWin then
CharManager.updateEncumbrance(nodeWin.getChild("..."));
end
end
</script>
</button_checkbox>

Moon Wizard
April 19th, 2014, 04:13
Thanks for the legwork, Trenloe. I didn't even notice that happened before. Seems simple enough to add back in, hopefully; so I'll look into 3.0.4 inclusion.

JPG

Myrddin
April 21st, 2014, 21:12
Thanks Trenloe and Moon both. The return of this functionality will be much appreciated by my players.

Trenloe
June 17th, 2014, 04:48
This didn't make it into 3.0.4, right?

Moon Wizard
June 17th, 2014, 23:48
Yes, it should be there. See CoreRPG ruleset under campaign/scripts/char_invlist.lua

Cheers,
JPG

Trenloe
June 18th, 2014, 00:03
Yes, it should be there. See CoreRPG ruleset under campaign/scripts/char_invlist.lua
Thanks M_W, but I don't see anything in in that code or the linked CharManager.updateEncumbrance that removes all of the weight (carried checkbox) for all items in a specific "location" when the location is removed. i.e. If a backpack has a number of inventory items whose location is "backpack", unchecking "carried" for the backpack should also uncheck all of the items with a location of backpack, which is what the code in post #5 above was doing in 2.9.3.

Moon Wizard
June 18th, 2014, 19:16
Ah, I misunderstood. I'll slip it into the next beta.

JPG

Myrddin
July 5th, 2014, 21:39
Any chance this could be slipped in to the 3.0.5 (A) update?

kane280484
July 6th, 2014, 09:18
I support Myrddin's plea. It's a feature all of my players and I miss.

Blacky
July 6th, 2014, 15:52
Yes, it was a nice feature…

Trenloe
October 2nd, 2014, 13:35
Any plans on this being included in a future release? Please?

kane280484
October 9th, 2014, 10:46
I am not a programmer, but since this feature was already built in previous versions, it should not be hard to bring it back?

Trenloe
October 9th, 2014, 15:13
This is now in the v3.0.9 test version as of 3 days ago: https://www.fantasygrounds.com/forums/showthread.php?22212-Test-release-v3-0-9&p=188639&viewfull=1#post188639

Nylanfs
October 9th, 2014, 15:15
And if items are missing weight, you can pull them from PCGen's data files. :)

Myrddin
October 12th, 2014, 16:13
Great. Thanks MW.

I'll switch to v3.0.9a after FG CON, since I presume we're running on 3.0.8 for the con.

Trenloe
October 12th, 2014, 16:23
Great. Thanks MW.

I'll switch to v3.0.9a after FG CON, since I presume we're running on 3.0.8 for the con.
Yes, GMs should be running on the "live" mode for FG Con.