PDA

View Full Version : Tags with v3.0.2



Leo49
March 13th, 2014, 17:30
Hello !

I'm a french woman, so, sorry by advance if my english isn't good.

I see tags errors with v3.0.2 :

1 - Order by tag is a problem :

https://domaine.colombier.free.fr/FG/OrderProblem.png
Burning Disarm is after Tripvine in this list because
Tripvine tag is "Tripvine" and Burning Disarm tag is "burningdisarm".
It's sort by tag name.

Is there a sort by label name in options ?

Note : When I open a window with a list, like in this exemple, I expected the focus in search field... but the focus don't change.




2 - Formatting Tags not recognized from character sheet (text editable) :


If I open a spell from the main list, I have this description with a correct format :

https://domaine.colombier.free.fr/FG/Tags1.png
If I drag and drop this spell in a character sheet and open it from this character sheet, I have a text with many format errors.

Note : I can edit this text, not the description without format errors.
https://domaine.colombier.free.fr/FG/Tags2.png



3 - Tags errors in a table :

In Fantasy Grounds, I have this table :
https://domaine.colombier.free.fr/FG/Table1.png

<table><tr> <td colspan=2>Test 1 : italic and bold text </td> </tr>
<tr> <td><i>italic</i> text</td> <td><b>bold</b> text</td> </tr>
<tr> <th><i>italic</i> text</th> <th><b>bold</b> text</th> </tr>
</table>

<table><tr> <td colspan=3>Test 2 : colspan and rowspan </td> </tr>
<tr> <td>Item 1</td> <td rowspan=2>Item 2</td> <td>Item 3</td> </tr>
<tr> <td>Item 4</td> <td>Item 5</td> </tr> </table>
Expected table :
https://domaine.colombier.free.fr/FG/Table2.png

Trenloe
March 13th, 2014, 17:57
Please try this in FG 3.0.3 - some of these issues, particularly #3 are fixed in 3.0.3. See the patch notes here: https://www.fantasygrounds.com/filelibrary/patchnotes.html

- Formatted text tables drawn incorrectly when text within cell partially formatted (i.e. bold, italic, etc). Fixed.

EDIT: Sorry, as pointed out by Nicademus below, I was actually referring to #3 being fixed in 3.0.3.

Nickademus
March 13th, 2014, 18:21
FG 3.0.3 fixes #3, don't know about #1. That has to do with the sort of the tags and xml treating capitals as different from lowercase. I know the list in the library window uses:
<sortby><control>name</control></sortby>Might be able to change the lists to use this as well. If it is done with FG as a whole, PLEASE give us an option to use the tags as several of my modules use special codes in the tags for sorting that I don't want in the name.

As for #2, the window class that displays the spells, spelldesc2_stats, has a string_column_full as the section that displays the description text. I assume this class doesn't support formatting. Any reason not to just change the tag to a formattedtextfield?

Leo49
March 13th, 2014, 20:29
Ok ! Thank you for these answers.
I have v3.0.3 in the main menu.
When I create a campaign for D&D4, it's v3.0.3... but if I choose Pathfinder, it's v3.0.2. Do you know why ?

Trenloe
March 13th, 2014, 20:42
When I create a campaign for D&D4, it's v3.0.3... but if I choose Pathfinder, it's v3.0.2. Do you know why ?
The PFRPG layered ruleset was did not have an update going from 3.0.2 to 3.0.3. PFRPG is layered on top of 3.5E which is in turn layered on top of CoreRPG. Both 3.5E and CoreRPG had updates in 3.0.3, but the version reported in the chat window is the main ruleset selected (PFRPG) so this still shows 3.0.2 as there was no update to the PFRPG specific code.

Leo49
March 14th, 2014, 01:11
Where is my first post ?

Ok. I see it now. Thanks.

Leo49
March 14th, 2014, 01:17
---

Nickademus
March 18th, 2014, 16:03
As for #2, the window class that displays the spells, spelldesc2_stats, has a string_column_full as the section that displays the description text. I assume this class doesn't support formatting. Any reason not to just change the tag to a formattedtextfield?

Any thought on this yet? I'm seeing a lot of spells that have had their tables and lists shredded when drug to the character sheet.

Moon Wizard
March 18th, 2014, 19:41
Leo49,

1.
Most reference lists sort by the internal module node name in a case sensitive manner. This was originally done to allow module creators to control exact ordering of module entries in the list. This can not be changed without changing the ruleset or making an extension to override.

FG does not currently support the concept of initial focus in windows, though it's something on my list to consider for future updates.

2.
FG stores the spell reference in formatted text blocks, but when transferred to the character sheet, it is converted to a multi-line text string. There are several reasons for this, including backward compatibility with campaigns, modules and character files created over different versions and years. Also, the automatic spell parsing (for attack, damage, heal and effects) only works on the multi-line text version.

3.
FG only supports a very limited subset of tags in the formattedtext database fields. The formattedtext control that displays the text is not a full HTML rendering engine, but it uses HTML-like tags when storing the information to disk. Both the "th" tag and the "rowspan" attribute are not valid for FG formatted text fields. This link gives the breakdown of supported tags for formatted text data. (https://www.fantasygrounds.com/refdoc/formattedtextcontrol.xcp)

Regards,
JPG

Moon Wizard
March 18th, 2014, 19:42
Nickademus,

See answer 1 to Leo49 above.

Short answer is that making this change while seemingly simple, causes a big backward compatibility issue and breaks automatic spell parsing.

Regards,
JPG

Nickademus
March 18th, 2014, 20:06
Understood.

Leo49
March 20th, 2014, 19:53
Thank you for your answer, Moon Wizard. :)