BUG REPORT - unregisterResultHandler() in manager_actions.lua

[dulux-oz]

Hey Guys

I think we've got a bug in the manager_actions.lua of the CoreRPG Ruleset (v3.0.7).

Original is:

function unregisterResultHandler(sRollType)
	if aResultHandlers then
		aResultHandlers[sActionType] = nil;
	end
end

Shouldn't that read:

function unregisterResultHandler(sActionType)
	if aResultHandlers then
		aResultHandlers[sActionType] = nil;
	end
end

Ie the function parameter is not the same as the array index in the original - or have I simply spent waaaayyyy too long looking at this stuff

Cheers

[Moon Wizard]

That's because there hasn't been a need to unregister action handlers. Just added for some odd sense of completeness, but no real need.

Cheers,
JPG

[dulux-oz]

That's because there hasn't been a need to unregister action handlers. Just added for some odd sense of completeness, but no real need.

Cheers,
JPG

Fair enough - but there's a need now :-)

So, will this be fixed in 3.0.8 or should we just ignore it and code it ourselves?

Cheers

[Moon Wizard]

Check the latest beta.
JPG

[dulux-oz]

Check the latest beta.
JPG

Thanks JPG