Printable View
Greetings to all again,
I just updated my FGU to 4.5.0 and now I find myself unable to modify my monsters. I know that big patches sometimes break stuff down and this seems to be the case here. Hopefully it won't be a hassle to fix.
Best regards to all,
Samzagas
You don't need to modify any monsters Samzagas, they're fine just as they are ;)Quote:
Originally Posted by Samzagas
But yeah, can confirm, can't unlock to edit any of them at all.
I just pushed an update to RMC to allow NPCs to be fully editable again and standardized with CoreRPG. Please run a new Check for Updates.
Regards,
JPG
Looks like this is resolved, thanks.
For anyone looking, the unlock button is in the upper left of the NPC sheet.
https://i.imgur.com/0Ehsqrr.png
Quote:
Originally Posted by Moon Wizard
The lock icon is there, but clicking it doesn't unlock.
If you are trying to unlock one of the NPCs from the RMC books, you first need to make a copy of it, then unlock the copy.Quote:
Originally Posted by deer_buster
You cannot modify the built-in NPCs (it was that way in previous versions as well). It's not as obvious now that is the case. In the older versions, the lock icon was Red indicating that it could not be unlocked.
If you look closely at the lock icon, if it is not unlockable, it will have an X on the lock, the one that can be unlocked has a keyhole instead.
https://i.imgur.com/Sm49Mb2.png
@deer_buster,
I'm seeing what @Sulimo is showing in his picture above. Do you have any unzipped rulesets in the FG data folder, or any extensions loaded?
Regards,
JPG
Ah, thought I had clicked on my copy of the NPC, but must have clicked the original one...it works now.Quote:
Originally Posted by Moon Wizard
still having those errors popup when I click on any of the attack items in the NPCs tho...I had posted it in the HoH
Yeah, I forwarded to Dakadin. It looks like an issue with the Character Law NPC data that's been around for a while.
Regards,
JPG
I can confirm that it seems to be working alright now. Thanks to everyone who helped solve this issue.
Looks like the <type type="number"> for the weapons should be "string" instead...Quote:
Originally Posted by Moon Wizard
Yeah, that's what I saw too; but that module hasn't been updated in many, many months. So, I think this has been an issue for a while.
Dakadin said he would take a look when he got back from a work trip.
Regards,
JPG
Hmm, the Base Spell Attack works fine when clicked on in the previous version (4.4.9), at least it's not throwing any console errors when I try it (I have not updated my main computer yet, I have a Virtual machine with the new version).
I'm not seeing a difference in the Base Spell Attack for the Pure Mentalism Spell User Level 20 between the previous version and the new one (both are dated August 2023).
Character Law from 4.4.9 (works)
Code:<id-0003>
<attacktable>
<name type="string">Base Spell Attack Table</name>
<tableid type="string">SPL04-02</tableid>
</attacktable>
<name type="string">Base Spell Attack</name>
<ob type="number">20</ob>
<type type="number">10</type>
</id-0003>
Same segment from 4.5 (broken)
Code:<id-0003>
<attacktable>
<name type="string">Base Spell Attack Table</name>
<tableid type="string">SPL04-02</tableid>
</attacktable>
<name type="string">Base Spell Attack</name>
<ob type="number">20</ob>
<type type="number">10</type>
</id-0003>
They both look the same to me. Guessing the issue is deeper in the code somewhere.
That's really odd. I looked back to August of last year; and it was exactly the same. The NPC weapon entries pointed to "item" class; and the Item type field was a string value.
I'll have to let Dakadin investigate further.
Regards,
JPG
I've opened up my Heroes and Rogues module and all my Base Attack Spells work properly.
From the segments above my code has one difference:
<type type="string">Special</type>
It looks like your code has the type set as a number. Try changing that line in your code.
Rajek
Yeah, I've looked into it and had some code running in the onInit for items that prevented this error but didn't work with the changes recently made. I am working on updating the modules and getting the code back in place so any legacy modules will work.
After some testing a workaround is to copy the NPC to the combat tracker and it will resolve the issue. Then you can copy it where ever you need it if you don't want it in the combat tracker.
The fix for the items types not matching has been pushed for Character Law, Creatures & Treasures, and RM Companion 1.
Thanks as always Dakadin. I'd add to your rep, but I apparently need to spread it around some first.Quote:
Originally Posted by Dakadin